changed var name; fixed class name; removed hashset argument from GetConfiguredController function.

This commit is contained in:
uncavo-hdmi 2025-02-22 10:15:41 +01:00
parent da268ebbee
commit 72c3ca7769
3 changed files with 215 additions and 218 deletions

View File

@ -1,11 +1,6 @@
using Ryujinx.Ava.UI.Models.Input; using Ryujinx.Ava.UI.ViewModels;
using Ryujinx.Ava.UI.ViewModels;
using Ryujinx.Ava.Utilities.Configuration; using Ryujinx.Ava.Utilities.Configuration;
using Ryujinx.Common.Configuration.Hid; using Ryujinx.Common.Configuration.Hid;
using Ryujinx.Common.Configuration.Hid.Controller;
using Ryujinx.Common.Configuration.Hid.Controller.Motion;
using ConfigGamepadInputId = Ryujinx.Common.Configuration.Hid.Controller.GamepadInputId;
using ConfigStickInputId = Ryujinx.Common.Configuration.Hid.Controller.StickInputId;
using Ryujinx.Common.Logging; using Ryujinx.Common.Logging;
using Ryujinx.Input; using Ryujinx.Input;
using Ryujinx.Input.HLE; using Ryujinx.Input.HLE;
@ -20,7 +15,7 @@ namespace Ryujinx.Ava.Input
private readonly InputManager _inputManager; private readonly InputManager _inputManager;
private readonly MainWindowViewModel _viewModel; private readonly MainWindowViewModel _viewModel;
private readonly ConfigurationState _configurationState; private readonly ConfigurationState _configurationState;
private readonly ControllerConfigurator _controllerConfigurator; private readonly ControllerAssignmentManager _assignmentManager;
public event Action ConfigurationUpdated; public event Action ConfigurationUpdated;
@ -29,7 +24,7 @@ namespace Ryujinx.Ava.Input
_inputManager = inputManager; _inputManager = inputManager;
_viewModel = mainWindowViewModel; _viewModel = mainWindowViewModel;
_configurationState = ConfigurationState.Instance; _configurationState = ConfigurationState.Instance;
_controllerConfigurator = new ControllerConfigurator(); _assignmentManager = new ControllerAssignmentManager();
_inputManager.GamepadDriver.OnGamepadConnected += HandleOnGamepadConnected; _inputManager.GamepadDriver.OnGamepadConnected += HandleOnGamepadConnected;
_inputManager.GamepadDriver.OnGamepadDisconnected += HandleOnGamepadDisconnected; _inputManager.GamepadDriver.OnGamepadDisconnected += HandleOnGamepadDisconnected;
@ -56,8 +51,8 @@ namespace Ryujinx.Ava.Input
List<IGamepad> controllers = _inputManager.GamepadDriver.GetGamepads().ToList(); List<IGamepad> controllers = _inputManager.GamepadDriver.GetGamepads().ToList();
List<InputConfig> oldConfig = _configurationState.Hid.InputConfig.Value.Where(x => x != null).ToList(); List<InputConfig> oldConfig = _configurationState.Hid.InputConfig.Value.Where(x => x != null).ToList();
List<InputConfig> newConfig = _controllerConfigurator.GetConfiguredControllers( List<InputConfig> newConfig = _assignmentManager.GetConfiguredControllers(
controllers, oldConfig, new HashSet<int>(), out bool hasNewControllersConnected); controllers, oldConfig, out bool hasNewControllersConnected);
_viewModel.AppHost?.NpadManager.ReloadConfiguration(newConfig, _configurationState.Hid.EnableKeyboard, _configurationState.Hid.EnableMouse); _viewModel.AppHost?.NpadManager.ReloadConfiguration(newConfig, _configurationState.Hid.EnableKeyboard, _configurationState.Hid.EnableMouse);
@ -66,7 +61,7 @@ namespace Ryujinx.Ava.Input
// there is no *new* controller, we must switch the order of the controllers in // there is no *new* controller, we must switch the order of the controllers in
// oldConfig to match the new order since probably a controller was disconnected // oldConfig to match the new order since probably a controller was disconnected
// or an old controller was reconnected // or an old controller was reconnected
newConfig = _controllerConfigurator.ReorderControllers(newConfig, oldConfig); newConfig = ControllerAssignmentManager.ReorderControllers(newConfig, oldConfig);
} }
_configurationState.Hid.InputConfig.Value = newConfig; _configurationState.Hid.InputConfig.Value = newConfig;

View File

@ -10,83 +10,86 @@ using StickInputId = Ryujinx.Common.Configuration.Hid.Controller.StickInputId;
namespace Ryujinx.Ava.Input namespace Ryujinx.Ava.Input
{ {
public class ControllerConfigurator public class ControllerAssignmentManager
{
private readonly uint[] _playerColors =
[
0xFFFF0000, // Player 1 - Red
0xFF0000FF, // Player 2 - Blue
0xFF00FF00, // Player 3 - Green
0xFFFFFF00, // Player 4 - Yellow
0xFFFF00FF, // Player 5 - Magenta
0xFFFFA500, // Player 6 - Orange
0xFF00FFFF, // Player 7 - Cyan
0xFF800080 // Player 8 - Purple
];
private const int MaxControllers = 9;
public List<InputConfig> ReorderControllers(List<InputConfig> newConfig, List<InputConfig> oldConfig)
{ {
List<InputConfig> reorderedConfig = oldConfig.Select(config => new GamepadInputConfig(config).GetConfig()).ToList(); private readonly uint[] _playerColors =
[
0xFFFF0000, // Player 1 - Red
0xFF0000FF, // Player 2 - Blue
0xFF00FF00, // Player 3 - Green
0xFFFFFF00, // Player 4 - Yellow
0xFFFF00FF, // Player 5 - Magenta
0xFFFFA500, // Player 6 - Orange
0xFF00FFFF, // Player 7 - Cyan
0xFF800080 // Player 8 - Purple
];
foreach (var config in newConfig) private const int MaxControllers = 9;
public static List<InputConfig> ReorderControllers(List<InputConfig> newConfig, List<InputConfig> oldConfig)
{ {
InputConfig substitute = reorderedConfig.FirstOrDefault(x => x.Id == config.Id); List<InputConfig> reorderedConfig = oldConfig.Select(config => new GamepadInputConfig(config).GetConfig()).ToList();
InputConfig toBeReplaced = reorderedConfig.FirstOrDefault(x => x.PlayerIndex == config.PlayerIndex);
if (substitute == null || toBeReplaced == null || substitute.PlayerIndex == toBeReplaced.PlayerIndex) continue; foreach (var config in newConfig)
{
InputConfig substitute = reorderedConfig.FirstOrDefault(x => x.Id == config.Id);
InputConfig toBeReplaced = reorderedConfig.FirstOrDefault(x => x.PlayerIndex == config.PlayerIndex);
(substitute.PlayerIndex, toBeReplaced.PlayerIndex) = (toBeReplaced.PlayerIndex, substitute.PlayerIndex); if (substitute == null || toBeReplaced == null || substitute.PlayerIndex == toBeReplaced.PlayerIndex) continue;
(substitute.PlayerIndex, toBeReplaced.PlayerIndex) = (toBeReplaced.PlayerIndex, substitute.PlayerIndex);
}
return reorderedConfig;
} }
return reorderedConfig; public List<InputConfig> GetConfiguredControllers(
} List<IGamepad> controllers,
List<InputConfig> oldConfig,
public List<InputConfig> GetConfiguredControllers( out bool hasNewControllersConnected)
List<IGamepad> controllers,
List<InputConfig> oldConfig,
HashSet<int> usedIndices,
out bool hasNewControllersConnected)
{
Dictionary<string, InputConfig> oldConfigMap = oldConfig
.Where(c => c?.Id != null)
.ToDictionary(x => x.Id);
Dictionary<int, InputConfig> playerIndexMap = new();
int recognizedControllersCount = 0;
List<IGamepad> remainingControllers = controllers.Where(c => c?.Id != null).ToList();
// Add controllers with existing configurations
AddExistingControllers(remainingControllers, oldConfigMap, playerIndexMap, usedIndices, ref recognizedControllersCount);
// Add new controllers
AddNewControllers(remainingControllers, playerIndexMap, usedIndices);
List<InputConfig> orderedConfigs = playerIndexMap
.OrderBy(x => x.Key)
.Select(x => x.Value)
.ToList();
// Update player indices and LED colors
UpdatePlayerIndicesAndLEDs(orderedConfigs);
hasNewControllersConnected = controllers.Count > recognizedControllersCount;
return orderedConfigs;
}
private void AddExistingControllers(
List<IGamepad> controllers,
Dictionary<string, InputConfig> oldConfigMap,
Dictionary<int, InputConfig> playerIndexMap,
HashSet<int> usedIndices,
ref int recognizedControllersCount)
{
foreach (var controller in controllers.ToList())
{ {
if (oldConfigMap.TryGetValue(controller.Id, out InputConfig existingConfig)) Dictionary<string, InputConfig> oldConfigMap = oldConfig
.Where(c => c?.Id != null)
.ToDictionary(x => x.Id);
Dictionary<int, InputConfig> playerIndexMap = new();
HashSet<int> usedIndices = [];
int recognizedControllersCount = 0;
List<IGamepad> remainingControllers = controllers.Where(c => c?.Id != null).ToList();
// Add controllers with existing configurations
AddExistingControllers(remainingControllers, oldConfigMap, playerIndexMap, usedIndices, ref recognizedControllersCount);
// Add new controllers
AddNewControllers(remainingControllers, playerIndexMap, usedIndices);
List<InputConfig> orderedConfigs = playerIndexMap
.OrderBy(x => x.Key)
.Select(x => x.Value)
.ToList();
// Update player indices and LED colors
UpdatePlayerIndicesAndLEDs(orderedConfigs);
hasNewControllersConnected = controllers.Count > recognizedControllersCount;
return orderedConfigs;
}
private static void AddExistingControllers(
List<IGamepad> controllers,
Dictionary<string, InputConfig> oldConfigMap,
Dictionary<int, InputConfig> playerIndexMap,
HashSet<int> usedIndices,
ref int recognizedControllersCount)
{
foreach (var controller in controllers.ToList())
{ {
if (!oldConfigMap.TryGetValue(controller.Id, out InputConfig existingConfig))
{
continue;
}
int desiredIndex = (int)existingConfig.PlayerIndex; int desiredIndex = (int)existingConfig.PlayerIndex;
// Ensure the index is valid and available // Ensure the index is valid and available
@ -106,159 +109,158 @@ namespace Ryujinx.Ava.Input
controllers.Remove(controller); controllers.Remove(controller);
} }
} }
}
private void AddNewControllers( private static void AddNewControllers(
List<IGamepad> controllers, List<IGamepad> controllers,
Dictionary<int, InputConfig> playerIndexMap, Dictionary<int, InputConfig> playerIndexMap,
HashSet<int> usedIndices) HashSet<int> usedIndices)
{
foreach (var controller in controllers)
{ {
InputConfig config = CreateConfigFromController(controller); foreach (var controller in controllers)
int freeIndex = GetFirstAvailableIndex(usedIndices);
config.PlayerIndex = (PlayerIndex)freeIndex;
usedIndices.Add(freeIndex);
playerIndexMap[freeIndex] = config;
}
}
private int GetFirstAvailableIndex(HashSet<int> usedIndices)
{
for (int i = 0; i < MaxControllers; i++)
{
if (!usedIndices.Contains(i)) return i;
}
return -1; // Should not happen unless MaxControllers is exceeded
}
private void UpdatePlayerIndicesAndLEDs(List<InputConfig> orderedConfigs)
{
for (int index = 0; index < orderedConfigs.Count; index++)
{
orderedConfigs[index].PlayerIndex = (PlayerIndex)index;
if (orderedConfigs[index] is not StandardControllerInputConfig standardConfig ||
standardConfig.Led.UseRainbow)
{ {
continue; InputConfig config = CreateConfigFromController(controller);
int freeIndex = GetFirstAvailableIndex(usedIndices);
config.PlayerIndex = (PlayerIndex)freeIndex;
usedIndices.Add(freeIndex);
playerIndexMap[freeIndex] = config;
} }
Logger.Warning?.Print(LogClass.Application, $"Setting color for Player{index + 1}");
standardConfig.Led = new LedConfigController
{
EnableLed = true,
LedColor = _playerColors[index]
};
} }
}
private static InputConfig CreateConfigFromController(IGamepad controller) private static int GetFirstAvailableIndex(HashSet<int> usedIndices)
{ {
if (controller == null) return null; for (int i = 0; i < MaxControllers; i++)
Logger.Warning?.Print(LogClass.Application, $"Creating config for controller: {controller.Id}");
string id = controller.Id.Split(" ")[0];
bool isNintendoStyle = controller.Name.Contains("Nintendo");
ControllerType controllerType;
if (isNintendoStyle && !controller.Name.Contains("(L/R)"))
{ {
if (controller.Name.Contains("(L)")) if (!usedIndices.Contains(i)) return i;
}
return -1; // Should not happen unless MaxControllers is exceeded
}
private void UpdatePlayerIndicesAndLEDs(List<InputConfig> orderedConfigs)
{
for (int index = 0; index < orderedConfigs.Count; index++)
{
orderedConfigs[index].PlayerIndex = (PlayerIndex)index;
if (orderedConfigs[index] is not StandardControllerInputConfig standardConfig ||
standardConfig.Led.UseRainbow)
{ {
controllerType = ControllerType.JoyconLeft; continue;
} }
else if (controller.Name.Contains("(R)"))
Logger.Warning?.Print(LogClass.Application, $"Setting color for Player{index + 1}");
standardConfig.Led = new LedConfigController
{ {
controllerType = ControllerType.JoyconRight; EnableLed = true,
LedColor = _playerColors[index]
};
}
}
private static InputConfig CreateConfigFromController(IGamepad controller)
{
if (controller == null) return null;
Logger.Warning?.Print(LogClass.Application, $"Creating config for controller: {controller.Id}");
string id = controller.Id.Split(" ")[0];
bool isNintendoStyle = controller.Name.Contains("Nintendo");
ControllerType controllerType;
if (isNintendoStyle && !controller.Name.Contains("(L/R)"))
{
if (controller.Name.Contains("(L)"))
{
controllerType = ControllerType.JoyconLeft;
}
else if (controller.Name.Contains("(R)"))
{
controllerType = ControllerType.JoyconRight;
}
else
{
controllerType = ControllerType.ProController;
}
} }
else else
{ {
// if it's not a nintendo controller, we assume it's a pro controller or a joy-con pair
controllerType = ControllerType.ProController; controllerType = ControllerType.ProController;
} }
}
else
{
// if it's not a nintendo controller, we assume it's a pro controller or a joy-con pair
controllerType = ControllerType.ProController;
}
InputConfig config = new StandardControllerInputConfig InputConfig config = new StandardControllerInputConfig
{
Version = InputConfig.CurrentVersion,
Backend = InputBackendType.GamepadSDL2,
Id = id,
ControllerType = controllerType,
DeadzoneLeft = 0.1f,
DeadzoneRight = 0.1f,
RangeLeft = 1.0f,
RangeRight = 1.0f,
TriggerThreshold = 0.5f,
LeftJoycon = new LeftJoyconCommonConfig<GamepadInputId>
{ {
DpadUp = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.Y : GamepadInputId.DpadUp, Version = InputConfig.CurrentVersion,
DpadDown = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.A : GamepadInputId.DpadDown, Backend = InputBackendType.GamepadSDL2,
DpadLeft = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.B : GamepadInputId.DpadLeft, Id = id,
DpadRight = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.X : GamepadInputId.DpadRight, ControllerType = controllerType,
ButtonMinus = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.Plus : GamepadInputId.Minus, DeadzoneLeft = 0.1f,
ButtonL = GamepadInputId.LeftShoulder, DeadzoneRight = 0.1f,
ButtonZl = GamepadInputId.LeftTrigger, RangeLeft = 1.0f,
ButtonSl = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.LeftShoulder : GamepadInputId.Unbound, RangeRight = 1.0f,
ButtonSr = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.RightShoulder : GamepadInputId.Unbound, TriggerThreshold = 0.5f,
}, LeftJoycon = new LeftJoyconCommonConfig<GamepadInputId>
LeftJoyconStick = new JoyconConfigControllerStick<GamepadInputId, StickInputId> {
{ DpadUp = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.Y : GamepadInputId.DpadUp,
Joystick = StickInputId.Left, DpadDown = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.A : GamepadInputId.DpadDown,
StickButton = GamepadInputId.LeftStick, DpadLeft = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.B : GamepadInputId.DpadLeft,
InvertStickX = false, DpadRight = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.X : GamepadInputId.DpadRight,
InvertStickY = false, ButtonMinus = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.Plus : GamepadInputId.Minus,
Rotate90CW = (controllerType == ControllerType.JoyconLeft), ButtonL = GamepadInputId.LeftShoulder,
}, ButtonZl = GamepadInputId.LeftTrigger,
RightJoycon = new RightJoyconCommonConfig<GamepadInputId> ButtonSl = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.LeftShoulder : GamepadInputId.Unbound,
{ ButtonSr = (controllerType == ControllerType.JoyconLeft) ? GamepadInputId.RightShoulder : GamepadInputId.Unbound,
ButtonA = GamepadInputId.B, },
ButtonB = (controllerType == ControllerType.JoyconRight) ? GamepadInputId.Y : GamepadInputId.A, LeftJoyconStick = new JoyconConfigControllerStick<GamepadInputId, StickInputId>
ButtonX = (controllerType == ControllerType.JoyconRight) ? GamepadInputId.A : GamepadInputId.Y, {
ButtonY = GamepadInputId.X, Joystick = StickInputId.Left,
ButtonPlus = GamepadInputId.Plus, StickButton = GamepadInputId.LeftStick,
ButtonR = GamepadInputId.RightShoulder, InvertStickX = false,
ButtonZr = GamepadInputId.RightTrigger, InvertStickY = false,
ButtonSl = (controllerType == ControllerType.JoyconRight) ? GamepadInputId.LeftShoulder : GamepadInputId.Unbound, Rotate90CW = (controllerType == ControllerType.JoyconLeft),
ButtonSr = (controllerType == ControllerType.JoyconRight) ? GamepadInputId.RightShoulder : GamepadInputId.Unbound, },
}, RightJoycon = new RightJoyconCommonConfig<GamepadInputId>
RightJoyconStick = new JoyconConfigControllerStick<GamepadInputId, StickInputId> {
{ ButtonA = GamepadInputId.B,
Joystick = (controllerType == ControllerType.JoyconRight) ? StickInputId.Left : StickInputId.Right, ButtonB = (controllerType == ControllerType.JoyconRight) ? GamepadInputId.Y : GamepadInputId.A,
StickButton = GamepadInputId.RightStick, ButtonX = (controllerType == ControllerType.JoyconRight) ? GamepadInputId.A : GamepadInputId.Y,
InvertStickX = (controllerType == ControllerType.JoyconRight), ButtonY = GamepadInputId.X,
InvertStickY = (controllerType == ControllerType.JoyconRight), ButtonPlus = GamepadInputId.Plus,
Rotate90CW = (controllerType == ControllerType.JoyconRight), ButtonR = GamepadInputId.RightShoulder,
}, ButtonZr = GamepadInputId.RightTrigger,
Motion = new StandardMotionConfigController ButtonSl = (controllerType == ControllerType.JoyconRight) ? GamepadInputId.LeftShoulder : GamepadInputId.Unbound,
{ ButtonSr = (controllerType == ControllerType.JoyconRight) ? GamepadInputId.RightShoulder : GamepadInputId.Unbound,
MotionBackend = MotionInputBackendType.GamepadDriver, },
EnableMotion = true, RightJoyconStick = new JoyconConfigControllerStick<GamepadInputId, StickInputId>
Sensitivity = 100, {
GyroDeadzone = 1, Joystick = (controllerType == ControllerType.JoyconRight) ? StickInputId.Left : StickInputId.Right,
}, StickButton = GamepadInputId.RightStick,
Rumble = new RumbleConfigController InvertStickX = (controllerType == ControllerType.JoyconRight),
{ InvertStickY = (controllerType == ControllerType.JoyconRight),
StrongRumble = 1f, Rotate90CW = (controllerType == ControllerType.JoyconRight),
WeakRumble = 1f, },
EnableRumble = false, Motion = new StandardMotionConfigController
}, {
Led = new LedConfigController MotionBackend = MotionInputBackendType.GamepadDriver,
{ EnableMotion = true,
EnableLed = true, Sensitivity = 100,
TurnOffLed = false, GyroDeadzone = 1,
UseRainbow = false, },
LedColor = 0, Rumble = new RumbleConfigController
}, {
}; StrongRumble = 1f,
WeakRumble = 1f,
EnableRumble = false,
},
Led = new LedConfigController
{
EnableLed = true,
TurnOffLed = false,
UseRainbow = false,
LedColor = 0,
},
};
return config; return config;
} }
} }
} }