MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Fixed a bug where, when switching players, it would show old config #122

Merged
Goodfeat merged 10 commits from master into master 2024-11-10 05:24:17 +00:00
Conversation 3 Commits 10 Files Changed 7 +119 -7
Goodfeat commented 2024-10-31 06:30:44 +00:00 (Migrated from github.com)
Copy Link

When switching between players' gamepads while saving settings, then returning to the previous player, the settings show the default settings instead of the actual settings applied

before the fix

https://github.com/user-attachments/assets/252c0735-558b-4f86-afed-271f58e677ec

after the fix

https://github.com/user-attachments/assets/816d9424-897e-4504-b82b-b7af5162531c

When switching between players' gamepads while saving settings, then returning to the previous player, the settings show the default settings instead of the actual settings applied before the fix https://github.com/user-attachments/assets/252c0735-558b-4f86-afed-271f58e677ec after the fix https://github.com/user-attachments/assets/816d9424-897e-4504-b82b-b7af5162531c
github-actions[bot] commented 2024-10-31 06:40:21 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less (SDL2)
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+ad4666a-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167706437.zip) * [ryujinx-Release-1.2.0+ad4666a-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167706465.zip) * [ryujinx-Release-1.2.0+ad4666a-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167708103.zip) * [ryujinx-Release-1.2.0+ad4666a-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167708143.zip) * [ryujinx-Release-1.2.0+ad4666a-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167710144.zip) * [ryujinx-Release-1.2.0+ad4666a-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167712855.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+ad4666a-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167706507.zip) * [sdl2-ryujinx-headless-Release-1.2.0+ad4666a-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167708190.zip) * [sdl2-ryujinx-headless-Release-1.2.0+ad4666a-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167710203.zip) * [sdl2-ryujinx-headless-Release-1.2.0+ad4666a-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167712892.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+ad4666a-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167706835.zip) * [ryujinx-Debug-1.2.0+ad4666a-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167706899.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+ad4666a-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167706951.zip) * [ryujinx-Debug-1.2.0+ad4666a-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167709130.zip) * [ryujinx-Debug-1.2.0+ad4666a-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167709203.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+ad4666a-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167709269.zip) * [ryujinx-Debug-1.2.0+ad4666a-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167710468.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+ad4666a-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167710500.zip) * [ryujinx-Debug-1.2.0+ad4666a-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167713853.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+ad4666a-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2167713887.zip) </details>
Goodfeat commented 2024-11-02 12:05:05 +00:00 (Migrated from github.com)
Copy Link

list of changes:

  • Fixed the interface logic in the input section. Now, with any change of parameter (buttons, checkboxes, sliders) there will be a request to save when switching between players.
  • Added another item "Cancel" in the gamepad parameters saving menu, which allows you to continue and fine-tune the gamepad.
list of changes: - Fixed the interface logic in the input section. Now, with any change of parameter (buttons, checkboxes, sliders) there will be a request to save when switching between players. - Added another item "Cancel" in the gamepad parameters saving menu, which allows you to continue and fine-tune the gamepad.
StevensND (Migrated from github.com) approved these changes 2024-11-03 14:19:10 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
StevensND
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#122
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?