MeloNX/Ryujinx-ryubing
11
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

WIP: Add language localisation for all missing items #171

Closed
amurgshere wants to merge 2 commits from update-all-language-items-from-google-translate into master
pull from: update-all-language-items-from-google-translate
merge into: MeloNX:master
Conversation 5 Commits 2 Files Changed 15 +272 -4
amurgshere commented 2024-11-03 09:55:10 +00:00 (Migrated from github.com)
Copy Link

Add language localisation for all missing items
Remove unused AutoloadDlcAndUpdateAddedMessage

First attempt was not passing through the region information for the language and was only using the Language itself, e.g. "zh_TW" was Chinese Simplified not Chinese Traditional, this has now been fixed so that Region information is also used when converting, confirmed that new items in "zh_TW" are now using Traditional Chinese.

Created a utilty which uses the publicly accessible Google Translate to find all missing locale items and translate them, the utility preserves all original encoding and translations and only adds the missing ones, please help me to confirm the language conversions are good. I did consider sorting all of them so that the locales are all in alphabetical order of name, but that would have caused us to lose our ability to diff these accurately, so left them in the order they are in as much as possible.

For some reason it is complaining about bidirectional unicode characters, but these were already in there, I can regenerate them and not use the JavaScriptEncoder.UnsafeRelaxedJsonEscaping encoder, but this will then end up modifying a lot of these items using /uxxxx syntax instead which I feel is not ideal.

Add language localisation for all missing items Remove unused AutoloadDlcAndUpdateAddedMessage First attempt was not passing through the region information for the language and was only using the Language itself, e.g. "zh_TW" was Chinese Simplified not Chinese Traditional, this has now been fixed so that Region information is also used when converting, confirmed that new items in "zh_TW" are now using Traditional Chinese. Created a utilty which uses the publicly accessible Google Translate to find all missing locale items and translate them, the utility preserves all original encoding and translations and only adds the missing ones, please help me to confirm the language conversions are good. I did consider sorting all of them so that the locales are all in alphabetical order of name, but that would have caused us to lose our ability to diff these accurately, so left them in the order they are in as much as possible. For some reason it is complaining about bidirectional unicode characters, but these were already in there, I can regenerate them and not use the JavaScriptEncoder.UnsafeRelaxedJsonEscaping encoder, but this will then end up modifying a lot of these items using /uxxxx syntax instead which I feel is not ideal.
github-actions[bot] commented 2024-11-03 09:03:54 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less (SDL2)
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+4bf9c6a-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137613167.zip) * [ryujinx-Release-1.2.0+4bf9c6a-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137614629.zip) * [ryujinx-Release-1.2.0+4bf9c6a-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137616210.zip) * [ryujinx-Release-1.2.0+4bf9c6a-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137618419.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+4bf9c6a-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137613186.zip) * [sdl2-ryujinx-headless-Release-1.2.0+4bf9c6a-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137614676.zip) * [sdl2-ryujinx-headless-Release-1.2.0+4bf9c6a-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137616244.zip) * [sdl2-ryujinx-headless-Release-1.2.0+4bf9c6a-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137618472.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+4bf9c6a-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137613434.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+4bf9c6a-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137613475.zip) * [ryujinx-Debug-1.2.0+4bf9c6a-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137615329.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+4bf9c6a-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137615374.zip) * [ryujinx-Debug-1.2.0+4bf9c6a-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137616268.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+4bf9c6a-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137616295.zip) * [ryujinx-Debug-1.2.0+4bf9c6a-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137618695.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+4bf9c6a-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2137618772.zip) </details>
amurgshere commented 2024-11-03 09:59:08 +00:00 (Migrated from github.com)
Copy Link

Hey @GreemDev ,

I have created this as a Draft for now, the tool has been fixed to use the correct language for Chinese Simplified vs Traditional.

I have put the tool on GitHub, you can find it here:

https://github.com/amurgshere/LanguageLocaliser

Thank You.

Hey @GreemDev , I have created this as a Draft for now, the tool has been fixed to use the correct language for Chinese Simplified vs Traditional. I have put the tool on GitHub, you can find it here: https://github.com/amurgshere/LanguageLocaliser Thank You.
amurgshere commented 2024-11-04 12:56:09 +00:00 (Migrated from github.com)
Copy Link

Hey @WilliamWsyHK ,

Are you able to check out the translations for Chinese in this one and let me know if there are still issues?

Thank You.

Hey @WilliamWsyHK , Are you able to check out the translations for Chinese in this one and let me know if there are still issues? Thank You.
WilliamWsyHK commented 2024-11-04 13:04:45 +00:00 (Migrated from github.com)
Copy Link

I have already commented yesterday on the file, and one of the translations is painfully wrong.
Please I am begging you not to translate any languages you don't know.

Adding the English in each of the locale is already good enough to fill up those gaps so that those people who know that language can at least start from somewhere.

I have already commented yesterday on the file, and one of the translations is painfully wrong. Please I am begging you not to translate any languages you don't know. Adding the English in each of the locale is already good enough to fill up those gaps so that those people who know that language can at least start from somewhere.
amurgshere commented 2024-11-04 13:28:28 +00:00 (Migrated from github.com)
Copy Link

Ok then no problem, just trying to help @WilliamWsyHK , will leave the translation to you.

Ok then no problem, just trying to help @WilliamWsyHK , will leave the translation to you.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0-Blu Fen Lonkelle Propenchieferr Stern bella jkcoxson june ny spidy123222 stossy11
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#171
No description provided.
Delete Branch "update-all-language-items-from-google-translate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?