MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

fix: remove --deep #188

Merged
Kek5chen merged 1 commits from master into master 2024-11-07 00:19:00 +00:00
Conversation 9 Commits 1 Files Changed 5 +9 -9
Kek5chen commented 2024-11-05 18:48:32 +00:00 (Migrated from github.com)
Copy Link

Resolves #182

See issue for more info.

Resolves #182 See issue for more info.
GreemDev commented 2024-11-05 18:56:18 +00:00 (Migrated from github.com)
Copy Link

If you could test this PR build once it finishes to see if anything is broken that'd be appreciated; I don't own a mac.
If all is well I should have no issues merging.

If you could test this PR build once it finishes to see if anything is broken that'd be appreciated; I don't own a mac. If all is well I should have no issues merging.
github-actions[bot] commented 2024-11-05 18:59:23 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less (SDL2)
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+62c4448-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148452445.zip) * [ryujinx-Release-1.2.0+62c4448-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148458940.zip) * [ryujinx-Release-1.2.0+62c4448-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148467537.zip) * [ryujinx-Release-1.2.0+62c4448-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148475648.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+62c4448-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148452640.zip) * [sdl2-ryujinx-headless-Release-1.2.0+62c4448-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148459430.zip) * [sdl2-ryujinx-headless-Release-1.2.0+62c4448-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148467742.zip) * [sdl2-ryujinx-headless-Release-1.2.0+62c4448-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148475944.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+62c4448-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148453462.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+62c4448-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148453677.zip) * [ryujinx-Debug-1.2.0+62c4448-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148463183.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+62c4448-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148463378.zip) * [ryujinx-Debug-1.2.0+62c4448-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148469037.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+62c4448-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148469273.zip) * [ryujinx-Debug-1.2.0+62c4448-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148481453.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+62c4448-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2148481714.zip) </details>
Bentheminernz commented 2024-11-05 19:55:12 +00:00 (Migrated from github.com)
Copy Link

If you could test this PR build once it finishes to see if anything is broken that'd be appreciated; I don't own a mac. If all is well I should have no issues merging.

Everything is working the same as before for me. All still works

> If you could test this PR build once it finishes to see if anything is broken that'd be appreciated; I don't own a mac. If all is well I should have no issues merging. Everything is working the same as before for me. All still works
Kek5chen commented 2024-11-05 21:23:02 +00:00 (Migrated from github.com)
Copy Link

It also builds in nixpkgs. That was my success marker. Just previously it didn't build on MacOS 13.0+ because of the removal of --deep from codesign

It also builds in nixpkgs. That was my success marker. Just previously it didn't build on MacOS 13.0+ because of the removal of --deep from codesign
sokennethwasall commented 2024-11-06 05:46:33 +00:00 (Migrated from github.com)
Copy Link

Working well. Seems to be more stable than the current version- Been playing Echoes of Wisdom for a couple hours now without a crash

Working well. Seems to be more stable than the current version- Been playing Echoes of Wisdom for a couple hours now without a crash
amurgshere commented 2024-11-08 14:14:09 +00:00 (Migrated from github.com)
Copy Link

Hello @GreemDev ,

Since this has been checked in I can no longer create and sign the app bundle locally.

I am using the following to build, create, and sign the app bundle:

./distribution/macos/create_macos_build_ava.sh ./ ./distribution/macos/temp ./distribution/macos/output ./distribution/macos/entitlements.xml 1.0.0 0 Release

I get this error when it attempts to sign:

/Volumes/MACBOOK/ROMS/NSW/Ryujinx/GitHub/Ryujinx/distribution/macos/temp/output_x64/Ryujinx.app: code object is not signed at all
In subcomponent: /Volumes/MACBOOK/ROMS/NSW/Ryujinx/GitHub/Ryujinx/distribution/macos/temp/output_x64/Ryujinx.app/Contents/Frameworks/libglfw.3.dylib

if I reinstate the "--deep" parameter it starts working again, I assume this is because the "/libglfw.3.dylib" file and other library files need to be re-signed and it is no longer being signed because of the missing "--deep" parameter, do I need to do something differently now to get the app bundle to be signed successfully?

Note that if I add an extra line before this line in the "create_app_bundle.sh" script:

codesign --entitlements "$ENTITLEMENTS_FILE_PATH" -f -s - "$APP_BUNDLE_DIRECTORY"

Of:

find "$APP_BUNDLE_DIRECTORY" -name "*.dylib" -exec codesign -f -s - {} ;

Forcing these libraries to be code re-signed, the issue also goes away, maybe we should add this line in?

REPRODUCTION

  1. Clone the repository to an M1 MAC
  2. Run this command from the cloned directory:

./distribution/macos/create_macos_build_ava.sh ./ ./distribution/macos/temp ./distribution/macos/output ./distribution/macos/entitlements.xml 1.0.0 0 Release

  1. x64 version is not signed properly and Universal bundle is not created at all as the x64 signing failed which stops the script.

Thank You.

Hello @GreemDev , Since this has been checked in I can no longer create and sign the app bundle locally. I am using the following to build, create, and sign the app bundle: ./distribution/macos/create_macos_build_ava.sh ./ ./distribution/macos/temp ./distribution/macos/output ./distribution/macos/entitlements.xml 1.0.0 0 Release I get this error when it attempts to sign: /Volumes/MACBOOK/ROMS/NSW/Ryujinx/GitHub/Ryujinx/distribution/macos/temp/output_x64/Ryujinx.app: code object is not signed at all In subcomponent: /Volumes/MACBOOK/ROMS/NSW/Ryujinx/GitHub/Ryujinx/distribution/macos/temp/output_x64/Ryujinx.app/Contents/Frameworks/libglfw.3.dylib if I reinstate the "--deep" parameter it starts working again, I assume this is because the "/libglfw.3.dylib" file and other library files need to be re-signed and it is no longer being signed because of the missing "--deep" parameter, do I need to do something differently now to get the app bundle to be signed successfully? Note that if I add an extra line before this line in the "create_app_bundle.sh" script: codesign --entitlements "$ENTITLEMENTS_FILE_PATH" -f -s - "$APP_BUNDLE_DIRECTORY" Of: find "$APP_BUNDLE_DIRECTORY" -name "*.dylib" -exec codesign -f -s - {} \; Forcing these libraries to be code re-signed, the issue also goes away, maybe we should add this line in? REPRODUCTION 1) Clone the repository to an M1 MAC 2) Run this command from the cloned directory: ./distribution/macos/create_macos_build_ava.sh ./ ./distribution/macos/temp ./distribution/macos/output ./distribution/macos/entitlements.xml 1.0.0 0 Release 3) x64 version is not signed properly and Universal bundle is not created at all as the x64 signing failed which stops the script. Thank You.
Juoelenis commented 2024-11-08 17:54:48 +00:00 (Migrated from github.com)
Copy Link

does it fix crashing on rasberry pi 5?

does it fix crashing on rasberry pi 5?
Kek5chen commented 2024-11-09 13:27:52 +00:00 (Migrated from github.com)
Copy Link

@amurgshere please make a new issue for this.

@amurgshere please make a new issue for this.
amurgshere commented 2024-11-09 14:44:39 +00:00 (Migrated from github.com)
Copy Link

Thanks @Kek5chen , I have raised Issue https://github.com/GreemDev/Ryujinx/issues/210 and Pull Request https://github.com/GreemDev/Ryujinx/pull/208 .

Thanks @Kek5chen , I have raised Issue https://github.com/GreemDev/Ryujinx/issues/210 and Pull Request https://github.com/GreemDev/Ryujinx/pull/208 .
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
infra
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#188
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?