MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Migrate to .NET 9 #198

Merged
marco-carvalho merged 13 commits from net90 into master 2024-12-20 00:52:25 +00:00
Conversation 23 Commits 13 Files Changed 136 +278 -270
marco-carvalho commented 2024-11-06 12:15:48 +00:00 (Migrated from github.com)
Copy Link
No description provided.
❤️ 11
github-actions[bot] commented 2024-11-06 12:32:26 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+17e9f2c-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346276481.zip) * [ryujinx-Release-1.2.0+17e9f2c-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346276542.zip) * [ryujinx-Release-1.2.0+17e9f2c-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346280600.zip) * [ryujinx-Release-1.2.0+17e9f2c-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346280659.zip) * [ryujinx-Release-1.2.0+17e9f2c-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346283589.zip) * [ryujinx-Release-1.2.0+17e9f2c-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346288099.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+17e9f2c-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346276643.zip) * [nogui-ryujinx-Release-1.2.0+17e9f2c-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346280741.zip) * [nogui-ryujinx-Release-1.2.0+17e9f2c-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346283744.zip) * [nogui-ryujinx-Release-1.2.0+17e9f2c-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346288241.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+17e9f2c-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346276707.zip) * [ryujinx-Debug-1.2.0+17e9f2c-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346276774.zip) * [nogui-ryujinx-Debug-1.2.0+17e9f2c-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346276849.zip) * [ryujinx-Debug-1.2.0+17e9f2c-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346280933.zip) * [ryujinx-Debug-1.2.0+17e9f2c-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346280994.zip) * [nogui-ryujinx-Debug-1.2.0+17e9f2c-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346281096.zip) * [ryujinx-Debug-1.2.0+17e9f2c-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346283491.zip) * [nogui-ryujinx-Debug-1.2.0+17e9f2c-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346283596.zip) * [ryujinx-Debug-1.2.0+17e9f2c-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346289689.zip) * [nogui-ryujinx-Debug-1.2.0+17e9f2c-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346289869.zip) </details>
WilliamWsyHK commented 2024-11-07 00:26:21 +00:00 (Migrated from github.com)
Copy Link

We should only merge this once .NET 9 has been released globally out of RC, and the version of the global.json is update again to match latest release version.

Meanwhile, we need more people to test and see what has happened, e.g. performance regression/broken game functionality.

We should only merge this once .NET 9 has been released globally out of RC, and the version of the `global.json` is update again to match latest release version. Meanwhile, we need more people to test and see what has happened, e.g. performance regression/broken game functionality.
👍 2
GreemDev commented 2024-11-07 00:27:20 +00:00 (Migrated from github.com)
Copy Link

We should only merge this once .NET 9 has been released globally out of RC, and the version of the global.json is update again to match latest release version.

Pretty sure that's why this was opened as a draft.

> We should only merge this once .NET 9 has been released globally out of RC, and the version of the global.json is update again to match latest release version. Pretty sure that's why this was opened as a draft.
bangfire commented 2024-11-13 12:54:31 +00:00 (Migrated from github.com)
Copy Link

There's some low hanging fruit you could probably add to this PR such as the new Lock object: https://learn.microsoft.com/en-us/dotnet/api/system.threading.lock?view=net-9.0

A quick find replace on object _lock has a a lot of hits that are free to update.

There's some low hanging fruit you could probably add to this PR such as the new `Lock` object: https://learn.microsoft.com/en-us/dotnet/api/system.threading.lock?view=net-9.0 A quick find replace on `object _lock` has a a lot of hits that are free to update.
mattzink commented 2024-11-13 16:45:15 +00:00 (Migrated from github.com)
Copy Link

Those warnings about Lock being upcast to object will result in runtime failures. You need to update the method signatures to Lock as well when you pass instances around.

Those warnings about `Lock` being upcast to object will result in runtime failures. You need to update the method signatures to Lock as well when you pass instances around.
mattzink (Migrated from github.com) reviewed 2024-11-13 17:02:05 +00:00
src/Ryujinx.HLE/HOS/Kernel/Common/KResourceLimit.cs
mattzink (Migrated from github.com) commented 2024-11-13 17:02:05 +00:00
Copy Link

Curious why this lock type was reverted to object?

Curious why this lock type was reverted to `object`?
marco-carvalho (Migrated from github.com) reviewed 2024-11-13 20:29:34 +00:00
src/Ryujinx.HLE/HOS/Kernel/Common/KResourceLimit.cs
marco-carvalho (Migrated from github.com) commented 2024-11-13 20:29:34 +00:00
Copy Link

Monitor class dependency

`Monitor` class dependency
LukeWarnut commented 2024-12-02 16:29:09 +00:00 (Migrated from github.com)
Copy Link

LGTM. Seems to give a 1% FPS increase on my setup.

LGTM. Seems to give a 1% FPS increase on my setup.
mattzink commented 2024-12-03 02:27:43 +00:00 (Migrated from github.com)
Copy Link

I think all runtime synchronized packages (System.IO.Hashing and System.Managment) should be updated to 9.0.0 as well.

I think all runtime synchronized packages (`System.IO.Hashing` and `System.Managment`) should be updated to 9.0.0 as well.
WilliamWsyHK (Migrated from github.com) reviewed 2024-12-03 15:21:33 +00:00
src/Ryujinx.HLE/PerformanceStatistics.cs
WilliamWsyHK (Migrated from github.com) commented 2024-12-03 15:21:33 +00:00
Copy Link

Can we further simplify the code to [new()] for this and next line?

Can we further simplify the code to `[new()]` for this and next line?
marco-carvalho (Migrated from github.com) reviewed 2024-12-03 16:08:58 +00:00
src/Ryujinx.HLE/PerformanceStatistics.cs
marco-carvalho (Migrated from github.com) commented 2024-12-03 16:08:58 +00:00
Copy Link

done

done
LukeWarnut commented 2024-12-03 19:21:14 +00:00 (Migrated from github.com)
Copy Link

Improves performance in pretty much every game on my machine (i7-13620H, RTX 4070)

Super Mario Odyssey: +4.2 FPS
The Legend of Zelda: Echoes of Wisdom: +0.6 FPS
Mario Party Superstars +5.3 FPS
Balatro: +2.2 FPS
Minecraft: NSW Edition: +13.7 FPS

Improves performance in pretty much every game on my machine (i7-13620H, RTX 4070) Super Mario Odyssey: **+4.2** FPS The Legend of Zelda: Echoes of Wisdom: **+0.6** FPS Mario Party Superstars **+5.3** FPS Balatro: **+2.2** FPS Minecraft: NSW Edition: **+13.7** FPS
ViRb3 commented 2024-12-03 20:33:06 +00:00 (Migrated from github.com)
Copy Link

@marco-carvalho do you have any reference for "Linq.Any/Linq.FirstOrDefault are now faster than List.Exists/List.Find"? I tried to search but didn't find any existing article or benchmark.

On another note, just came across an article claiming ToArray is now always faster than ToList. Some instances can be changed in the code.

@marco-carvalho do you have any reference for "Linq.Any/Linq.FirstOrDefault are now faster than List.Exists/List.Find"? I tried to search but didn't find any existing article or benchmark. On another note, just came across an article claiming `ToArray` is now always faster than `ToList`. Some instances can be changed in the code. - https://code-corner.dev/2024/06/19/NET-9-ToList-vs-ToArray/
marco-carvalho commented 2024-12-03 21:16:09 +00:00 (Migrated from github.com)
Copy Link

@ViRb3
https://github.com/SonarSource/sonar-dotnet/issues/9664
https://github.com/SonarSource/sonar-dotnet/issues/9665

@ViRb3 https://github.com/SonarSource/sonar-dotnet/issues/9664 https://github.com/SonarSource/sonar-dotnet/issues/9665
👍 1
JWatersMeet commented 2024-12-14 12:27:54 +00:00 (Migrated from github.com)
Copy Link

FPS uplift from 86.5 to 93.4 on Densha de Go Stage Select screen with .NET 9 with frame rates unlocked on my system. I haven't found any issues in my library with this patch.

FPS uplift from 86.5 to 93.4 on Densha de Go Stage Select screen with .NET 9 with frame rates unlocked on my system. I haven't found any issues in my library with this patch.
legluondunet commented 2024-12-16 04:33:47 +00:00 (Migrated from github.com)
Copy Link

Will this changes break Linux compatibility?

Will this changes break Linux compatibility?
Daenorth commented 2024-12-16 06:27:00 +00:00 (Migrated from github.com)
Copy Link

Gives me around 10-15 more FPS in general Areas on Pokemon Violet - Don't see any regression or issues thus far.
Seems to stay more stable at higher FPS - drops down less in general. (Canary can drop down all the way to 80-85 in some areas. Net9 drops down to 98-105 at most)

Gives me around 10-15 more FPS in general Areas on Pokemon Violet - Don't see any regression or issues thus far. Seems to stay more stable at higher FPS - drops down less in general. (Canary can drop down all the way to 80-85 in some areas. Net9 drops down to 98-105 at most)
GreemDev commented 2024-12-16 10:39:00 +00:00 (Migrated from github.com)
Copy Link

Will this changes break Linux compatibility?

Uh, no? This PR even has linux builds available. What are you talking about?

> Will this changes break Linux compatibility? Uh, no? This PR even has linux builds available. What are you talking about?
👍 4 😕 1
mattzink (Migrated from github.com) reviewed 2024-12-17 06:16:43 +00:00
Directory.Build.props
@ -0,0 +1,6 @@
<Project>
<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<LangVersion>latest</LangVersion>
mattzink (Migrated from github.com) commented 2024-12-17 06:16:42 +00:00
Copy Link

Why are we setting LangVersion? That's only supposed to be used to force downlevel language versions.

Why are we setting LangVersion? That's only supposed to be used to force downlevel language versions.
marco-carvalho (Migrated from github.com) reviewed 2024-12-17 13:05:00 +00:00
Directory.Build.props
@ -0,0 +1,6 @@
<Project>
<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<LangVersion>latest</LangVersion>
marco-carvalho (Migrated from github.com) commented 2024-12-17 13:05:00 +00:00
Copy Link

I'm only centralizing <LangVersion>latest</LangVersion> in the Directory.Build.props, some projects of the solution target to netstandard2.0

I'm only centralizing `<LangVersion>latest</LangVersion>` in the `Directory.Build.props`, some projects of the solution target to `netstandard2.0`
GreemDev commented 2024-12-19 07:32:58 +00:00 (Migrated from github.com)
Copy Link

What's the status on this? Is it ready for merge or are you still looking for ways to apply the new features?

What's the status on this? Is it ready for merge or are you still looking for ways to apply the new features?
marco-carvalho commented 2024-12-19 11:03:22 +00:00 (Migrated from github.com)
Copy Link

It is ready for merge since I removed the “draft” status.

It is ready for merge since I removed the “draft” status.
GreemDev (Migrated from github.com) approved these changes 2024-12-20 00:41:49 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
GreemDev
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
audio
cpu
gpu
graphics-backend:opengl
graphics-backend:vulkan
gui
horizon
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#198
No description provided.
Delete Branch "net90"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?