MeloNX/Ryujinx-ryubing
11
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

[Bug] Build Fail due to Invalid Version String #204

New Issue
Closed
opened 2024-11-08 03:49:38 +00:00 by ObscenityIB · 2 comments
ObscenityIB commented 2024-11-08 03:49:38 +00:00 (Migrated from github.com)
Copy Link

Description of the issue

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:01.63
Clearing NuGet HTTP cache: /home/obscenity/.local/share/NuGet/http-cache
Clearing NuGet global packages folder: /home/obscenity/.nuget/packages/
Clearing NuGet Temp cache: /tmp/NuGetScratchobscenity
Clearing NuGet plugins cache: /home/obscenity/.local/share/NuGet/plugin-cache
Local resources cleared.
  Determining projects to restore...
/home/obscenity/.cache/yay/ryujinx-git/src/dotnet/sdk/8.0.302/NuGet.targets(169,5): error : 'Canary-1.2.15' is not a valid version string. (Parameter 'value') [/home/obscenity/.cache/yay/ryujinx-git/src/Ryujinx/src/Ryujinx/Ryujinx.csproj]

Reproduction steps

Update AUR package ryujinx-git which now points to this repo.

Dotnet build mostly succeeds, however fails on an invalid version tag.

Log file

N/A

OS

Linux

Ryujinx version

Canary-1.2.15

Game version

No response

CPU

No response

GPU

No response

RAM

No response

List of applied mods

No response

Additional context?

No response

### Description of the issue ``` Build succeeded. 0 Warning(s) 0 Error(s) Time Elapsed 00:00:01.63 Clearing NuGet HTTP cache: /home/obscenity/.local/share/NuGet/http-cache Clearing NuGet global packages folder: /home/obscenity/.nuget/packages/ Clearing NuGet Temp cache: /tmp/NuGetScratchobscenity Clearing NuGet plugins cache: /home/obscenity/.local/share/NuGet/plugin-cache Local resources cleared. Determining projects to restore... /home/obscenity/.cache/yay/ryujinx-git/src/dotnet/sdk/8.0.302/NuGet.targets(169,5): error : 'Canary-1.2.15' is not a valid version string. (Parameter 'value') [/home/obscenity/.cache/yay/ryujinx-git/src/Ryujinx/src/Ryujinx/Ryujinx.csproj] ``` ### Reproduction steps Update AUR package `ryujinx-git` which now points to this repo. Dotnet build *mostly* succeeds, however fails on an invalid version tag. ### Log file N/A ### OS Linux ### Ryujinx version Canary-1.2.15 ### Game version _No response_ ### CPU _No response_ ### GPU _No response_ ### RAM _No response_ ### List of applied mods _No response_ ### Additional context? _No response_
GreemDev commented 2024-11-08 03:52:18 +00:00 (Migrated from github.com)
Copy Link

This is something the AUR is doing. The Canary version string is not passed to .NET. It compiles fine on my system, and in CI, which is linux.

Edit: Maybe it's going based off of tag version. That's the only one with a hyphen. In which case the AUR needs to do ryujinx-git and ryujinx-canary-git channels.

This is something the AUR is doing. The Canary version string is not passed to .NET. It compiles fine on my system, and in CI, which is linux. Edit: Maybe it's going based off of tag version. That's the only one with a hyphen. In which case the AUR needs to do ryujinx-git and ryujinx-canary-git channels.
ObscenityIB commented 2024-11-08 04:02:36 +00:00 (Migrated from github.com)
Copy Link

Yup, looks like it.

 _args="-c Release -r linux-x64 -p:Version=$(git describe --tags) -p:DebugType=embedded -p:ExtraDefineConstants=DISABLE_UPDATER%2CFORCE_EXTERNAL_BASE_DIR"

Maybe it expects tags to be semver compliant, which is rather hopeful.

Yup, looks like it. ``` _args="-c Release -r linux-x64 -p:Version=$(git describe --tags) -p:DebugType=embedded -p:ExtraDefineConstants=DISABLE_UPDATER%2CFORCE_EXTERNAL_BASE_DIR" ``` Maybe it expects tags to be semver compliant, which is rather hopeful.
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0-Blu Fen Lonkelle Propenchieferr Stern bella jkcoxson june ny spidy123222 stossy11
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#204
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?