MeloNX/Ryujinx-ryubing
11
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

[Bug] App is not signed successfully when building and packaging on MAC OS using ‘create_macos_build_ava.sh’ script #210

New Issue
Open
opened 2024-11-09 14:41:23 +00:00 by amurgshere · 0 comments
amurgshere commented 2024-11-09 14:41:23 +00:00 (Migrated from github.com)
Copy Link

Description of the issue

Since PR https://github.com/GreemDev/Ryujinx/pull/188 has been checked in I can no longer create and sign the app bundle locally on MacOS 14.6.1

I am using the following to build, create, and sign the app bundle:

./distribution/macos/create_macos_build_ava.sh ./ ./distribution/macos/temp ./distribution/macos/output ./distribution/macos/entitlements.xml 1.0.0 0 Release

See log file for details of output from terminal.

if I reinstate the "--deep" parameter it starts working again, I assume this is because the "/libglfw.3.dylib" file and other library files need to be re-signed and it is no longer being signed because of the missing "--deep" parameter, do I need to do something differently now to get the app bundle to be signed successfully?

Note that if I add an extra line before this line in the "create_app_bundle.sh" script:

codesign --entitlements "$ENTITLEMENTS_FILE_PATH" -f -s - "$APP_BUNDLE_DIRECTORY"

Of:

find "$APP_BUNDLE_DIRECTORY" -name "*.dylib" -exec codesign -f -s - {} ;

Forcing these libraries to be code re-signed, the issue also goes away. I have created Pull Request https://github.com/GreemDev/Ryujinx/pull/208 to fix this.

Thank You.

Reproduction steps

  1. Clone the repository to an M1 MAC
  2. Run this command from the cloned directory:
    ./distribution/macos/create_macos_build_ava.sh ./ ./distribution/macos/temp ./distribution/macos/output ./distribution/macos/entitlements.xml 1.0.0 0 Release

x64 version is not signed properly and Universal bundle is not created at all as the x64 signing failed which stops the script.

Log file

These are the last few lines of the terminal which indicate that the issue is a signing issue, the signing stops here and the scripts does not attempt to package the universal app at all:

/Volumes/MACBOOK/ROMS/NSW/Ryujinx/GitHub/Ryujinx/distribution/macos/temp/output_x64/Ryujinx.app: code object is not signed at all
In subcomponent: /Volumes/MACBOOK/ROMS/NSW/Ryujinx/GitHub/Ryujinx/distribution/macos/temp/output_x64/Ryujinx.app/Contents/Frameworks/libglfw.3.dylib

OS

MAC OS 14.6.1

Ryujinx version

Building Master as @ 9th November 2024

Game version

No response

CPU

Apple M1

GPU

Apple M1 8 Core

RAM

16GB

List of applied mods

No response

Additional context?

No response

### Description of the issue Since PR https://github.com/GreemDev/Ryujinx/pull/188 has been checked in I can no longer create and sign the app bundle locally on MacOS 14.6.1 I am using the following to build, create, and sign the app bundle: ./distribution/macos/create_macos_build_ava.sh ./ ./distribution/macos/temp ./distribution/macos/output ./distribution/macos/entitlements.xml 1.0.0 0 Release See log file for details of output from terminal. if I reinstate the "--deep" parameter it starts working again, I assume this is because the "/libglfw.3.dylib" file and other library files need to be re-signed and it is no longer being signed because of the missing "--deep" parameter, do I need to do something differently now to get the app bundle to be signed successfully? Note that if I add an extra line before this line in the "create_app_bundle.sh" script: codesign --entitlements "$ENTITLEMENTS_FILE_PATH" -f -s - "$APP_BUNDLE_DIRECTORY" Of: find "$APP_BUNDLE_DIRECTORY" -name "*.dylib" -exec codesign -f -s - {} ; Forcing these libraries to be code re-signed, the issue also goes away. I have created Pull Request https://github.com/GreemDev/Ryujinx/pull/208 to fix this. Thank You. ### Reproduction steps 1) Clone the repository to an M1 MAC 2) Run this command from the cloned directory: ./distribution/macos/create_macos_build_ava.sh ./ ./distribution/macos/temp ./distribution/macos/output ./distribution/macos/entitlements.xml 1.0.0 0 Release x64 version is not signed properly and Universal bundle is not created at all as the x64 signing failed which stops the script. ### Log file These are the last few lines of the terminal which indicate that the issue is a signing issue, the signing stops here and the scripts does not attempt to package the universal app at all: /Volumes/MACBOOK/ROMS/NSW/Ryujinx/GitHub/Ryujinx/distribution/macos/temp/output_x64/Ryujinx.app: code object is not signed at all In subcomponent: /Volumes/MACBOOK/ROMS/NSW/Ryujinx/GitHub/Ryujinx/distribution/macos/temp/output_x64/Ryujinx.app/Contents/Frameworks/libglfw.3.dylib ### OS MAC OS 14.6.1 ### Ryujinx version Building Master as @ 9th November 2024 ### Game version _No response_ ### CPU Apple M1 ### GPU Apple M1 8 Core ### RAM 16GB ### List of applied mods _No response_ ### Additional context? _No response_
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0-Blu Fen Lonkelle Propenchieferr Stern bella jkcoxson june ny spidy123222 stossy11
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#210
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?