Replace 'Expand DRAM' option with dropdown menu #22

Closed

KeatonTheBot wants to merge 0 commits from dram-dropdown into master

pull from: dram-dropdown

merge into: MeloNX:master

Conversation 1 Commits - Files Changed -

KeatonTheBot commented 2024-10-20 18:56:00 +00:00 (Migrated from github.com)

Copy Link

This dropdown menu replaces the 'Expand DRAM to 8GiB' option under Settings/System/Hacks. Configurable to use 4GiB (default), 6GiB, 8GiB, and 12GiB. The latter is needed for some really heavy duty 8K+ native resolution mods, and 6GiB/8GiB should be fine for most 4K+ mods (mirroring the OG Switch and Switch OLED dev kits, respectively).

This dropdown menu replaces the 'Expand DRAM to 8GiB' option under Settings/System/Hacks. Configurable to use 4GiB (default), 6GiB, 8GiB, and 12GiB. The latter is needed for some really heavy duty 8K+ native resolution mods, and 6GiB/8GiB should be fine for most 4K+ mods (mirroring the OG Switch and Switch OLED dev kits, respectively). 

GreemDev (Migrated from github.com) requested changes 2024-10-21 13:03:48 +00:00

GreemDev (Migrated from github.com) left a comment

Copy Link

Ready to merge apart from the comments I've left.

Ready to merge apart from the comments I've left.

src/Ryujinx.UI.Common/Configuration/ConfigurationFileFormat.cs

GreemDev (Migrated from github.com) commented 2024-10-21 13:00:40 +00:00

Copy Link

The version at the top of this class needs to be updated to reflect changes in the structure of the config; and migration code needs to be added similar to how it's done here

The version at the top of this class needs to be updated to reflect changes in the structure of the config; and migration code needs to be added similar to how it's done [here](https://github.com/GreemDev/Ryujinx/blob/8b75ce1d981c68a81101c6234e50a74d13ed8f15/src/Ryujinx.UI.Common/Configuration/ConfigurationState.cs#L1507-L1514)

src/Ryujinx.UI.Common/Helper/SetupValidator.cs

GreemDev (Migrated from github.com) commented 2024-10-21 13:02:06 +00:00

Copy Link

The note on the above if is the reason for this line being there

The note on the above if is the reason for this line being there

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No Reviewers

GreemDev

Labels

Clear labels

audio

Affects Audio playback during emulation

blocked on external progress

This cannot move forward without work on an external project or service.

bug

Something isn't working

cpu

An issue with ARMeilleure, the JIT, or Hypervisor

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good first issues to work on for new contributors

gpu

Affects GPU emulation

graphics-backend:metal

Affects the Metal Graphics backend

graphics-backend:opengl

Affects the OpenGL Graphics backend

graphics-backend:vulkan

Affects the Vulkan Graphics backend

gui

Affects the Avalonia UI or translations.

help wanted

Extra attention is needed

horizon

Affects the Horizon OS HLE components.

infra

Updates to dependencies

invalid

This doesn't seem right

kernel

Affects the kernel HLE components.

ldn

Affects the LDN functionality

linux

Linux only issue

macOS

macOS only issue

not planned but open to a PR

I do not intend on working on this myself, but I would not be opposed to an implementation.

question

Further information is requested

windows

Windows only issue

wontfix

This will not be worked on

No Label

gui

horizon

kernel

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#22

No description provided.