MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Fix divide by zero when recovering from missed draw (Vulkan), authored by EmulationEnjoyer #235

Merged
extherian merged 1 commits from master into master 2024-11-14 02:36:59 +00:00
Conversation 2 Commits 1 Files Changed 1 +4 -2
extherian commented 2024-11-13 15:19:48 +00:00 (Migrated from github.com)
Copy Link

Adds the fix for the crash in the opening cutscene of Baldo: The Sacred Owls when using Vulkan, from ryujinx-mirror. The original discussion about the fix can be found here.

It's up to you if you want to merge this, it's one of the very few improvements that ryujinx-mirror got that hasn't made it into your fork yet. My opinion is that without a graphics expert on board, we can't know the real cause of this divide-by-zero issue and will have to make do with this patch to fix it. And I think we will have to do this many times in the future for other games that suffer crashes at the moment as well, at least going by current discussions in the #development section of the discord.

I did not come up with this fix, all credit goes to EmulationEnjoyer for putting Ryujinx through a debugger and discovering the cause of the crash.

Adds the fix for the crash in the opening cutscene of Baldo: The Sacred Owls when using Vulkan, from ryujinx-mirror. The original discussion about the fix can be found [here.](https://github.com/ryujinx-mirror/ryujinx/pull/52) It's up to you if you want to merge this, it's one of the very few improvements that ryujinx-mirror got that hasn't made it into your fork yet. My opinion is that without a graphics expert on board, we can't know the real cause of this divide-by-zero issue and will have to make do with this patch to fix it. And I think we will have to do this many times in the future for other games that suffer crashes at the moment as well, at least going by current discussions in the #development section of the discord. I did not come up with this fix, all credit goes to [EmulationEnjoyer](https://github.com/EmulationEnjoyer) for putting Ryujinx through a debugger and discovering the cause of the crash.
GreemDev commented 2024-11-14 01:48:05 +00:00 (Migrated from github.com)
Copy Link

I was just thinking of this change earlier, to pull it in

I was just thinking of this change earlier, to pull it in
github-actions[bot] commented 2024-11-14 01:56:17 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less (SDL2)
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+d23df30-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185365150.zip) * [ryujinx-Release-1.2.0+d23df30-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185365209.zip) * [ryujinx-Release-1.2.0+d23df30-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185367859.zip) * [ryujinx-Release-1.2.0+d23df30-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185367918.zip) * [ryujinx-Release-1.2.0+d23df30-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185371705.zip) * [ryujinx-Release-1.2.0+d23df30-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185377241.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+d23df30-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185365298.zip) * [sdl2-ryujinx-headless-Release-1.2.0+d23df30-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185368002.zip) * [sdl2-ryujinx-headless-Release-1.2.0+d23df30-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185371796.zip) * [sdl2-ryujinx-headless-Release-1.2.0+d23df30-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185377344.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+d23df30-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185364418.zip) * [ryujinx-Debug-1.2.0+d23df30-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185364488.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+d23df30-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185364567.zip) * [ryujinx-Debug-1.2.0+d23df30-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185369885.zip) * [ryujinx-Debug-1.2.0+d23df30-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185369941.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+d23df30-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185370038.zip) * [ryujinx-Debug-1.2.0+d23df30-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185371317.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+d23df30-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185371385.zip) * [ryujinx-Debug-1.2.0+d23df30-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185377319.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+d23df30-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2185377453.zip) </details>
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gpu
graphics-backend:vulkan
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#235
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?