MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Adding and enabling new languages from Crowdin #245

Closed
yeager wants to merge 0 commits from master into master
pull from: master
merge into: MeloNX:master
Conversation 19 Commits - Files Changed -
yeager commented 2024-11-14 18:28:20 +00:00 (Migrated from github.com)
Copy Link
No description provided.
github-actions[bot] commented 2024-11-14 18:45:28 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+1f3859e-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271538757.zip) * [ryujinx-Release-1.2.0+1f3859e-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271538807.zip) * [ryujinx-Release-1.2.0+1f3859e-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271542042.zip) * [ryujinx-Release-1.2.0+1f3859e-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271542095.zip) * [ryujinx-Release-1.2.0+1f3859e-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271545879.zip) * [ryujinx-Release-1.2.0+1f3859e-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271551200.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+1f3859e-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271538859.zip) * [nogui-ryujinx-Release-1.2.0+1f3859e-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271542152.zip) * [nogui-ryujinx-Release-1.2.0+1f3859e-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271545963.zip) * [nogui-ryujinx-Release-1.2.0+1f3859e-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271551291.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+1f3859e-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271539275.zip) * [ryujinx-Debug-1.2.0+1f3859e-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271539337.zip) * [nogui-ryujinx-Debug-1.2.0+1f3859e-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271539405.zip) * [ryujinx-Debug-1.2.0+1f3859e-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271543858.zip) * [ryujinx-Debug-1.2.0+1f3859e-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271543918.zip) * [nogui-ryujinx-Debug-1.2.0+1f3859e-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271543996.zip) * [ryujinx-Debug-1.2.0+1f3859e-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271545556.zip) * [nogui-ryujinx-Debug-1.2.0+1f3859e-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271545635.zip) * [ryujinx-Debug-1.2.0+1f3859e-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271552674.zip) * [nogui-ryujinx-Debug-1.2.0+1f3859e-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2271552775.zip) </details>
nicola02nb commented 2024-11-15 11:41:59 +00:00 (Migrated from github.com)
Copy Link

You probably should change all urls like https://ryujinx.org/ to https://ryujinx.app/download

You probably should change all urls like `https://ryujinx.org/` to `https://ryujinx.app/download`
yeager commented 2024-11-15 12:41:09 +00:00 (Migrated from github.com)
Copy Link

Isn't there a way to automatically update all translations with new strings?

Isn't there a way to automatically update all translations with new strings?
nicola02nb commented 2024-11-15 12:46:21 +00:00 (Migrated from github.com)
Copy Link

I don't think so, as far as I know....
If your question is related of what I said previously, you have only 5 urls to edit... so just change them manually and comit.

I don't think so, as far as I know.... If your question is related of what I said previously, you have only 5 urls to edit... so just change them manually and comit.
👍 1
nicola02nb commented 2024-11-19 09:51:09 +00:00 (Migrated from github.com)
Copy Link

@yeager you probably should make the four edits I suggested up here

@yeager you probably should make the four edits I suggested up here
yeager commented 2024-11-23 18:26:00 +00:00 (Migrated from github.com)
Copy Link

I believe I have added Swedish to all aspects of the UI. Code compiles OK and all works

I believe I have added Swedish to all aspects of the UI. Code compiles OK and all works
yeager commented 2024-11-26 06:25:13 +00:00 (Migrated from github.com)
Copy Link

@nicola02nb ping :)

@nicola02nb ping :)
nicola02nb commented 2024-11-26 08:18:53 +00:00 (Migrated from github.com)
Copy Link

Excuse me, why ping?

Excuse me, why ping?
yeager commented 2024-11-26 08:36:06 +00:00 (Migrated from github.com)
Copy Link

Oh, I thought you could approve this

Oh, I thought you could approve this
nicola02nb commented 2024-11-26 08:40:05 +00:00 (Migrated from github.com)
Copy Link

Nope, as far as I know only @GreemDev can...

Nope, as far as I know only @GreemDev can...
GreemDev (Migrated from github.com) reviewed 2024-12-05 07:04:38 +00:00
src/Ryujinx.HLE/HOS/SystemState/KeyboardLayout.cs
GreemDev (Migrated from github.com) commented 2024-12-05 07:02:22 +00:00
Copy Link

Max should probably be updated to Finnish instead of ChineseTraditional to correspond with the actual max value of the enum

`Max` should probably be updated to `Finnish` instead of `ChineseTraditional` to correspond with the actual max value of the enum
src/Ryujinx/Assets/Locales/sv_SE.json
GreemDev (Migrated from github.com) commented 2024-12-05 07:04:17 +00:00
Copy Link

The layout of this entire file is inconsistent with the others

The layout of this entire file is inconsistent with the others
yeager (Migrated from github.com) reviewed 2024-12-05 07:38:09 +00:00
src/Ryujinx/Assets/Locales/sv_SE.json
yeager (Migrated from github.com) commented 2024-12-05 07:38:09 +00:00
Copy Link

It has been sorted alphabetically in order to be able to see all new strings from the en-US.json

It has been sorted alphabetically in order to be able to see all new strings from the en-US.json
yeager (Migrated from github.com) reviewed 2024-12-05 07:39:17 +00:00
src/Ryujinx.HLE/HOS/SystemState/KeyboardLayout.cs
yeager (Migrated from github.com) commented 2024-12-05 07:39:17 +00:00
Copy Link

Thanks. Done

Thanks. Done
yeager (Migrated from github.com) reviewed 2024-12-05 07:48:58 +00:00
yeager (Migrated from github.com) left a comment
Copy Link

Removing this old NO translation due to newer in https://github.com/GreemDev/Ryujinx/pull/338

Removing this old NO translation due to newer in https://github.com/GreemDev/Ryujinx/pull/338
yeager (Migrated from github.com) reviewed 2024-12-15 10:16:15 +00:00
src/Ryujinx/Assets/Locales/sv_SE.json
yeager (Migrated from github.com) commented 2024-12-15 10:16:15 +00:00
Copy Link

I have rearranged the sv_SE.json in the correct order now

I have rearranged the sv_SE.json in the correct order now
GreemDev (Migrated from github.com) requested changes 2024-12-23 21:40:54 +00:00
GreemDev (Migrated from github.com) left a comment
Copy Link

The locales system has undergone basically an entire refactoring, which makes this PR not able to be merged unless it is redone with the new changes.

I apologize for this inconvenience, I hope it is made up by the fact that the new system is cleaner, and should be easier to translate.

You can add new languages by opening up the locales.json file (where the Locales folder containing the various JSONs was previously) and adding the short language code (that previously was the file's name) to the Languages list at the top.
Once that's done you open up the project in an IDE (Visual Studio Community & Rider both work, VS Code might) and do a "rebuild" specifically. The locale file validator only runs on rebuild. That will go through each locale key and add an empty string for the languages that are missing, to simplify adding a new language.

The locales system has undergone basically an entire refactoring, which makes this PR not able to be merged unless it is redone with the new changes. I apologize for this inconvenience, I hope it is made up by the fact that the new system is cleaner, and should be easier to translate. You can add new languages by opening up the `locales.json` file (where the `Locales` folder containing the various JSONs was previously) and adding the short language code (that previously was the file's name) to the `Languages` list at the top. Once that's done you open up the project in an IDE (Visual Studio Community & Rider both work, VS Code might) and do a "rebuild" specifically. The locale file validator only runs on rebuild. That will go through each locale key and add an empty string for the languages that are missing, to simplify adding a new language.
Daenorth commented 2024-12-24 19:32:38 +00:00 (Migrated from github.com)
Copy Link

If you want any assistance just @me Yeager. i would be happy to help to reduce the workload abit for you.

If you want any assistance just @me Yeager. i would be happy to help to reduce the workload abit for you.
yeager commented 2024-12-24 19:59:29 +00:00 (Migrated from github.com)
Copy Link

Nah, I'm good. Will take a look at this right now

Nah, I'm good. Will take a look at this right now
👍 1
yeager commented 2024-12-25 09:42:47 +00:00 (Migrated from github.com)
Copy Link

All done now.

Compiles good and works good. Awesome, guys!

41>------ Rebuild All started: Project: Ryujinx.Headless.SDL2, Configuration: Debug x64 ------
38>Ryujinx.Tests -> C:\Users\windo\Downloads\dump\Ryujinx\src\Ryujinx.Tests\bin\x64\Debug\net9.0\Ryujinx.Tests.dll
41>Ryujinx.Headless.SDL2 -> C:\Users\windo\Downloads\dump\Ryujinx\src\Ryujinx.Headless.SDL2\bin\x64\Debug\net9.0\Ryujinx.Headless.SDL2.dll
40>Ryujinx -> C:\Users\windo\Downloads\dump\Ryujinx\src\Ryujinx\bin\x64\Debug\net9.0\Ryujinx.dll
========== Rebuild All: 41 succeeded, 0 failed, 0 skipped ==========
========== Rebuild completed at 10:39 and took 09,893 seconds ==========

All done now. Compiles good and works good. Awesome, guys! 41>------ Rebuild All started: Project: Ryujinx.Headless.SDL2, Configuration: Debug x64 ------ 38>Ryujinx.Tests -> C:\Users\windo\Downloads\dump\Ryujinx\src\Ryujinx.Tests\bin\x64\Debug\net9.0\Ryujinx.Tests.dll 41>Ryujinx.Headless.SDL2 -> C:\Users\windo\Downloads\dump\Ryujinx\src\Ryujinx.Headless.SDL2\bin\x64\Debug\net9.0\Ryujinx.Headless.SDL2.dll 40>Ryujinx -> C:\Users\windo\Downloads\dump\Ryujinx\src\Ryujinx\bin\x64\Debug\net9.0\Ryujinx.dll ========== Rebuild All: 41 succeeded, 0 failed, 0 skipped ========== ========== Rebuild completed at 10:39 and took 09,893 seconds ==========

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
GreemDev
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#245
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?