MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Fix window sizing when "Show Title Bar" is enabled #247

Merged
EmulationEnjoyer merged 5 commits from window_sizing_fix into master 2024-11-15 07:26:35 +00:00
Conversation 3 Commits 5 Files Changed 2 +22 -10
EmulationEnjoyer commented 2024-11-15 01:19:52 +00:00 (Migrated from github.com)
Copy Link

Fixes a bug that causes the main window to not size properly when the TitleBar is enabled (i.e.: when the TitleBar and MenuStrip are separate entities). Corrects the size for main window startup and when a user clicks a "View > Window Size > Resolution Here" MenuStripItem

Prior to this fix if a user selects 720p/1080p and "Show Title Bar" is enabled, the window would be sized smaller than intended and display black bars on the sides of the render area

window_sizing_fix

Fixes a window height calculation issue

Fixes a bug that causes the main window to not size properly when the TitleBar is enabled (i.e.: when the TitleBar and MenuStrip are separate entities). Corrects the size for main window startup and when a user clicks a "View > Window Size > *Resolution Here*" MenuStripItem Prior to this fix if a user selects 720p/1080p and "Show Title Bar" is enabled, the window would be sized smaller than intended and display black bars on the sides of the render area ![window_sizing_fix](https://github.com/user-attachments/assets/9835c9ed-c5ee-4daf-8364-f2b4576f533e) Fixes a window height calculation issue
GreemDev (Migrated from github.com) requested changes 2024-11-15 01:22:17 +00:00
src/Ryujinx/UI/Views/Main/MainMenuBarView.axaml.cs
GreemDev (Migrated from github.com) commented 2024-11-15 01:20:59 +00:00
Copy Link

make this resolutionWidth & resolutionHeight, respectively

make this `resolutionWidth` & `resolutionHeight`, respectively
GreemDev (Migrated from github.com) commented 2024-11-15 01:21:41 +00:00
Copy Link

make this windowWidthScaled and windowHeightScaled, respectively

make this `windowWidthScaled` and `windowHeightScaled`, respectively
github-actions[bot] commented 2024-11-15 06:30:41 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less (SDL2)
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+1f5271b-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191634513.zip) * [ryujinx-Release-1.2.0+1f5271b-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191634650.zip) * [ryujinx-Release-1.2.0+1f5271b-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191637951.zip) * [ryujinx-Release-1.2.0+1f5271b-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191638006.zip) * [ryujinx-Release-1.2.0+1f5271b-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191642441.zip) * [ryujinx-Release-1.2.0+1f5271b-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191644865.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+1f5271b-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191634763.zip) * [sdl2-ryujinx-headless-Release-1.2.0+1f5271b-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191638110.zip) * [sdl2-ryujinx-headless-Release-1.2.0+1f5271b-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191642740.zip) * [sdl2-ryujinx-headless-Release-1.2.0+1f5271b-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191644978.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+1f5271b-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191635146.zip) * [ryujinx-Debug-1.2.0+1f5271b-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191635254.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+1f5271b-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191635378.zip) * [ryujinx-Debug-1.2.0+1f5271b-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191640394.zip) * [ryujinx-Debug-1.2.0+1f5271b-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191640455.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+1f5271b-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191640744.zip) * [ryujinx-Debug-1.2.0+1f5271b-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191641893.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+1f5271b-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191641987.zip) * [ryujinx-Debug-1.2.0+1f5271b-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191647649.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+1f5271b-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2191647747.zip) </details>
GreemDev (Migrated from github.com) approved these changes 2024-11-15 07:25:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
GreemDev
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#247
No description provided.
Delete Branch "window_sizing_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?