MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Fix logic surrounding PushDescriptors in Vulkan #257

Merged
gr3ger merged 3 commits from vk_fixes into master 2024-11-28 23:00:12 +00:00
Conversation 1 Commits 3 Files Changed 1 +10
gr3ger commented 2024-11-16 22:27:48 +00:00 (Migrated from github.com)
Copy Link

Prevent the use of PushDescriptors when it will violate Vulkan MaxPushDescriptors limitation.
This should resolve some VUID-VkDescriptorSetLayoutCreateInfo-flags-00281 errors I encountered.

Prevent the use of PushDescriptors when it will violate Vulkan MaxPushDescriptors limitation. This should resolve some [VUID-VkDescriptorSetLayoutCreateInfo-flags-00281](https://vulkan.lunarg.com/doc/view/1.3.296.0/windows/1.3-extensions/vkspec.html#VUID-VkDescriptorSetLayoutCreateInfo-flags-00281) errors I encountered.
github-actions[bot] commented 2024-11-16 22:36:23 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less (SDL2)
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+56c1935-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197204042.zip) * [ryujinx-Release-1.2.0+56c1935-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197204068.zip) * [ryujinx-Release-1.2.0+56c1935-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197205510.zip) * [ryujinx-Release-1.2.0+56c1935-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197205529.zip) * [ryujinx-Release-1.2.0+56c1935-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197207731.zip) * [ryujinx-Release-1.2.0+56c1935-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197209429.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+56c1935-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197204103.zip) * [sdl2-ryujinx-headless-Release-1.2.0+56c1935-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197205578.zip) * [sdl2-ryujinx-headless-Release-1.2.0+56c1935-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197207807.zip) * [sdl2-ryujinx-headless-Release-1.2.0+56c1935-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197209486.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+56c1935-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197204099.zip) * [ryujinx-Debug-1.2.0+56c1935-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197204129.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+56c1935-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197204163.zip) * [ryujinx-Debug-1.2.0+56c1935-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197206558.zip) * [ryujinx-Debug-1.2.0+56c1935-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197206587.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+56c1935-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197206625.zip) * [ryujinx-Debug-1.2.0+56c1935-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197207570.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+56c1935-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197207654.zip) * [ryujinx-Debug-1.2.0+56c1935-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197210095.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+56c1935-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2197210151.zip) </details>
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gpu
graphics-backend:vulkan
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#257
No description provided.
Delete Branch "vk_fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?