MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Add more mentions of canary #258

Merged
GabCoolDude merged 34 commits from canarymention into master 2024-11-21 18:34:53 +00:00
Conversation 6 Commits 34 Files Changed 6 +25 -22
GabCoolDude commented 2024-11-17 00:07:23 +00:00 (Migrated from github.com)
Copy Link

This should hopefully make it clearer whether or not you're using canary.

Changelog:

  • Changed github workflows to have "canary" in the zip files
  • Added App.FullAppName in the about section, so that it's clear in there too
  • Changed log name for canary builds to Ryujinx_Canary_{version}_{DateTime.Now:yyyy-MM-dd_HH-mm-ss}.log (normal builds should still be "Ryujinx_{version}_{DateTime.Now:yyyy-MM-dd_HH-mm-ss}.log)
This should hopefully make it clearer whether or not you're using canary. Changelog: - Changed github workflows to have "canary" in the zip files - Added `App.FullAppName` in the about section, so that it's clear in there too - Changed log name for canary builds to `Ryujinx_Canary_{version}_{DateTime.Now:yyyy-MM-dd_HH-mm-ss}.log` (normal builds should still be "Ryujinx_{version}_{DateTime.Now:yyyy-MM-dd_HH-mm-ss}.log)
github-actions[bot] commented 2024-11-17 00:15:57 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+69e93a7-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219947012.zip) * [ryujinx-Release-1.2.0+69e93a7-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219947153.zip) * [ryujinx-Release-1.2.0+69e93a7-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219956722.zip) * [ryujinx-Release-1.2.0+69e93a7-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219956970.zip) * [ryujinx-Release-1.2.0+69e93a7-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219965239.zip) * [ryujinx-Release-1.2.0+69e93a7-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219974800.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+69e93a7-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219947353.zip) * [nogui-ryujinx-Release-1.2.0+69e93a7-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219957296.zip) * [nogui-ryujinx-Release-1.2.0+69e93a7-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219965435.zip) * [nogui-ryujinx-Release-1.2.0+69e93a7-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219975167.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+69e93a7-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219948092.zip) * [ryujinx-Debug-1.2.0+69e93a7-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219948239.zip) * [nogui-ryujinx-Debug-1.2.0+69e93a7-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219948397.zip) * [ryujinx-Debug-1.2.0+69e93a7-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219961265.zip) * [ryujinx-Debug-1.2.0+69e93a7-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219961511.zip) * [nogui-ryujinx-Debug-1.2.0+69e93a7-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219961799.zip) * [ryujinx-Debug-1.2.0+69e93a7-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219966610.zip) * [nogui-ryujinx-Debug-1.2.0+69e93a7-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219966786.zip) * [ryujinx-Debug-1.2.0+69e93a7-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219979368.zip) * [nogui-ryujinx-Debug-1.2.0+69e93a7-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2219979591.zip) </details>
GabCoolDude commented 2024-11-17 00:23:47 +00:00 (Migrated from github.com)
Copy Link

Changed this PR to draft until i figure out how to fix the macos canary workflows

Changed this PR to draft until i figure out how to fix the macos canary workflows
GabCoolDude commented 2024-11-20 19:39:55 +00:00 (Migrated from github.com)
Copy Link

Changed to draft until i figure out a way to change the macos release artifacts's names without adding 2 whole new files

Changed to draft until i figure out a way to change the macos release artifacts's names without adding 2 whole new files
GabCoolDude commented 2024-11-21 16:18:44 +00:00 (Migrated from github.com)
Copy Link

Removed about 300 lines of code compared to previous versions of the PR. This was done by checking if the build is canary in create_macos_build.sh and in create_macos_build_headless.sh instead of in additional canary bash files.

Removed about 300 lines of code compared to previous versions of the PR. This was done by checking if the build is canary in `create_macos_build.sh` and in `create_macos_build_headless.sh` instead of in additional canary bash files.
GreemDev (Migrated from github.com) reviewed 2024-11-21 16:20:59 +00:00
src/Ryujinx.Common/Logging/Targets/FileLogTarget.cs
GreemDev (Migrated from github.com) commented 2024-11-21 16:20:49 +00:00
Copy Link

Remove this accidental using

Remove this accidental using
GreemDev (Migrated from github.com) approved these changes 2024-11-21 16:43:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
GreemDev
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
infra
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#258
No description provided.
Delete Branch "canarymention"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?