MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Resolve Image Usage Validation Error #296

Merged
sunshineinabox merged 2 commits from ValidationErrors into master 2024-12-20 22:31:05 +00:00
Conversation 3 Commits 2 Files Changed 4 +29 -14
sunshineinabox commented 2024-11-22 02:48:00 +00:00 (Migrated from github.com)
Copy Link

This was a missed change that would resolve Image Usage validation error that is created fairly frequently.

VUID-VkImageViewCreateInfo-pNext-02662(ERROR / SPEC): msgNum: -55646969 - Validation Error: [ VUID-VkImageViewCreateInfo-pNext-02662 ] Object 0: handle = 0x260b9d1f6b8, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0xfcaee507 | vkCreateImageView(): pCreateInfo->pNext<VkImageViewUsageCreateInfo>.usage (VK_IMAGE_USAGE_SAMPLED_BIT|VK_IMAGE_USAGE_STORAGE_BIT) must not include any bits that were not set in VkImageCreateInfo::usage (VK_IMAGE_USAGE_TRANSFER_SRC_BIT|VK_IMAGE_USAGE_TRANSFER_DST_BIT|VK_IMAGE_USAGE_SAMPLED_BIT|VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) of the image. The Vulkan spec states: If the pNext chain includes a VkImageViewUsageCreateInfo structure, and image was not created with a VkImageStencilUsageCreateInfo structure included in the pNext chain of VkImageCreateInfo, its usage member must not include any bits that were not set in the usage member of the VkImageCreateInfo structure used to create image (https://vulkan.lunarg.com/doc/view/1.3.290.0/windows/1.3-extensions/vkspec.html#VUID-VkImageViewCreateInfo-pNext-02662) Objects: 1 [0] 0x260b9d1f6b8, type: 10, name: NULL

This was a missed change that would resolve Image Usage validation error that is created fairly frequently. ``VUID-VkImageViewCreateInfo-pNext-02662(ERROR / SPEC): msgNum: -55646969 - Validation Error: [ VUID-VkImageViewCreateInfo-pNext-02662 ] Object 0: handle = 0x260b9d1f6b8, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0xfcaee507 | vkCreateImageView(): pCreateInfo->pNext<VkImageViewUsageCreateInfo>.usage (VK_IMAGE_USAGE_SAMPLED_BIT|VK_IMAGE_USAGE_STORAGE_BIT) must not include any bits that were not set in VkImageCreateInfo::usage (VK_IMAGE_USAGE_TRANSFER_SRC_BIT|VK_IMAGE_USAGE_TRANSFER_DST_BIT|VK_IMAGE_USAGE_SAMPLED_BIT|VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) of the image. The Vulkan spec states: If the pNext chain includes a VkImageViewUsageCreateInfo structure, and image was not created with a VkImageStencilUsageCreateInfo structure included in the pNext chain of VkImageCreateInfo, its usage member must not include any bits that were not set in the usage member of the VkImageCreateInfo structure used to create image (https://vulkan.lunarg.com/doc/view/1.3.290.0/windows/1.3-extensions/vkspec.html#VUID-VkImageViewCreateInfo-pNext-02662) Objects: 1 [0] 0x260b9d1f6b8, type: 10, name: NULL ``
GreemDev commented 2024-11-22 02:58:03 +00:00 (Migrated from github.com)
Copy Link

Seems like compilation is breaking because references to ConvertToVkFormat weren't updated to add the new arg. Maybe give it a default?

Seems like compilation is breaking because references to ConvertToVkFormat weren't updated to add the new arg. Maybe give it a default?
sunshineinabox commented 2024-11-22 03:07:46 +00:00 (Migrated from github.com)
Copy Link

Oh just missed a change, this was actually a open PR that I just migrated here. Should be fixed now.

Oh just missed a change, this was actually a open PR that I just migrated here. Should be fixed now.
👍 1
github-actions[bot] commented 2024-11-22 03:18:47 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+10ff736-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265501698.zip) * [ryujinx-Release-1.2.0+10ff736-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265501806.zip) * [ryujinx-Release-1.2.0+10ff736-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265505260.zip) * [ryujinx-Release-1.2.0+10ff736-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265505315.zip) * [ryujinx-Release-1.2.0+10ff736-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265511989.zip) * [ryujinx-Release-1.2.0+10ff736-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265514855.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+10ff736-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265501936.zip) * [nogui-ryujinx-Release-1.2.0+10ff736-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265505415.zip) * [nogui-ryujinx-Release-1.2.0+10ff736-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265512115.zip) * [nogui-ryujinx-Release-1.2.0+10ff736-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265514925.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+10ff736-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265501775.zip) * [ryujinx-Debug-1.2.0+10ff736-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265501833.zip) * [nogui-ryujinx-Debug-1.2.0+10ff736-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265501921.zip) * [ryujinx-Debug-1.2.0+10ff736-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265506933.zip) * [ryujinx-Debug-1.2.0+10ff736-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265506995.zip) * [nogui-ryujinx-Debug-1.2.0+10ff736-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265507099.zip) * [ryujinx-Debug-1.2.0+10ff736-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265511567.zip) * [nogui-ryujinx-Debug-1.2.0+10ff736-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265511702.zip) * [ryujinx-Debug-1.2.0+10ff736-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265515848.zip) * [nogui-ryujinx-Debug-1.2.0+10ff736-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265515936.zip) </details>
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gpu
graphics-backend:vulkan
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#296
No description provided.
Delete Branch "ValidationErrors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?