Fix repeated dialog popup notifying of new updates when there aren't any if you have bundled updates with external updates #30

2024-10-21T16:33:58Z

amurgshere commented

2024-10-21 16:33:58 +00:00

(Migrated from github.com)

This fixes a minor issue when you have bundled updates in your XCI and also have newer updates for that same Title when you have auto update selection turned on where a dialog would popup every time Ryujinx loads stating that it has found new updates (as the update fails to save with error below).

This occurs because the auto update selection code is not unselecting the already selected bundled update and the save is failing to save with this warning in the logs:

"00:00:04.237 |E| GUI.ApplicationLibraryThread Application SaveTitleUpdatesJson: Tried to save two updates as 'IsSelected' for 0100000000010000"

This code change fixes this issue by ensuring that we set the already selected update to be not selected when we select the new one, this then allows the save to occur correctly and the dialog does not keep showing upon initial load.

This fixes a minor issue when you have bundled updates in your XCI and also have newer updates for that same Title when you have auto update selection turned on where a dialog would popup every time Ryujinx loads stating that it has found new updates (as the update fails to save with error below). This occurs because the auto update selection code is not unselecting the already selected bundled update and the save is failing to save with this warning in the logs: "00:00:04.237 |E| GUI.ApplicationLibraryThread Application SaveTitleUpdatesJson: Tried to save two updates as 'IsSelected' for 0100000000010000" This code change fixes this issue by ensuring that we set the already selected update to be not selected when we select the new one, this then allows the save to occur correctly and the dialog does not keep showing upon initial load.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#30