MeloNX/Ryujinx-ryubing
11
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

[Build Issue] MacOS Sequoia Creates dot underscore files for com.apple.provenance which cause build to fail when using external drive #301

New Issue
Closed
opened 2024-11-23 17:54:46 +00:00 by amurgshere · 3 comments
amurgshere commented 2024-11-23 17:54:46 +00:00 (Migrated from github.com)
Copy Link

Description of the issue

When saving files under Mac OS Sequoia to an external drive not formatted with APFS, a dot underscore attribute file is created for modified files, MSBUILD picks these up and fails the build with error:

CSC : error CS2015: '/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/._Updater.cs' is a binary file instead of a text file [/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/Ryujinx.csproj]

Adding the following line to the csproj files inside the project group will stop these files from attempted to being built:

<DefaultItemExcludes>$(DefaultItemExcludes);._*</DefaultItemExcludes>

Also suggest that we exclude these files from GIT as well by adding this line to the .gitignore file:

._*

Does anybody have an issue with me creating a PR with these changes in them to make development under MacOS Sequoia more pleasant?

Reproduction steps

  1. Using an external drive formatted as exFAT under MacOS Sequoia, modify a code file and save
  2. Notice that a ._ file is created for the modified file with "com.apple.provenance" attribute
  3. Attempt to build, build fails due to binary file

Log file

CSC : error CS2015: '/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/._Updater.cs' is a binary file instead of a text file [/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/Ryujinx.csproj]

OS

Mac OS Sequoia 15.1

Ryujinx version

All

Game version

NA

CPU

NA

GPU

NA

RAM

NA

List of applied mods

No response

Additional context?

No response

### Description of the issue When saving files under Mac OS Sequoia to an external drive not formatted with APFS, a dot underscore attribute file is created for modified files, MSBUILD picks these up and fails the build with error: CSC : error CS2015: '/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/._Updater.cs' is a binary file instead of a text file [/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/Ryujinx.csproj] Adding the following line to the csproj files inside the project group will stop these files from attempted to being built: <DefaultItemExcludes>$(DefaultItemExcludes);._*</DefaultItemExcludes> Also suggest that we exclude these files from GIT as well by adding this line to the .gitignore file: ._* Does anybody have an issue with me creating a PR with these changes in them to make development under MacOS Sequoia more pleasant? ### Reproduction steps 1) Using an external drive formatted as exFAT under MacOS Sequoia, modify a code file and save 2) Notice that a ._ file is created for the modified file with "com.apple.provenance" attribute 3) Attempt to build, build fails due to binary file ### Log file CSC : error CS2015: '/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/._Updater.cs' is a binary file instead of a text file [/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/Ryujinx.csproj] ### OS Mac OS Sequoia 15.1 ### Ryujinx version All ### Game version NA ### CPU NA ### GPU NA ### RAM NA ### List of applied mods _No response_ ### Additional context? _No response_
GreemDev commented 2024-11-23 18:01:44 +00:00 (Migrated from github.com)
Copy Link

You're one of the only people who could open a PR to fix this, as I don't have a mac. So you probably should

You're one of the only people who could open a PR to fix this, as I don't have a mac. So you probably should
amurgshere commented 2024-11-24 01:01:12 +00:00 (Migrated from github.com)
Copy Link

Hey @GreemDev , I have created PR https://github.com/GreemDev/Ryujinx/pull/302 to fix this, thank you.

Hey @GreemDev , I have created PR https://github.com/GreemDev/Ryujinx/pull/302 to fix this, thank you.
GreemDev commented 2024-12-06 06:32:21 +00:00 (Migrated from github.com)
Copy Link

PR for this was merged a while ago, I guess it was never linked to this issue. Closing

PR for this was merged a while ago, I guess it was never linked to this issue. Closing
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0-Blu Fen Lonkelle Propenchieferr Stern bella jkcoxson june ny spidy123222 stossy11
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#301
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?