MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

ignore macos attribute files #302

Merged
amurgshere merged 2 commits from ignore-macos-attribute-files into master 2024-11-28 22:55:51 +00:00
Conversation 1 Commits 2 Files Changed 40 +43
amurgshere commented 2024-11-23 18:07:43 +00:00 (Migrated from github.com)
Copy Link

When saving files under Mac OS Sequoia to an external drive not formatted with APFS, a dot underscore attribute file is created for modified files, MSBUILD picks these up and fails the build with error:

CSC : error CS2015: '/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/._Updater.cs' is a binary file instead of a text file [/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/Ryujinx.csproj]

Adding the following line to the csproj files inside the project group will stop these files from attempted to being built:

$(DefaultItemExcludes);._*

Also suggest that we exclude these files from GIT as well by adding this line to the .gitignore file:

._*

This is a PR to fix this issue so that the MacOS attribute files are ignored both by the build and by git to make development easier when working with external drives.

This fixes issue https://github.com/GreemDev/Ryujinx/issues/301

When saving files under Mac OS Sequoia to an external drive not formatted with APFS, a dot underscore attribute file is created for modified files, MSBUILD picks these up and fails the build with error: CSC : error CS2015: '/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/._Updater.cs' is a binary file instead of a text file [/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/Ryujinx.csproj] Adding the following line to the csproj files inside the project group will stop these files from attempted to being built: <DefaultItemExcludes>$(DefaultItemExcludes);._*</DefaultItemExcludes> Also suggest that we exclude these files from GIT as well by adding this line to the .gitignore file: ._* This is a PR to fix this issue so that the MacOS attribute files are ignored both by the build and by git to make development easier when working with external drives. This fixes issue https://github.com/GreemDev/Ryujinx/issues/301
👍 1
github-actions[bot] commented 2024-11-23 18:19:26 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+931b16f-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228335954.zip) * [ryujinx-Release-1.2.0+931b16f-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228335983.zip) * [ryujinx-Release-1.2.0+931b16f-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228338097.zip) * [ryujinx-Release-1.2.0+931b16f-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228338126.zip) * [ryujinx-Release-1.2.0+931b16f-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228339900.zip) * [ryujinx-Release-1.2.0+931b16f-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228341595.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+931b16f-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228336034.zip) * [nogui-ryujinx-Release-1.2.0+931b16f-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228338184.zip) * [nogui-ryujinx-Release-1.2.0+931b16f-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228339954.zip) * [nogui-ryujinx-Release-1.2.0+931b16f-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228341660.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+931b16f-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228337228.zip) * [ryujinx-Debug-1.2.0+931b16f-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228337267.zip) * [nogui-ryujinx-Debug-1.2.0+931b16f-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228337305.zip) * [ryujinx-Debug-1.2.0+931b16f-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228339553.zip) * [nogui-ryujinx-Debug-1.2.0+931b16f-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228339595.zip) * [ryujinx-Debug-1.2.0+931b16f-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228339653.zip) * [ryujinx-Debug-1.2.0+931b16f-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228339688.zip) * [nogui-ryujinx-Debug-1.2.0+931b16f-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228339742.zip) * [ryujinx-Debug-1.2.0+931b16f-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228342638.zip) * [nogui-ryujinx-Debug-1.2.0+931b16f-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2228342711.zip) </details>
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
infra
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#302
No description provided.
Delete Branch "ignore-macos-attribute-files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?