MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Fix analysis and style formatting errors #31

Closed
qurious-pixel wants to merge 6 commits from patch-1 into master
pull from: patch-1
merge into: MeloNX:master
Conversation 4 Commits 6 Files Changed 2 +8 -4
qurious-pixel commented 2024-10-21 20:42:25 +00:00 (Migrated from github.com)
Copy Link

Pause white space error checking until fixed

Pause white space error checking until fixed
GreemDev (Migrated from github.com) reviewed 2024-10-22 04:21:27 +00:00
src/Ryujinx.UI.Common/Helper/SetupValidator.cs
GreemDev (Migrated from github.com) commented 2024-10-22 04:21:27 +00:00
Copy Link

This changes behavior of this method and needs to be put back

This changes behavior of this method and needs to be put back
qurious-pixel (Migrated from github.com) reviewed 2024-10-22 10:00:18 +00:00
src/Ryujinx.UI.Common/Helper/SetupValidator.cs
qurious-pixel (Migrated from github.com) commented 2024-10-22 10:00:18 +00:00
Copy Link

This change was merged in PR https://github.com/GreemDev/Ryujinx/pull/32

This change was merged in PR https://github.com/GreemDev/Ryujinx/pull/32
github-actions[bot] commented 2024-10-22 10:47:01 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less (SDL2)
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+2b0ab61-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087288645.zip) * [ryujinx-Release-1.2.0+2b0ab61-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087295455.zip) * [ryujinx-Release-1.2.0+2b0ab61-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087303757.zip) * [ryujinx-Release-1.2.0+2b0ab61-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087315492.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+2b0ab61-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087288777.zip) * [sdl2-ryujinx-headless-Release-1.2.0+2b0ab61-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087295628.zip) * [sdl2-ryujinx-headless-Release-1.2.0+2b0ab61-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087303927.zip) * [sdl2-ryujinx-headless-Release-1.2.0+2b0ab61-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087315638.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+2b0ab61-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087290170.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+2b0ab61-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087290389.zip) * [ryujinx-Debug-1.2.0+2b0ab61-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087298705.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+2b0ab61-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087298855.zip) * [ryujinx-Debug-1.2.0+2b0ab61-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087304644.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+2b0ab61-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087304832.zip) * [ryujinx-Debug-1.2.0+2b0ab61-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087314637.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+2b0ab61-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2087314972.zip) </details>
qurious-pixel commented 2024-10-23 08:06:35 +00:00 (Migrated from github.com)
Copy Link

Superseded by PR #32

Superseded by PR #32

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
infra
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#31
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?