MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

UI: Fix UpdateWaitWindow.axaml windows being too big on windows #314

Merged
GabCoolDude merged 5 commits from updatewaitwindowfix into master 2025-01-17 20:14:19 +00:00
Conversation 10 Commits 5 Files Changed 1 +1
GabCoolDude commented 2024-11-25 16:59:40 +00:00 (Migrated from github.com)
Copy Link

This fixes the window that appears for a bit while installing firmware being too big on windows ( my testing shows that this issue does not happen on macos ).

This fixes the window that appears for a bit while installing firmware being too big on windows ( my testing shows that this issue does not happen on macos ).
github-actions[bot] commented 2024-11-25 17:09:08 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+6ee97b6-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332289347.zip) * [ryujinx-Release-1.2.0+6ee97b6-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332289513.zip) * [ryujinx-Release-1.2.0+6ee97b6-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332297821.zip) * [ryujinx-Release-1.2.0+6ee97b6-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332298036.zip) * [ryujinx-Release-1.2.0+6ee97b6-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332305582.zip) * [ryujinx-Release-1.2.0+6ee97b6-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332316050.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+6ee97b6-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332289725.zip) * [nogui-ryujinx-Release-1.2.0+6ee97b6-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332298398.zip) * [nogui-ryujinx-Release-1.2.0+6ee97b6-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332305798.zip) * [nogui-ryujinx-Release-1.2.0+6ee97b6-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332316372.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+6ee97b6-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332289629.zip) * [ryujinx-Debug-1.2.0+6ee97b6-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332289836.zip) * [nogui-ryujinx-Debug-1.2.0+6ee97b6-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332290045.zip) * [ryujinx-Debug-1.2.0+6ee97b6-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332301858.zip) * [ryujinx-Debug-1.2.0+6ee97b6-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332302029.zip) * [nogui-ryujinx-Debug-1.2.0+6ee97b6-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332302254.zip) * [ryujinx-Debug-1.2.0+6ee97b6-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332306740.zip) * [nogui-ryujinx-Debug-1.2.0+6ee97b6-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332307537.zip) * [ryujinx-Debug-1.2.0+6ee97b6-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332331498.zip) * [nogui-ryujinx-Debug-1.2.0+6ee97b6-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2332331747.zip) </details>
GabCoolDude commented 2024-11-26 09:43:57 +00:00 (Migrated from github.com)
Copy Link

This needs testing to see if it breaks the window on Linux.

You can test by installing firmware or extracting romfs, exefs or icon and looking at the window that pops up for a small second.

This is nowhere near as important as jitsparse or custom "vsync" and doesn't need a lot of testing, even just one or two linux testers will do.

This needs testing to see if it breaks the window on Linux. You can test by installing firmware or extracting romfs, exefs or icon and looking at the window that pops up for a small second. This is nowhere near as important as jitsparse or custom "vsync" and doesn't need a lot of testing, even just one or two linux testers will do.
qurious-pixel commented 2024-11-29 00:43:48 +00:00 (Migrated from github.com)
Copy Link

Looks good on linux x64

image

Looks good on linux x64 ![image](https://github.com/user-attachments/assets/9ad4206a-d8f2-47e9-b0f9-a6e498de3b7e)
GabCoolDude commented 2024-11-29 15:50:31 +00:00 (Migrated from github.com)
Copy Link

That's not the windows i'm talking about, i'm actually talking about the window that shows up for a bit after you press "Yes" on that window.

That's not the windows i'm talking about, i'm actually talking about the window that shows up for a bit after you press "Yes" on that window.
GabCoolDude commented 2024-12-14 13:52:48 +00:00 (Migrated from github.com)
Copy Link

oopsies

oopsies
GreemDev commented 2024-12-15 11:22:46 +00:00 (Migrated from github.com)
Copy Link

can we get any linux testers so i can finally merge this one-line 3 week old pr

can we get any linux testers so i can finally merge this one-line 3 week old pr
Daenorth commented 2024-12-15 11:23:43 +00:00 (Migrated from github.com)
Copy Link

I'll check by the end of the day

I'll check by the end of the day
👍 1
GabCoolDude commented 2024-12-26 17:55:26 +00:00 (Migrated from github.com)
Copy Link

any linux testers ?

any linux testers ?
Daenorth commented 2024-12-27 00:02:18 +00:00 (Migrated from github.com)
Copy Link

I did a test and reported it in Testing on the Discord - it all seemed Fine for me on Linux - a couple of days ago

Edit: was 15.12.24 - the same day as the last two commits.

I did a test and reported it in Testing on the Discord - it all seemed Fine for me on Linux - a couple of days ago Edit: was 15.12.24 - the same day as the last two commits.
Daenorth commented 2024-12-27 22:00:09 +00:00 (Migrated from github.com)
Copy Link

Just adding that i tested again today, and its the same. All ok (for me on linux atleast)

Just adding that i tested again today, and its the same. All ok (for me on linux atleast)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
windows
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#314
No description provided.
Delete Branch "updatewaitwindowfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?