MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Add the Cabinet Applet #340

Merged
Jacobwasbeast merged 5 commits from feature/cabinet-applet into master 2024-12-03 05:40:02 +00:00
Conversation 3 Commits 5 Files Changed 24 +335
Jacobwasbeast commented 2024-12-03 01:50:20 +00:00 (Migrated from github.com)
Copy Link

This adds the missing Cabinet Applet, which allows for formatting Amiibos and changing their names.

This adds the missing Cabinet Applet, which allows for formatting Amiibos and changing their names.
❤️ 1
GreemDev (Migrated from github.com) requested changes 2024-12-03 02:12:28 +00:00
GreemDev (Migrated from github.com) left a comment
Copy Link

Apart from these somewhat minor issues, looks awesome!

Apart from these somewhat minor issues, looks awesome!
src/Ryujinx.HLE/HOS/Applets/Cabinet/CabinetApplet.cs
GreemDev (Migrated from github.com) commented 2024-12-03 02:11:15 +00:00
Copy Link

string.Empty here as well

`string.Empty` here as well
src/Ryujinx/Assets/Locales/en_US.json
@ -716,1 +716,4 @@
"SwkbdMinRangeCharacters": "Must be {0}-{1} characters long",
"CabinetTitle": "Cabinet Dialog",
"CabinetDialog": "Enter your Amiibo's new name",
"CabinetScanDialog": "Please scan your Amiibo now.",
GreemDev (Migrated from github.com) commented 2024-12-03 02:10:41 +00:00
Copy Link

Please add these to every locale file in the same location in each

Please add these to every locale file in the same location in each
src/Ryujinx/UI/Applet/AvaHostUIHandler.cs
GreemDev (Migrated from github.com) commented 2024-12-03 02:10:08 +00:00
Copy Link

Styling nitpick: use string.Empty instead

Styling nitpick: use `string.Empty` instead
github-actions[bot] commented 2024-12-03 02:16:59 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+71a52b3-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265005654.zip) * [ryujinx-Release-1.2.0+71a52b3-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265005718.zip) * [ryujinx-Release-1.2.0+71a52b3-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265009789.zip) * [ryujinx-Release-1.2.0+71a52b3-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265009855.zip) * [ryujinx-Release-1.2.0+71a52b3-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265014121.zip) * [ryujinx-Release-1.2.0+71a52b3-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265019461.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+71a52b3-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265005805.zip) * [nogui-ryujinx-Release-1.2.0+71a52b3-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265009943.zip) * [nogui-ryujinx-Release-1.2.0+71a52b3-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265014211.zip) * [nogui-ryujinx-Release-1.2.0+71a52b3-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265019653.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+71a52b3-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265005812.zip) * [ryujinx-Debug-1.2.0+71a52b3-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265005866.zip) * [nogui-ryujinx-Debug-1.2.0+71a52b3-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265005966.zip) * [ryujinx-Debug-1.2.0+71a52b3-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265011597.zip) * [ryujinx-Debug-1.2.0+71a52b3-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265011699.zip) * [nogui-ryujinx-Debug-1.2.0+71a52b3-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265011840.zip) * [ryujinx-Debug-1.2.0+71a52b3-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265015020.zip) * [nogui-ryujinx-Debug-1.2.0+71a52b3-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265015106.zip) * [ryujinx-Debug-1.2.0+71a52b3-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265022557.zip) * [nogui-ryujinx-Debug-1.2.0+71a52b3-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2265022720.zip) </details>
GreemDev (Migrated from github.com) reviewed 2024-12-03 02:29:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
GreemDev
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
horizon
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#340
No description provided.
Delete Branch "feature/cabinet-applet"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?