MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Add Firmware keyword in log if it is indeed firmware #343

Merged
WilliamWsyHK merged 8 commits from enhancement/firmware-text-log into master 2024-12-07 10:03:01 +00:00
Conversation 6 Commits 8 Files Changed 7 +50 -15
WilliamWsyHK commented 2024-12-03 15:17:28 +00:00 (Migrated from github.com)
Copy Link
No description provided.
github-actions[bot] commented 2024-12-03 15:28:03 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+0883f52-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286063343.zip) * [ryujinx-Release-1.2.0+0883f52-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286063560.zip) * [ryujinx-Release-1.2.0+0883f52-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286069466.zip) * [ryujinx-Release-1.2.0+0883f52-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286069574.zip) * [ryujinx-Release-1.2.0+0883f52-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286077097.zip) * [ryujinx-Release-1.2.0+0883f52-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286084811.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+0883f52-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286063858.zip) * [nogui-ryujinx-Release-1.2.0+0883f52-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286069721.zip) * [nogui-ryujinx-Release-1.2.0+0883f52-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286077257.zip) * [nogui-ryujinx-Release-1.2.0+0883f52-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286085097.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+0883f52-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286062857.zip) * [ryujinx-Debug-1.2.0+0883f52-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286062988.zip) * [nogui-ryujinx-Debug-1.2.0+0883f52-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286063166.zip) * [ryujinx-Debug-1.2.0+0883f52-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286073251.zip) * [ryujinx-Debug-1.2.0+0883f52-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286073452.zip) * [nogui-ryujinx-Debug-1.2.0+0883f52-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286073702.zip) * [ryujinx-Debug-1.2.0+0883f52-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286077615.zip) * [nogui-ryujinx-Debug-1.2.0+0883f52-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286077806.zip) * [ryujinx-Debug-1.2.0+0883f52-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286091123.zip) * [nogui-ryujinx-Debug-1.2.0+0883f52-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2286091403.zip) </details>
GreemDev (Migrated from github.com) reviewed 2024-12-03 23:46:50 +00:00
src/Ryujinx.HLE/Loaders/Processes/ProcessResult.cs
GreemDev (Migrated from github.com) commented 2024-12-03 23:46:50 +00:00
Copy Link

Just inline this:

bool isFirmware = ProgramId switch
{
    >= 0x0100000000000819 and <= 0x010000000000081C => true,
    _ => false
};
Just inline this: ```cs bool isFirmware = ProgramId switch { >= 0x0100000000000819 and <= 0x010000000000081C => true, _ => false };
WilliamWsyHK (Migrated from github.com) reviewed 2024-12-04 00:05:21 +00:00
src/Ryujinx.HLE/Loaders/Processes/ProcessResult.cs
WilliamWsyHK (Migrated from github.com) commented 2024-12-04 00:05:20 +00:00
Copy Link

done, please check

done, please check
mattzink (Migrated from github.com) reviewed 2024-12-05 00:29:23 +00:00
src/Ryujinx.HLE/Loaders/Processes/ProcessResult.cs
mattzink (Migrated from github.com) commented 2024-12-05 00:29:22 +00:00
Copy Link

No need for branching, since this is just a simple condition

bool isFimware = ProgramId is >= 0x0100000000000819 and <= 0x010000000000081C;
No need for branching, since this is just a simple condition ```csharp bool isFimware = ProgramId is >= 0x0100000000000819 and <= 0x010000000000081C; ```
GreemDev (Migrated from github.com) reviewed 2024-12-05 01:24:24 +00:00
src/Ryujinx.HLE/Loaders/Processes/ProcessResult.cs
GreemDev (Migrated from github.com) commented 2024-12-05 01:24:24 +00:00
Copy Link

Good point actually. When I wrote my original PR review comment I had the most annoying feeling that it could be simplified even further than what I was suggesting lol

Good point actually. When I wrote my original PR review comment I had the most annoying feeling that it could be simplified even further than what I was suggesting lol
WilliamWsyHK (Migrated from github.com) reviewed 2024-12-05 15:42:32 +00:00
src/Ryujinx.HLE/Loaders/Processes/ProcessResult.cs
WilliamWsyHK (Migrated from github.com) commented 2024-12-05 15:42:32 +00:00
Copy Link

yeah, why not? done.

yeah, why not? done.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
horizon
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#343
No description provided.
Delete Branch "enhancement/firmware-text-log"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?