MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Adds the ability to read and write to amiibo bin files #348

Merged
Jacobwasbeast merged 11 commits from feature/amiibo-bin-reading into master 2024-12-20 04:36:47 +00:00
Conversation 4 Commits 11 Files Changed 29 +1855 -916
Jacobwasbeast commented 2024-12-05 09:07:32 +00:00 (Migrated from github.com)
Copy Link

This introduces the ability to read and write game data and model information from an Amiibo dump file (BIN format). Note that this functionality requires the presence of a key_retail.bin file. For the option to appear and function in the UI, ensure that the key_retail.bin file is located in the RyuJinx/system folder.

This introduces the ability to read and write game data and model information from an Amiibo dump file (BIN format). Note that this functionality requires the presence of a key_retail.bin file. For the option to appear and function in the UI, ensure that the key_retail.bin file is located in the RyuJinx/system folder.
❤️ 1
github-actions[bot] commented 2024-12-05 09:18:06 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+e0a0ff6-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346683886.zip) * [ryujinx-Release-1.2.0+e0a0ff6-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346684000.zip) * [ryujinx-Release-1.2.0+e0a0ff6-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346687255.zip) * [ryujinx-Release-1.2.0+e0a0ff6-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346687318.zip) * [ryujinx-Release-1.2.0+e0a0ff6-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346691595.zip) * [ryujinx-Release-1.2.0+e0a0ff6-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346694028.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+e0a0ff6-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346684154.zip) * [nogui-ryujinx-Release-1.2.0+e0a0ff6-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346687393.zip) * [nogui-ryujinx-Release-1.2.0+e0a0ff6-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346691670.zip) * [nogui-ryujinx-Release-1.2.0+e0a0ff6-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346694199.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+e0a0ff6-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346684395.zip) * [ryujinx-Debug-1.2.0+e0a0ff6-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346684506.zip) * [nogui-ryujinx-Debug-1.2.0+e0a0ff6-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346684607.zip) * [ryujinx-Debug-1.2.0+e0a0ff6-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346688378.zip) * [ryujinx-Debug-1.2.0+e0a0ff6-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346688441.zip) * [nogui-ryujinx-Debug-1.2.0+e0a0ff6-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346688529.zip) * [ryujinx-Debug-1.2.0+e0a0ff6-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346691479.zip) * [nogui-ryujinx-Debug-1.2.0+e0a0ff6-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346691574.zip) * [ryujinx-Debug-1.2.0+e0a0ff6-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346696629.zip) * [nogui-ryujinx-Debug-1.2.0+e0a0ff6-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2346696739.zip) </details>
GreemDev (Migrated from github.com) requested changes 2024-12-12 19:20:15 +00:00
src/Ryujinx.HLE/HOS/Services/Nfc/Nfp/VirtualAmiibo.cs
GreemDev (Migrated from github.com) commented 2024-12-12 19:18:14 +00:00
Copy Link

Please give these fields the proper casing OpenedApplicationAreaId, ApplicationBytes, etc

Please give these fields the proper casing `OpenedApplicationAreaId`, `ApplicationBytes`, etc
src/Ryujinx/UI/ViewModels/MainWindowViewModel.cs
GreemDev (Migrated from github.com) commented 2024-12-12 19:19:47 +00:00
Copy Link

Why was _showRightmostSeparator readded? I changed the name of this when I moved the status bar stuff around

Why was `_showRightmostSeparator` readded? I changed the name of this when I moved the status bar stuff around
Jacobwasbeast (Migrated from github.com) reviewed 2024-12-12 19:22:35 +00:00
src/Ryujinx/UI/ViewModels/MainWindowViewModel.cs
Jacobwasbeast (Migrated from github.com) commented 2024-12-12 19:22:35 +00:00
Copy Link

whoops my bad it got re-added when I was changing things, removing it now

whoops my bad it got re-added when I was changing things, removing it now
GreemDev (Migrated from github.com) reviewed 2024-12-12 19:48:08 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
GreemDev
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
horizon
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#348
No description provided.
Delete Branch "feature/amiibo-bin-reading"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?