MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Game Updates Not Auto Loading #379

New Issue
Closed
opened 2024-12-12 22:32:50 +00:00 by Horakht · 20 comments
Horakht commented 2024-12-12 22:32:50 +00:00 (Migrated from github.com)
Copy Link

Description of the issue

I think it was working in Canary 1.2.88 but not 100% sure....anyways the issue is that when I used to download new game updates, and place them in the correct folder after deleting the old update, Ryujinx would auto detect the new update upon loading, and apply the new update automatically. Now, even though it still detects the new update, it doesn't automatically apply the new update, it defaults to the stock update/no update. I have to go to the game I updated, right-click and select "manage title updates" and manually click on the new update to apply it.

Reproduction steps

Have a newer update for a game, place that new update in your specified directory, erase your old update. Start Ryujinx and wait for your games to finish loading. A prompt will come up telling you that it found 1 new update. Close the prompt and scroll to find the game you just updated. It will be on the default version now instead of the new update.

Log file

Ryujinx_Canary_1.2.89_2024-12-12_16-17-11.log

OS

Win 11

Ryujinx version

Canary 1.2.89

Game version

No response

CPU

No response

GPU

No response

RAM

No response

List of applied mods

No response

Additional context?

No response

### Description of the issue I think it was working in Canary 1.2.88 but not 100% sure....anyways the issue is that when I used to download new game updates, and place them in the correct folder after deleting the old update, Ryujinx would auto detect the new update upon loading, and apply the new update automatically. Now, even though it still detects the new update, it doesn't automatically apply the new update, it defaults to the stock update/no update. I have to go to the game I updated, right-click and select "manage title updates" and manually click on the new update to apply it. ### Reproduction steps Have a newer update for a game, place that new update in your specified directory, erase your old update. Start Ryujinx and wait for your games to finish loading. A prompt will come up telling you that it found 1 new update. Close the prompt and scroll to find the game you just updated. It will be on the default version now instead of the new update. ### Log file [Ryujinx_Canary_1.2.89_2024-12-12_16-17-11.log](https://github.com/user-attachments/files/18118148/Ryujinx_Canary_1.2.89_2024-12-12_16-17-11.log) ### OS Win 11 ### Ryujinx version Canary 1.2.89 ### Game version _No response_ ### CPU _No response_ ### GPU _No response_ ### RAM _No response_ ### List of applied mods _No response_ ### Additional context? _No response_
gh0sti commented 2024-12-31 17:32:22 +00:00 (Migrated from github.com)
Copy Link

Just noticed this too this was working before on 1.2.76 and lower.

Just noticed this too this was working before on 1.2.76 and lower.
Horakht commented 2024-12-31 23:55:29 +00:00 (Migrated from github.com)
Copy Link

Just noticed this too this was working before on 1.2.76 and lower.

Yes I would've hoped it would be fixed by now, just find a version it worked in, see which version broke it and bam. Unless I'm missing something lol but an inconvenience at best, still glad it auto detects the updates.

> Just noticed this too this was working before on 1.2.76 and lower. Yes I would've hoped it would be fixed by now, just find a version it worked in, see which version broke it and bam. Unless I'm missing something lol but an inconvenience at best, still glad it auto detects the updates.
GreemDev commented 2025-01-01 00:00:32 +00:00 (Migrated from github.com)
Copy Link

This is confusing. Canary 89 compared to 88 is apparently when it broke, but that version locale changes & adding a table to the GitHub releases.

I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior.

Are you sure it was working on Canary 88? That one did change logic.

This is confusing. [Canary 89 compared to 88](https://github.com/Ryubing/Ryujinx/compare/Canary-1.2.88...Canary-1.2.89) is apparently when it broke, but that version locale changes & adding a table to the GitHub releases. I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior. Are you sure it was working on Canary 88? That one did change logic.
gh0sti commented 2025-01-01 00:17:27 +00:00 (Migrated from github.com)
Copy Link

This is confusing. Canary 89 compared to 88 is apparently when it broke, but that version locale changes & adding a table to the GitHub releases.

I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior.

Are you sure it was working on Canary 88? That one did change logic.

Is 1.2.78 based on canary 89?

> This is confusing. [Canary 89 compared to 88](https://github.com/Ryubing/Ryujinx/compare/Canary-1.2.88...Canary-1.2.89) is apparently when it broke, but that version locale changes & adding a table to the GitHub releases. > > > > I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior. > > > > Are you sure it was working on Canary 88? That one did change logic. Is 1.2.78 based on canary 89?
GreemDev commented 2025-01-01 00:20:20 +00:00 (Migrated from github.com)
Copy Link

This is confusing. Canary 89 compared to 88 is apparently when it broke, but that version locale changes & adding a table to the GitHub releases.
I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior.
Are you sure it was working on Canary 88? That one did change logic.

Is 1.2.78 based on canary 89?

No.

> > This is confusing. [Canary 89 compared to 88](https://github.com/Ryubing/Ryujinx/compare/Canary-1.2.88...Canary-1.2.89) is apparently when it broke, but that version locale changes & adding a table to the GitHub releases. > > I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior. > > Are you sure it was working on Canary 88? That one did change logic. > > Is 1.2.78 based on canary 89? No.
Horakht commented 2025-01-01 00:43:14 +00:00 (Migrated from github.com)
Copy Link

This is confusing. Canary 89 compared to 88 is apparently when it broke, but that version locale changes & adding a table to the GitHub releases.

I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior.

Are you sure it was working on Canary 88? That one did change logic.

Im not 100% sure it was working on Canary 88, I think that is just when I noticed it. I know for sure it was working in one of the Canary 70 versions

> This is confusing. [Canary 89 compared to 88](https://github.com/Ryubing/Ryujinx/compare/Canary-1.2.88...Canary-1.2.89) is apparently when it broke, but that version locale changes & adding a table to the GitHub releases. > > I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior. > > Are you sure it was working on Canary 88? That one did change logic. Im not 100% sure it was working on Canary 88, I think that is just when I noticed it. I know for sure it was working in one of the Canary 70 versions
GreemDev commented 2025-01-05 06:58:26 +00:00 (Migrated from github.com)
Copy Link

Unless I'm given a Canary where it broke I can't fix this; at least not with an ugly ass hack workaround.
The reason is there's no way in the emulator code for me to know if the user chose to launch with no update or if it's just the initial state after loading available updates. Those 2 states are identical.

I don't want to ALWAYS load the latest update when you load the games list with v1 of a game selected with updates present. If you want to play V1 of games this would be annoying, and just replacing one regression in functionality with another.

This definitely raises the question how it worked fine before. It's not like I removed the code to auto-select updates on purpose, so it must have been something small...

Unless I'm given a Canary where it broke I can't fix this; at least not with an ugly ass hack workaround. The reason is there's no way in the emulator code for me to know if the user chose to launch with no update or if it's just the initial state after loading available updates. Those 2 states are identical. I don't want to ALWAYS load the latest update when you load the games list with v1 of a game selected with updates present. If you want to play V1 of games this would be annoying, and just replacing one regression in functionality with another. This definitely raises the question how it worked fine before. It's not like I removed the code to auto-select updates on purpose, so it must have been something small...
gh0sti commented 2025-01-05 11:20:05 +00:00 (Migrated from github.com)
Copy Link

Unless I'm given a Canary where it broke I can't fix this; at least not with an ugly ass hack workaround. The reason is there's no way in the emulator code for me to know if the user chose to launch with no update or if it's just the initial state after loading available updates. Those 2 states are identical.

I don't want to ALWAYS load the latest update when you load the games list with v1 of a game selected with updates present. If you want to play V1 of games this would be annoying, and just replacing one regression in functionality with another.

This definitely raises the question how it worked fine before. It's not like I removed the code to auto-select updates on purpose, so it must have been something small...

So I have been making some super xcis with my dumps and noticed that it reverts back to selecting v1 instead of the bundled update. The auto selecting of latest game update had to have broken updating from stable 1.2.76 to 1.2.78, doing a diff on those 2 versions wouldn't be helpful?

> Unless I'm given a Canary where it broke I can't fix this; at least not with an ugly ass hack workaround. The reason is there's no way in the emulator code for me to know if the user chose to launch with no update or if it's just the initial state after loading available updates. Those 2 states are identical. > > I don't want to ALWAYS load the latest update when you load the games list with v1 of a game selected with updates present. If you want to play V1 of games this would be annoying, and just replacing one regression in functionality with another. > > This definitely raises the question how it worked fine before. It's not like I removed the code to auto-select updates on purpose, so it must have been something small... So I have been making some super xcis with my dumps and noticed that it reverts back to selecting v1 instead of the bundled update. The auto selecting of latest game update had to have broken updating from stable 1.2.76 to 1.2.78, doing a diff on those 2 versions wouldn't be helpful?
GreemDev commented 2025-01-05 11:28:01 +00:00 (Migrated from github.com)
Copy Link

Unless I'm given a Canary where it broke I can't fix this; at least not with an ugly ass hack workaround. The reason is there's no way in the emulator code for me to know if the user chose to launch with no update or if it's just the initial state after loading available updates. Those 2 states are identical.
I don't want to ALWAYS load the latest update when you load the games list with v1 of a game selected with updates present. If you want to play V1 of games this would be annoying, and just replacing one regression in functionality with another.
This definitely raises the question how it worked fine before. It's not like I removed the code to auto-select updates on purpose, so it must have been something small...

So I have been making some super xcis with my dumps and noticed that it reverts back to selecting v1 instead of the bundled update. The auto selecting of latest game update had to have broken updating from stable 1.2.76 to 1.2.78, doing a diff on those 2 versions wouldn't be helpful?

Stable versions can have tens of commits in each one now, canary only has a few each.

> > Unless I'm given a Canary where it broke I can't fix this; at least not with an ugly ass hack workaround. The reason is there's no way in the emulator code for me to know if the user chose to launch with no update or if it's just the initial state after loading available updates. Those 2 states are identical. > > I don't want to ALWAYS load the latest update when you load the games list with v1 of a game selected with updates present. If you want to play V1 of games this would be annoying, and just replacing one regression in functionality with another. > > This definitely raises the question how it worked fine before. It's not like I removed the code to auto-select updates on purpose, so it must have been something small... > > So I have been making some super xcis with my dumps and noticed that it reverts back to selecting v1 instead of the bundled update. The auto selecting of latest game update had to have broken updating from stable 1.2.76 to 1.2.78, doing a diff on those 2 versions wouldn't be helpful? Stable versions can have tens of commits in each one now, canary only has a few each.
gh0sti commented 2025-01-05 11:46:46 +00:00 (Migrated from github.com)
Copy Link

@GreemDev I want to say the logic here with changes on DLC being loaded could have affected how Ryu reads game updates. "Fix missing total DLC count in the Manage DLC window."

de00a71690

@GreemDev I want to say the logic here with changes on DLC being loaded could have affected how Ryu reads game updates. "Fix missing total DLC count in the Manage DLC window." https://github.com/Ryubing/Ryujinx/commit/de00a71690d482f14e54d1b1fd21a8d04de84929
GreemDev commented 2025-01-05 11:48:29 +00:00 (Migrated from github.com)
Copy Link

DownloadableContentModel refers to DLCs specifically; this code isn't touched for updates

`DownloadableContentModel` refers to DLCs specifically; this code isn't touched for updates
Horakht commented 2025-01-05 14:03:45 +00:00 (Migrated from github.com)
Copy Link

So I just tested, it was last working correctly as of Canary 1.2.80. I tried with Canary 81 and 82 and the program just crashed when trying to detect the updates I assume. And every time you reopen the program it crashes before you even get to try and change settings. So yeah 1.2.80 Canary works fine

So I just tested, it was last working correctly as of Canary 1.2.80. I tried with Canary 81 and 82 and the program just crashed when trying to detect the updates I assume. And every time you reopen the program it crashes before you even get to try and change settings. So yeah 1.2.80 Canary works fine
HH-Unix commented 2025-01-05 16:25:37 +00:00 (Migrated from github.com)
Copy Link

Canary-1.2.80 it worked well! 81 to 83, Ryujinx crashed. Maybe it's related to this code line at canary-1.2.84: {currentlySelected.Check(curr => curr.TitleUpdate?. Version < update.Version);} The "?" Has been added!

Canary-1.2.80 it worked well! 81 to 83, Ryujinx crashed. Maybe it's related to this code line at canary-1.2.84: {currentlySelected.Check(curr => curr.TitleUpdate?. Version < update.Version);} The "?" Has been added!
GreemDev commented 2025-01-05 21:46:52 +00:00 (Migrated from github.com)
Copy Link

8a2bc3957a
Give Canary 209 a try when builds are available: https://github.com/Ryubing/Canary-Releases/releases/tag/1.2.209

https://github.com/Ryubing/Ryujinx/commit/8a2bc3957a7826b712a2661553a184dd522e8a8d Give Canary 209 a try when builds are available: https://github.com/Ryubing/Canary-Releases/releases/tag/1.2.209
Horakht commented 2025-01-05 21:56:16 +00:00 (Migrated from github.com)
Copy Link

8a2bc39 Give Canary 209 a try when builds are available: https://github.com/Ryubing/Canary-Releases/releases/tag/1.2.209

Just tested, clean portable build, it crashes also and keeps crashing every time I load ryujinx after I added my directories

> [8a2bc39](https://github.com/Ryubing/Ryujinx/commit/8a2bc3957a7826b712a2661553a184dd522e8a8d) Give Canary 209 a try when builds are available: https://github.com/Ryubing/Canary-Releases/releases/tag/1.2.209 Just tested, clean portable build, it crashes also and keeps crashing every time I load ryujinx after I added my directories
GreemDev commented 2025-01-05 21:56:44 +00:00 (Migrated from github.com)
Copy Link

can you please give me a crash log....so i can actually fix it...

can you please give me a crash log....so i can actually fix it...
Horakht commented 2025-01-05 21:59:35 +00:00 (Migrated from github.com)
Copy Link

Ryujinx_Canary_1.2.209_2025-01-05_15-59-04.log

[Ryujinx_Canary_1.2.209_2025-01-05_15-59-04.log](https://github.com/user-attachments/files/18311843/Ryujinx_Canary_1.2.209_2025-01-05_15-59-04.log)
GreemDev commented 2025-01-05 22:04:02 +00:00 (Migrated from github.com)
Copy Link

Alright try out Canary 210 when it's ready

Alright try out Canary 210 when it's ready
👍 1
Horakht commented 2025-01-05 22:07:42 +00:00 (Migrated from github.com)
Copy Link

Alright will post in a few minutes

Alright will post in a few minutes
Horakht commented 2025-01-05 22:12:10 +00:00 (Migrated from github.com)
Copy Link

Everything seems to be working fine again now as of Canary 210. Thanks!

Everything seems to be working fine again now as of Canary 210. Thanks!
❤️ 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#379
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?