MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Korean translation update #398

Closed
Hackjjang wants to merge 1 commits from patch-10 into master
pull from: patch-10
merge into: MeloNX:master
Conversation 10 Commits 1 Files Changed 1 +6 -6
Hackjjang commented 2024-12-17 23:43:38 +00:00 (Migrated from github.com)
Copy Link
No description provided.
github-actions[bot] commented 2024-12-17 23:52:48 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+6336c41-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349277203.zip) * [ryujinx-Release-1.2.0+6336c41-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349277300.zip) * [ryujinx-Release-1.2.0+6336c41-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349284045.zip) * [ryujinx-Release-1.2.0+6336c41-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349284152.zip) * [ryujinx-Release-1.2.0+6336c41-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349290792.zip) * [ryujinx-Release-1.2.0+6336c41-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349300813.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+6336c41-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349277487.zip) * [nogui-ryujinx-Release-1.2.0+6336c41-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349284324.zip) * [nogui-ryujinx-Release-1.2.0+6336c41-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349290949.zip) * [nogui-ryujinx-Release-1.2.0+6336c41-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349301097.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+6336c41-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349277303.zip) * [ryujinx-Debug-1.2.0+6336c41-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349277787.zip) * [nogui-ryujinx-Debug-1.2.0+6336c41-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349277958.zip) * [ryujinx-Debug-1.2.0+6336c41-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349286506.zip) * [ryujinx-Debug-1.2.0+6336c41-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349287039.zip) * [nogui-ryujinx-Debug-1.2.0+6336c41-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349287259.zip) * [ryujinx-Debug-1.2.0+6336c41-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349290936.zip) * [nogui-ryujinx-Debug-1.2.0+6336c41-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349291053.zip) * [ryujinx-Debug-1.2.0+6336c41-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349302514.zip) * [nogui-ryujinx-Debug-1.2.0+6336c41-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2349302711.zip) </details>
LotP1 commented 2024-12-17 23:56:17 +00:00 (Migrated from github.com)
Copy Link

Duplicate of #389
Please don't open the same PR twice.

Duplicate of #389 Please don't open the same PR twice.
Hackjjang commented 2024-12-18 00:52:38 +00:00 (Migrated from github.com)
Copy Link

Are you saying to ignore what was rolled back?

Are you saying to ignore what was rolled back?
LotP1 commented 2024-12-18 00:55:15 +00:00 (Migrated from github.com)
Copy Link

nothing was rolled back, you just didn't continue work on your old changes.
your old changes haven't been included in the main branch yet due to another upcoming change.

nothing was rolled back, you just didn't continue work on your old changes. your old changes haven't been included in the main branch yet due to another upcoming change.
LotP1 commented 2024-12-18 00:58:18 +00:00 (Migrated from github.com)
Copy Link

to load your old changes go to your own profile, go into the ryujinx repo, and load the branch called "patch-7"

to load your old changes go to your own profile, go into the ryujinx repo, and load the branch called "patch-7"
GabCoolDude commented 2024-12-21 09:27:26 +00:00 (Migrated from github.com)
Copy Link

Please resolve your conflicts, the easiest way i found to do this was just to create a new branch based on GreemDev/Ryujinx and copy your changes from this PR to that branch and open a new PR, it's up to your though

Please resolve your conflicts, the easiest way i found to do this was just to create a new branch based on GreemDev/Ryujinx and copy your changes from this PR to that branch and open a new PR, it's up to your though
Hackjjang commented 2024-12-22 18:58:48 +00:00 (Migrated from github.com)
Copy Link

Honestly, I really regret giving up on this feed at the time and closing it down because the released version didn't have Korean localization.
This is because not having to proceed with something that needs to be reworked in the long run and having it made public are two different things.

Even though I no longer need it, I am very angry about this.

Honestly, I really regret giving up on this feed at the time and closing it down because the released version didn't have Korean localization. This is because not having to proceed with something that needs to be reworked in the long run and having it made public are two different things. Even though I no longer need it, I am very angry about this.
LotP1 commented 2024-12-22 19:14:08 +00:00 (Migrated from github.com)
Copy Link

this PR and other translation PRs weren't merged into release because it would've made #391 need to re-merge the new translations, which was kinda a pain.
the changes still exist here, you can copy the exact translations you want into a new PR with the new locales system.

this PR and other translation PRs weren't merged into release because it would've made #391 need to re-merge the new translations, which was kinda a pain. the changes still exist here, you can copy the exact translations you want into a new PR with the new locales system.
Hackjjang commented 2024-12-22 21:06:36 +00:00 (Migrated from github.com)
Copy Link

However, the 1.2.78 version released in the meantime was released without all the translations applied.
Until the next stable release comes out, Korean users will continue to use the untranslated public version.
Even my past translations aren't applied to the merged version.
There's no way I'm feeling good.

However, the 1.2.78 version released in the meantime was released without all the translations applied. Until the next stable release comes out, Korean users will continue to use the untranslated public version. Even my past translations aren't applied to the merged version. There's no way I'm feeling good.
LotP1 commented 2024-12-22 21:25:06 +00:00 (Migrated from github.com)
Copy Link

Your other PR got merged into Canary, our test release stream.
They will be part of the main release stream the next time it is updated.
The internal locales change was pushed out as fast as possible to make the period of time were language PRs would be broken as tiny as possible. You, along with a few others, just got unlucky to be caught in that small window of a few days.
Your new PR that worked with the new system got released after the main Release update, so it of course couldn't be part of 1.2.78.
If you're unsatisfied with how the current project is handled feel free to make a fork and manage it yourself. Just like you we do this work for free when we have time.

Your other PR got merged into Canary, our test release stream. They will be part of the main release stream the next time it is updated. The internal locales change was pushed out as fast as possible to make the period of time were language PRs would be broken as tiny as possible. You, along with a few others, just got unlucky to be caught in that small window of a few days. Your new PR that worked with the new system got released after the main Release update, so it of course couldn't be part of 1.2.78. If you're unsatisfied with how the current project is handled feel free to make a fork and manage it yourself. Just like you we do this work for free when we have time.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#398
No description provided.
Delete Branch "patch-10"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?