Added option to ignore applet (gamepad connection window will not appear when it is disconnected) #40

Merged
Goodfeat merged 6 commits from master into master 2024-10-24 01:10:55 +00:00
Goodfeat commented 2024-10-22 23:43:16 +00:00 (Migrated from github.com)

I made an additional option to ignore the dialog box when disconnecting the gamepad. This option will be useful for those who use the computer as a console (without a keyboard). With this setting, there is no longer a need to connect the keyboard to confirm the changes

I tested it in some games and it works. I also tried to translate the option into different languages

2024-10-23 094052

I made an additional option to ignore the dialog box when disconnecting the gamepad. This option will be useful for those who use the computer as a console (without a keyboard). With this setting, there is no longer a need to connect the keyboard to confirm the changes I tested it in some games and it works. I also tried to translate the option into different languages ![2024-10-23 094052](https://github.com/user-attachments/assets/1c668d90-9c31-4765-9793-33836243cf2e)
MetrosexualGarbodor commented 2024-10-23 00:40:39 +00:00 (Migrated from github.com)

This is a hack, as it makes the emulator ignore intended functionality. The applet should be either emulated fully so that it works just like on Switch, where it prompts to press a button, or for an iffier solution, the emulator should automatically dismiss it if the controller is re-detected after a disconnect.

If Greem really intends to merge this, at the very least it should be moved under "Hacks" in the UI.

This is a hack, as it makes the emulator ignore intended functionality. The applet should be either emulated fully so that it works just like on Switch, where it prompts to press a button, or for an iffier solution, the emulator should automatically dismiss it if the controller is re-detected after a disconnect. If Greem really intends to merge this, at the very least it should be moved under "Hacks" in the UI.
github-actions[bot] commented 2024-10-23 02:31:08 +00:00 (Migrated from github.com)
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+bb721d7-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096532241.zip) * [ryujinx-Release-1.2.0+bb721d7-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096536737.zip) * [ryujinx-Release-1.2.0+bb721d7-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096541497.zip) * [ryujinx-Release-1.2.0+bb721d7-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096546407.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+bb721d7-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096532338.zip) * [sdl2-ryujinx-headless-Release-1.2.0+bb721d7-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096536874.zip) * [sdl2-ryujinx-headless-Release-1.2.0+bb721d7-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096541593.zip) * [sdl2-ryujinx-headless-Release-1.2.0+bb721d7-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096546493.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+bb721d7-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096532494.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+bb721d7-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096532612.zip) * [ryujinx-Debug-1.2.0+bb721d7-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096539272.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+bb721d7-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096539372.zip) * [ryujinx-Debug-1.2.0+bb721d7-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096543537.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+bb721d7-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096543636.zip) * [ryujinx-Debug-1.2.0+bb721d7-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096548491.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+bb721d7-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2096548610.zip) </details>
GreemDev (Migrated from github.com) requested changes 2024-10-23 04:10:41 +00:00
GreemDev (Migrated from github.com) left a comment

Also what @MetrosexualGarbodor said.

Also what @MetrosexualGarbodor said.
GreemDev (Migrated from github.com) commented 2024-10-23 04:06:23 +00:00

Please fix the reference to version 52 here, it's not accurate

Please fix the reference to version 52 here, it's not accurate
Goodfeat (Migrated from github.com) reviewed 2024-10-23 09:35:51 +00:00
Goodfeat (Migrated from github.com) commented 2024-10-23 09:35:51 +00:00

I corrected the description, corrected the version from 52 to 55.

This is a hack, as it makes the emulator ignore intended functionality

as for this, yes it looks like a hack, although some games have internal dialogs when disconnecting the controller and when connecting the gamepad, the dialog box automatically closes (example game Teenage Mutant Ninja Turtles: Shredder's Revenge). This is essentially ignoring only the external window, but not the game window. I can move the setting from the system -> hacks section, if this is really considered a hack, and not a patch (after all, many settings in the emulator are to some extent a hack)

I corrected the description, corrected the version from 52 to 55. > This is a hack, as it makes the emulator ignore intended functionality as for this, yes it looks like a hack, although some games have internal dialogs when disconnecting the controller and when connecting the gamepad, the dialog box automatically closes (example game Teenage Mutant Ninja Turtles: Shredder's Revenge). This is essentially ignoring only the external window, but not the game window. I can move the setting from the system -> hacks section, if this is really considered a hack, and not a patch (after all, many settings in the emulator are to some extent a hack)
GreemDev (Migrated from github.com) reviewed 2024-10-23 10:14:54 +00:00
GreemDev (Migrated from github.com) commented 2024-10-23 10:14:54 +00:00

I corrected the description, corrected the version from 52 to 55.

This is a hack, as it makes the emulator ignore intended functionality

as for this, yes it looks like a hack, although some games have internal dialogs when disconnecting the controller and when connecting the gamepad, the dialog box automatically closes (example game Teenage Mutant Ninja Turtles: Shredder's Revenge). This is essentially ignoring only the external window, but not the game window. I can move the setting from the system -> hacks section, if this is really considered a hack, and not a patch (after all, many settings in the emulator are to some extent a hack)

Yes, please move it to the hacks section.

> I corrected the description, corrected the version from 52 to 55. > > > This is a hack, as it makes the emulator ignore intended functionality > > as for this, yes it looks like a hack, although some games have internal dialogs when disconnecting the controller and when connecting the gamepad, the dialog box automatically closes (example game Teenage Mutant Ninja Turtles: Shredder's Revenge). This is essentially ignoring only the external window, but not the game window. I can move the setting from the system -> hacks section, if this is really considered a hack, and not a patch (after all, many settings in the emulator are to some extent a hack) Yes, please move it to the hacks section.
Goodfeat commented 2024-10-23 10:38:35 +00:00 (Migrated from github.com)

If Greem really intends to merge this, at the very least it should be moved under "Hacks" in the UI.

image

if necessary and there is an additional request, then the applet setting can be moved to this section, besides, it looks organic here

> If Greem really intends to merge this, at the very least it should be moved under "Hacks" in the UI. ![image](https://github.com/user-attachments/assets/a8c5aec1-7201-4eee-b06d-99537d1130ba) if necessary and there is an additional request, then the applet setting can be moved to this section, besides, it looks organic here
Goodfeat (Migrated from github.com) reviewed 2024-10-23 11:24:36 +00:00
Goodfeat (Migrated from github.com) commented 2024-10-23 11:24:36 +00:00

ok i moved it to the hacks section

ok i moved it to the hacks section
Goodfeat commented 2024-10-23 22:11:32 +00:00 (Migrated from github.com)

Hi, I tested this on games and the setup doesn't cause any problems. Please tell me if this setup will be merged with the main branch?

Hi, I tested this on games and the setup doesn't cause any problems. Please tell me if this setup will be merged with the main branch?
GreemDev (Migrated from github.com) approved these changes 2024-10-23 23:46:33 +00:00
VeraPhobia commented 2024-10-24 15:28:59 +00:00 (Migrated from github.com)

hi i just updated and i think there is one thing missing

Screenshot 2024-10-24 185748

this option doesn't have this context menu like this. while it is an extremely small issue i thought it was worth mentioning

edit, thank you all for the great work by the way

hi i just updated and i think there is one thing missing ![Screenshot 2024-10-24 185748](https://github.com/user-attachments/assets/50af16f8-661b-4963-8a91-7af03eaa072b) this option doesn't have this context menu like this. while it is an extremely small issue i thought it was worth mentioning edit, thank you all for the great work by the way
Goodfeat commented 2024-10-24 23:19:03 +00:00 (Migrated from github.com)

this option doesn't have this context menu like this.

I will try to add a description to the context menu, but it will be problematic to translate into some languages. Translations may be incorrect and need spelling checks from the outside

> this option doesn't have this context menu like this. I will try to add a description to the context menu, but it will be problematic to translate into some languages. Translations may be incorrect and need spelling checks from the outside
Goodfeat commented 2024-10-25 11:20:24 +00:00 (Migrated from github.com)

How about this description?
image

How about this description? ![image](https://github.com/user-attachments/assets/4a17b09a-847e-44f0-a6d8-4066503a62ce)
VeraPhobia commented 2024-10-25 11:23:15 +00:00 (Migrated from github.com)

i think its perfect. thank you for the great work

i hope it will be approved

edit: in the sake of consistency with other context menus how about adding ( leave OFF if unsure )?

i think its perfect. thank you for the great work i hope it will be approved edit: in the sake of consistency with other context menus how about adding ( leave OFF if unsure )?
Goodfeat commented 2024-10-25 11:35:33 +00:00 (Migrated from github.com)

Я думаю, это идеально. Спасибо за прекрасную работу.
I'm already in the process of translation, where the translator will give a controversial translation, I will leave English

> Я думаю, это идеально. Спасибо за прекрасную работу. I'm already in the process of translation, where the translator will give a controversial translation, I will leave English
Sign in to join this conversation.
No description provided.