MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

ensure gamepads connect automatically to first player without controller #405

Closed
jphautin wants to merge 1 commits from feat/add-gamepads-auto-connect into master
pull from: feat/add-gamepads-auto-connect
merge into: MeloNX:master
Conversation 2 Commits 1 Files Changed 4 +103 -5
jphautin commented 2024-12-19 20:26:00 +00:00 (Migrated from github.com)
Copy Link

This PR aims to manage better controller connection/disconnection.

The aim is to update the the input view when the gamepad is connected or disconnected accordingly.
and to map new gamepad connected to first player without any controller setup.

Also take into account some steamOS specific behavior (remove Steam virtual pad from list of available gamepads).

This PR aims to manage better controller connection/disconnection. The aim is to update the the input view when the gamepad is connected or disconnected accordingly. and to map new gamepad connected to first player without any controller setup. Also take into account some steamOS specific behavior (remove Steam virtual pad from list of available gamepads).
❤️ 1
github-actions[bot] commented 2024-12-19 20:46:51 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+ddbfc7f-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345453424.zip) * [ryujinx-Release-1.2.0+ddbfc7f-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345453512.zip) * [ryujinx-Release-1.2.0+ddbfc7f-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345460603.zip) * [ryujinx-Release-1.2.0+ddbfc7f-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345460814.zip) * [ryujinx-Release-1.2.0+ddbfc7f-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345467102.zip) * [ryujinx-Release-1.2.0+ddbfc7f-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345478995.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+ddbfc7f-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345453634.zip) * [nogui-ryujinx-Release-1.2.0+ddbfc7f-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345461003.zip) * [nogui-ryujinx-Release-1.2.0+ddbfc7f-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345467234.zip) * [nogui-ryujinx-Release-1.2.0+ddbfc7f-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345479189.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+ddbfc7f-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345455007.zip) * [ryujinx-Debug-1.2.0+ddbfc7f-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345455116.zip) * [nogui-ryujinx-Debug-1.2.0+ddbfc7f-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345455616.zip) * [ryujinx-Debug-1.2.0+ddbfc7f-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345462627.zip) * [ryujinx-Debug-1.2.0+ddbfc7f-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345462731.zip) * [nogui-ryujinx-Debug-1.2.0+ddbfc7f-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345462911.zip) * [ryujinx-Debug-1.2.0+ddbfc7f-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345467442.zip) * [nogui-ryujinx-Debug-1.2.0+ddbfc7f-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345467574.zip) * [ryujinx-Debug-1.2.0+ddbfc7f-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345479957.zip) * [nogui-ryujinx-Debug-1.2.0+ddbfc7f-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2345480217.zip) </details>
GreemDev (Migrated from github.com) requested changes 2024-12-20 01:51:14 +00:00
GreemDev (Migrated from github.com) left a comment
Copy Link

Additionally, there's differing levels of indentation in places, such as in LinkDevicesToPlayers.
Each level of indentation should be equivalent to 4 spaces.

Additionally, there's differing levels of indentation in places, such as in LinkDevicesToPlayers. Each level of indentation should be equivalent to 4 spaces.
src/Ryujinx.Input/HLE/InputManager.cs
@ -44,0 +56,4 @@
availableDevices.Remove(steamDeckPad.Value);
}
}
}
GreemDev (Migrated from github.com) commented 2024-12-20 01:47:01 +00:00
Copy Link

RemoveSdpWhenExternalPadsConnected

`RemoveSdpWhenExternalPadsConnected`
src/Ryujinx.Input/HLE/InputManager.cs
@ -44,0 +68,4 @@
private void LinkDevicesToPlayers(List<InputConfig> _inputConfig) {
var _availableDevices = getGamepadsDescriptions();
removeSDPWhenExternalPadsConnected(_availableDevices);
GreemDev (Migrated from github.com) commented 2024-12-20 01:46:41 +00:00
Copy Link

GetGamepadsDescriptions

`GetGamepadsDescriptions`
src/Ryujinx/UI/ViewModels/Input/InputViewModel.cs
GreemDev (Migrated from github.com) commented 2024-12-20 01:49:04 +00:00
Copy Link

Please apply proper spacing.

Please apply proper spacing.
src/Ryujinx/UI/ViewModels/Input/InputViewModel.cs
GreemDev (Migrated from github.com) commented 2024-12-20 01:49:14 +00:00
Copy Link

Here too

Here too

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
GreemDev
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#405
No description provided.
Delete Branch "feat/add-gamepads-auto-connect"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?