MeloNX/Ryujinx-ryubing
11
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Automatically remove invalid dlc and updates as part of auto load #42

Merged
amurgshere merged 2 commits from auto-load-remove-missing-updates-and-dlc-files into master 2024-10-27 11:32:32 +00:00
Conversation 6 Commits 2 Files Changed 9 +109 -44
amurgshere commented 2024-10-23 14:14:09 +00:00 (Migrated from github.com)
Copy Link

Automatically remove missing dlc files and update files as part of auto load and notify user of missing items
Fixed some minor label spacing issues in options dialog
Removal of unused variable in input view model

Automatically remove missing dlc files and update files as part of auto load and notify user of missing items Fixed some minor label spacing issues in options dialog Removal of unused variable in input view model
GreemDev (Migrated from github.com) requested changes 2024-10-23 14:18:09 +00:00
src/Ryujinx/Assets/Locales/fr_FR.json
@ -736,3 +737,4 @@
"AutoloadUpdateRemovedMessage": "{0} mises à jour manquantes supprimées",
"ModWindowHeading": "{0} Mod(s)",
"UserProfilesEditProfile": "Éditer la sélection",
"Cancel": "Annuler",
GreemDev (Migrated from github.com) commented 2024-10-23 14:17:19 +00:00
Copy Link

I think this was removed by mistake? Or was it kept by mistake in the other locale file?

I think this was removed by mistake? Or was it kept by mistake in the other locale file?
amurgshere (Migrated from github.com) reviewed 2024-10-23 14:27:01 +00:00
src/Ryujinx/Assets/Locales/fr_FR.json
@ -736,3 +737,4 @@
"AutoloadUpdateRemovedMessage": "{0} mises à jour manquantes supprimées",
"ModWindowHeading": "{0} Mod(s)",
"UserProfilesEditProfile": "Éditer la sélection",
"Cancel": "Annuler",
amurgshere (Migrated from github.com) commented 2024-10-23 14:27:01 +00:00
Copy Link

Hey @GreemDev,

Great pick up! Would you believe I checked these code changes 3 times before committing LOL

I have reinstated this message now, apologies for missing this.

Thank You.

Hey @GreemDev, Great pick up! Would you believe I checked these code changes 3 times before committing LOL I have reinstated this message now, apologies for missing this. Thank You.
github-actions[bot] commented 2024-10-23 14:38:38 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less (SDL2)
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+9e4eff9-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094037802.zip) * [ryujinx-Release-1.2.0+9e4eff9-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094048098.zip) * [ryujinx-Release-1.2.0+9e4eff9-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094056608.zip) * [ryujinx-Release-1.2.0+9e4eff9-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094072293.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+9e4eff9-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094038027.zip) * [sdl2-ryujinx-headless-Release-1.2.0+9e4eff9-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094048342.zip) * [sdl2-ryujinx-headless-Release-1.2.0+9e4eff9-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094056793.zip) * [sdl2-ryujinx-headless-Release-1.2.0+9e4eff9-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094072596.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+9e4eff9-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094038491.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+9e4eff9-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094038855.zip) * [ryujinx-Debug-1.2.0+9e4eff9-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094051830.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+9e4eff9-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094052074.zip) * [ryujinx-Debug-1.2.0+9e4eff9-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094059918.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+9e4eff9-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094060133.zip) * [ryujinx-Debug-1.2.0+9e4eff9-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094073362.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+9e4eff9-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094073583.zip) </details>
GreemDev (Migrated from github.com) approved these changes 2024-10-23 14:39:57 +00:00
gh0sti commented 2024-10-25 13:17:19 +00:00 (Migrated from github.com)
Copy Link

@amurgshere how would you handle situations where the user would want to use an older update of the game as an example a bug to exploit for speed running?

@amurgshere how would you handle situations where the user would want to use an older update of the game as an example a bug to exploit for speed running?
amurgshere commented 2024-10-25 13:23:30 +00:00 (Migrated from github.com)
Copy Link

Hey @gh0sti ,

Just a note, I did not implement the original solution to auto select the updates and DLCs, I only improved it a little and fixed some minor issues. But the original author already thought of this scenario, the currently selected update will be retained as long as no new updates are found for that game / app, only if a new update is found for that game / app and it has a newer version then the currently selected one will it then switch to that one automatically, and if the user adds a new update to the folder with a later version then it would be implied that they want to update to it, if they don’t then they can always switch to the older one again, apart from this it should retain the older version being selected.

Also note that the user can choose not to configure any search folders for updates / DLCs and choose not to use this functionality at all if they want.

Let me know if you find it working differently to this.

Cheers.

Hey @gh0sti , Just a note, I did not implement the original solution to auto select the updates and DLCs, I only improved it a little and fixed some minor issues. But the original author already thought of this scenario, the currently selected update will be retained as long as no new updates are found for that game / app, only if a new update is found for that game / app and it has a newer version then the currently selected one will it then switch to that one automatically, and if the user adds a new update to the folder with a later version then it would be implied that they want to update to it, if they don’t then they can always switch to the older one again, apart from this it should retain the older version being selected. Also note that the user can choose not to configure any search folders for updates / DLCs and choose not to use this functionality at all if they want. Let me know if you find it working differently to this. Cheers.
Sign in to join this conversation.
Reviewers
No Reviewers
GreemDev
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0-Blu Fen Lonkelle Propenchieferr Stern bella jkcoxson june ny spidy123222 stossy11
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#42
No description provided.
Delete Branch "auto-load-remove-missing-updates-and-dlc-files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?