MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Do not initialize unnecessarily #426

Closed
marco-carvalho wants to merge 1 commits from CA1805 into master
pull from: CA1805
merge into: MeloNX:master
Conversation 2 Commits 1 Files Changed 72 +153 -153
marco-carvalho commented 2024-12-22 13:26:45 +00:00 (Migrated from github.com)
Copy Link
No description provided.
github-actions[bot] commented 2024-12-22 13:35:27 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+918500d-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353396128.zip) * [ryujinx-Release-1.2.0+918500d-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353396156.zip) * [ryujinx-Release-1.2.0+918500d-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353397579.zip) * [ryujinx-Release-1.2.0+918500d-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353397610.zip) * [ryujinx-Release-1.2.0+918500d-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353399464.zip) * [ryujinx-Release-1.2.0+918500d-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353401697.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+918500d-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353396205.zip) * [nogui-ryujinx-Release-1.2.0+918500d-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353397648.zip) * [nogui-ryujinx-Release-1.2.0+918500d-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353399502.zip) * [nogui-ryujinx-Release-1.2.0+918500d-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353401767.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+918500d-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353396153.zip) * [ryujinx-Debug-1.2.0+918500d-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353396218.zip) * [nogui-ryujinx-Debug-1.2.0+918500d-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353396275.zip) * [ryujinx-Debug-1.2.0+918500d-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353398135.zip) * [ryujinx-Debug-1.2.0+918500d-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353398177.zip) * [nogui-ryujinx-Debug-1.2.0+918500d-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353398234.zip) * [ryujinx-Debug-1.2.0+918500d-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353400223.zip) * [nogui-ryujinx-Debug-1.2.0+918500d-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353400287.zip) * [ryujinx-Debug-1.2.0+918500d-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353402153.zip) * [nogui-ryujinx-Debug-1.2.0+918500d-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2353402229.zip) </details>
GreemDev (Migrated from github.com) requested changes 2024-12-22 17:54:09 +00:00
GreemDev (Migrated from github.com) left a comment
Copy Link

Please add warning suppressions in the places with them.
A lot of them don't need to be fixed, since them never changing their value is mostly due to behavior that doesn't exist.

For example the _accumulatedSuspendedTickValue field in Ryujinx.HLE/HOS/Services/Am/AppletAE/AllSystemAppletProxiesService/SystemAppletProxy/ISelfController.cs; this value is used (I think) for calculating how long the guest application has been suspended for when the user hits the home button to return to QLaunch (Switch Home Screen). We don't support QLaunch and likely never will, thus this value will likely always stay at 0.
We could inline usages to remove traces of something we don't support, but I'd rather leave it as is so if someone with a desire to see QLaunch working, they can add it in and take advantage of the fact that we already partially have the code made in a way that makes it easier.

Please add warning suppressions in the places with them. A lot of them don't need to be fixed, since them never changing their value is mostly due to behavior that doesn't exist. > For example the `_accumulatedSuspendedTickValue` field in `Ryujinx.HLE/HOS/Services/Am/AppletAE/AllSystemAppletProxiesService/SystemAppletProxy/ISelfController.cs`; this value is used (I think) for calculating how long the guest application has been suspended for when the user hits the home button to return to QLaunch (Switch Home Screen). We don't support QLaunch and likely never will, thus this value will likely always stay at 0. We could inline usages to remove traces of something we don't support, but I'd rather leave it as is so if someone with a desire to see QLaunch working, they can add it in and take advantage of the fact that we already partially have the code made in a way that makes it easier.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
GreemDev
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
cpu
gpu
graphics-backend:opengl
graphics-backend:vulkan
gui
horizon
ldn
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#426
No description provided.
Delete Branch "CA1805"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?