MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Set "EnforceCodeStyleInBuild" to "true" #453

Closed
marco-carvalho wants to merge 1 commits from patch-1 into master
pull from: patch-1
merge into: MeloNX:master
Conversation 4 Commits 1 Files Changed 1 +1
marco-carvalho commented 2024-12-27 14:17:58 +00:00 (Migrated from github.com)
Copy Link
No description provided.
github-actions[bot] commented 2025-01-05 01:00:34 +00:00 (Migrated from github.com)
Copy Link

You need to be logged into GitHub to download these files.

Download the artifacts for this pull request:

Only for Developers
*You need to be logged into GitHub to download these files.* Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+22abc52-linux_arm64](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386549112) * [ryujinx-Release-1.2.0+22abc52-linux_arm64-AppImage](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386549138) * [ryujinx-Release-1.2.0+22abc52-linux_x64](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386550829) * [ryujinx-Release-1.2.0+22abc52-linux_x64-AppImage](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386550882) * [ryujinx-Release-1.2.0+22abc52-macos_universal](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386551517) * [ryujinx-Release-1.2.0+22abc52-win_x64](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386554361) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+22abc52-linux_arm64](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386549221) * [ryujinx-Debug-1.2.0+22abc52-linux_arm64-AppImage](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386549267) * [ryujinx-Debug-1.2.0+22abc52-macos_universal](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386551503) * [ryujinx-Debug-1.2.0+22abc52-linux_x64](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386551643) * [ryujinx-Debug-1.2.0+22abc52-linux_x64-AppImage](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386551671) * [ryujinx-Debug-1.2.0+22abc52-win_x64](https://github.com/Ryubing/Ryujinx/actions/runs/12615125255/artifacts/2386555258) </details>
GreemDev commented 2025-01-17 23:27:40 +00:00 (Migrated from github.com)
Copy Link

Based on the .NET docs it seems like this is just integrated dotnet format, which we don't bother with anyways. I don't see a reason to merge this really

[Based on the .NET docs](https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#enforcecodestyleinbuild) it seems like this is just integrated `dotnet format`, which we don't bother with anyways. I don't see a reason to merge this really
marco-carvalho commented 2025-01-18 00:59:37 +00:00 (Migrated from github.com)
Copy Link

It ensures that code style rules are enforced consistently across the entire project, preventing style-related discrepancies from reaching the repository. Its integration into the build process guarantees that code style violations are caught automatically during builds, providing immediate feedback to developers. This approach reduces the overhead of manual formatting checks, aligns with maintaining consistent code, and integrates seamlessly into CI/CD pipelines. Enforcing code style at build time fosters a culture of quality and consistency without relying on separate tools or workflows, ultimately saving time and reducing friction in code reviews.

It ensures that code style rules are enforced consistently across the entire project, preventing style-related discrepancies from reaching the repository. Its integration into the build process guarantees that code style violations are caught automatically during builds, providing immediate feedback to developers. This approach reduces the overhead of manual formatting checks, aligns with maintaining consistent code, and integrates seamlessly into CI/CD pipelines. Enforcing code style at build time fosters a culture of quality and consistency without relying on separate tools or workflows, ultimately saving time and reducing friction in code reviews.
GreemDev commented 2025-01-18 01:02:02 +00:00 (Migrated from github.com)
Copy Link

It ensures that code style rules are enforced consistently across the entire project, preventing style-related discrepancies from reaching the repository. Its integration into the build process guarantees that code style violations are caught automatically during builds, providing immediate feedback to developers. This approach reduces the overhead of manual formatting checks, aligns with maintaining consistent code, and integrates seamlessly into CI/CD pipelines. Enforcing code style at build time fosters a culture of quality and consistency without relying on separate tools or workflows, ultimately saving time and reducing friction in code reviews.

please don't reply with AI generated nonsense, it's entirely unhelpful

> It ensures that code style rules are enforced consistently across the entire project, preventing style-related discrepancies from reaching the repository. Its integration into the build process guarantees that code style violations are caught automatically during builds, providing immediate feedback to developers. This approach reduces the overhead of manual formatting checks, aligns with maintaining consistent code, and integrates seamlessly into CI/CD pipelines. Enforcing code style at build time fosters a culture of quality and consistency without relying on separate tools or workflows, ultimately saving time and reducing friction in code reviews. please don't reply with AI generated nonsense, it's entirely unhelpful

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#453
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?