MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

WIP: Selective Barriers & Feedback Loops change #496

Closed
GreemDev wants to merge 12 commits from feature/vk/selective-barriers into master
pull from: feature/vk/selective-barriers
merge into: MeloNX:master
Conversation 2 Commits 12 Files Changed 138 +38443 -526
GreemDev commented 2025-01-06 05:36:13 +00:00 (Migrated from github.com)
Copy Link

Selectively applies the Feedback loop detection and barriers commit based on whether or not the preferred GPU is an RDNA3 card.

This implementation is, frankly, fucking stupid.
It's literally just a duplicate of the Vulkan project.
The normal one is pre commit, RDNA3 one is post-commit.
The only thing that's done different depending on the GPU is which Vulkan implementation to initialize.

To test, ensure there's no visual regressions on RDNA3 cards.
And also see if the performance in Paper Mario: The Thousand Year Door and some of the Xenoblade games is fixed.

Selectively applies the [Feedback loop detection and barriers](https://github.com/Ryubing/Ryujinx/commit/ca59c3f4998e2d1beb3b0d0214611e3332238557) commit based on whether or not the preferred GPU is an RDNA3 card. This implementation is, frankly, fucking stupid. It's literally just a duplicate of the Vulkan project. The normal one is pre commit, RDNA3 one is post-commit. The only thing that's done different depending on the GPU is which Vulkan implementation to initialize. To test, ensure there's no visual regressions on RDNA3 cards. And also see if the performance in Paper Mario: The Thousand Year Door and some of the Xenoblade games is fixed.
🚀 1
github-actions[bot] commented 2025-01-06 05:51:13 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+d817487-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389071126.zip) * [ryujinx-Release-1.2.0+d817487-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389071243.zip) * [ryujinx-Release-1.2.0+d817487-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389074839.zip) * [ryujinx-Release-1.2.0+d817487-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389074913.zip) * [ryujinx-Release-1.2.0+d817487-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389076217.zip) * [ryujinx-Release-1.2.0+d817487-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389083970.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+d817487-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389071208.zip) * [ryujinx-Debug-1.2.0+d817487-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389071282.zip) * [ryujinx-Debug-1.2.0+d817487-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389076549.zip) * [ryujinx-Debug-1.2.0+d817487-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389076594.zip) * [ryujinx-Debug-1.2.0+d817487-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389076675.zip) * [ryujinx-Debug-1.2.0+d817487-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2389084711.zip) </details>
GreemDev commented 2025-01-13 18:30:04 +00:00 (Migrated from github.com)
Copy Link

I opened this basically just to test; it's so bad I could never merge it.

I opened this basically just to test; it's so bad I could never merge it.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gpu
graphics-backend:vulkan
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#496
No description provided.
Delete Branch "feature/vk/selective-barriers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?