MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

cores rework #505

Merged
LotP1 merged 7 commits from threading into master 2025-01-10 03:43:18 +00:00
Conversation 1 Commits 7 Files Changed 10 +35 -19
LotP1 commented 2025-01-09 01:00:27 +00:00 (Migrated from github.com)
Copy Link

This PR changes the core count to be defined in the device instead of being a const value.
This is mostly a change for future features I want to implement and should not impact any functionality.
The console will now log the range of cores requested from the application, and for now, if the requested range is not 0 to 2 (the 3 cores used for application emulation), it will give an error message which tells the user to contact me on discord. I'm doing this because I'm interested in finding applications/games that don't use 3 cores and the error will be removed in the future once I've gotten enough data.

This PR changes the core count to be defined in the device instead of being a const value. This is mostly a change for future features I want to implement and should not impact any functionality. The console will now log the range of cores requested from the application, and for now, if the requested range is not 0 to 2 (the 3 cores used for application emulation), it will give an error message which tells the user to contact me on discord. I'm doing this because I'm interested in finding applications/games that don't use 3 cores and the error will be removed in the future once I've gotten enough data.
👍 1
github-actions[bot] commented 2025-01-09 01:09:57 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+a61e507-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410927388.zip) * [ryujinx-Release-1.2.0+a61e507-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410927480.zip) * [ryujinx-Release-1.2.0+a61e507-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410930475.zip) * [ryujinx-Release-1.2.0+a61e507-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410930527.zip) * [ryujinx-Release-1.2.0+a61e507-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410930691.zip) * [ryujinx-Release-1.2.0+a61e507-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410938796.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+a61e507-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410927300.zip) * [ryujinx-Debug-1.2.0+a61e507-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410927385.zip) * [ryujinx-Debug-1.2.0+a61e507-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410931068.zip) * [ryujinx-Debug-1.2.0+a61e507-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410931545.zip) * [ryujinx-Debug-1.2.0+a61e507-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410931605.zip) * [ryujinx-Debug-1.2.0+a61e507-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2410941194.zip) </details>
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
horizon
kernel
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#505
No description provided.
Delete Branch "threading"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?