MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Add the player select applet. #537

Merged
Jacobwasbeast merged 10 commits from feature-playerSelect into master 2025-01-19 02:40:33 +00:00
Conversation 4 Commits 10 Files Changed 10 +376 -8
Jacobwasbeast commented 2025-01-18 23:37:30 +00:00 (Migrated from github.com)
Copy Link

This introduces the somewhat completed version of the Player Select Applet, allowing users to select either a user or a guest from the UI. Note: Selecting the guest more then once currently does not work.

closes https://github.com/Ryubing/Ryujinx/issues/532

This introduces the somewhat completed version of the Player Select Applet, allowing users to select either a user or a guest from the UI. Note: Selecting the guest more then once currently does not work. closes https://github.com/Ryubing/Ryujinx/issues/532
GreemDev (Migrated from github.com) reviewed 2025-01-18 23:55:05 +00:00
src/Ryujinx/UI/Applet/AvaHostUIHandler.cs
GreemDev (Migrated from github.com) commented 2025-01-18 23:53:39 +00:00
Copy Link

ObservableCollection<BaseModel> profiles = [];

`ObservableCollection<BaseModel> profiles = [];`
GreemDev (Migrated from github.com) commented 2025-01-18 23:53:53 +00:00
Copy Link

NavigationDialogHost nav = new();

`NavigationDialogHost nav = new();`
GreemDev (Migrated from github.com) commented 2025-01-18 23:54:15 +00:00
Copy Link

UserSelectorDialog content = new(profiles);

`UserSelectorDialog content = new(profiles);`
src/Ryujinx/UI/Applet/UserSelectorDialog.axaml.cs
GreemDev (Migrated from github.com) commented 2025-01-18 23:54:45 +00:00
Copy Link

Same suggestion here as the other observable collection

Same suggestion here as the other observable collection
github-actions[bot] commented 2025-01-19 00:14:22 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+65961b9-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451894426.zip) * [ryujinx-Release-1.2.0+65961b9-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451894482.zip) * [ryujinx-Release-1.2.0+65961b9-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451895135.zip) * [ryujinx-Release-1.2.0+65961b9-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451895172.zip) * [ryujinx-Release-1.2.0+65961b9-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451896680.zip) * [ryujinx-Release-1.2.0+65961b9-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451899171.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+65961b9-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451893468.zip) * [ryujinx-Debug-1.2.0+65961b9-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451893517.zip) * [ryujinx-Debug-1.2.0+65961b9-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451895625.zip) * [ryujinx-Debug-1.2.0+65961b9-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451895820.zip) * [ryujinx-Debug-1.2.0+65961b9-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451895866.zip) * [ryujinx-Debug-1.2.0+65961b9-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2451899820.zip) </details>
GreemDev (Migrated from github.com) requested changes 2025-01-19 00:23:18 +00:00
src/Ryujinx/UI/Applet/UserSelectorDialog.axaml.cs
GreemDev (Migrated from github.com) commented 2025-01-19 00:21:52 +00:00
Copy Link

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev (Migrated from github.com) commented 2025-01-19 00:22:00 +00:00
Copy Link

Identical to above

Identical to above
GreemDev (Migrated from github.com) commented 2025-01-19 00:23:14 +00:00
Copy Link

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev (Migrated from github.com) approved these changes 2025-01-19 01:43:34 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
GreemDev
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
horizon
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#537
No description provided.
Delete Branch "feature-playerSelect"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?