MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Log .NET runtime version #552

Merged
mattzink merged 2 commits from runtime-ver into master 2025-01-21 01:19:19 +00:00
Conversation 3 Commits 2 Files Changed 1 +1
mattzink commented 2025-01-21 00:51:07 +00:00 (Migrated from github.com)
Copy Link

I was looking into a crash, and found out it was an issue that was fixed in .NET 9.0.1. Since Ryujinx embeds the runtime into the executable, it not obvious which runtime a build uses. This logs the .NET runtime version immediately after the build version.

I was looking into a crash, and found out it was an issue that was fixed in .NET 9.0.1. Since Ryujinx embeds the runtime into the executable, it not obvious which runtime a build uses. This logs the .NET runtime version immediately after the build version.
GreemDev commented 2025-01-21 00:57:05 +00:00 (Migrated from github.com)
Copy Link

I don't feel this is necessary.
The contents of the repo already describe the version of .NET, and it doesn't change often.
You also can easily look at the contents of a repo as of a tag and look at the global.json file to see what version of .NET it uses, if you're using an older version and don't know what version of .NET it's on.

I don't feel this is necessary. The contents of the repo already describe the version of .NET, and it doesn't change often. You also can easily look at the contents of a repo as of a tag and look at the global.json file to see what version of .NET it uses, if you're using an older version and don't know what version of .NET it's on.
mattzink commented 2025-01-21 01:00:16 +00:00 (Migrated from github.com)
Copy Link

The global.json sets the minimum required SDK version. The issue I was tracking wasn't reproducible after I compiled because I had a newer SDK locally.

The global.json sets the _minimum_ required SDK version. The issue I was tracking wasn't reproducible after I compiled because I had a newer SDK locally.
mattzink commented 2025-01-21 01:17:24 +00:00 (Migrated from github.com)
Copy Link

I just double-checked and since there is a roll-forward policy set in the global.json and the build is using the setup-dotnet github action, then the latest 9.x.x version of the SDK will be selected/used automatically during each build. There is nothing therefore that tells someone which runtime version was embedded in a specific build.

I just double-checked and since there is a roll-forward policy set in the global.json and the build is using the setup-dotnet github action, then the latest 9.x.x version of the SDK will be selected/used automatically during each build. There is nothing therefore that tells someone which runtime version was embedded in a specific build.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#552
No description provided.
Delete Branch "runtime-ver"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?