MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

[Bug]Controller settings are not saved #687

New Issue
Open
opened 2025-02-18 14:42:28 +00:00 by kusanagi0 · 13 comments
kusanagi0 commented 2025-02-18 14:42:28 +00:00 (Migrated from github.com)
Copy Link

Description of the issue

Input settings are disabled every time you launch the application with Ver 1.2.82
It's inconvenient because you can't use the controller unless you load the profile and reset the settings each time.

Reproduction steps

Check input settings when launching the application.

Log file

Ryujinx_1.2.82_2025-02-18_23-39-39.log

OS

Window11

Ryujinx version

1.2.82

Game version

1.0.1

CPU

i7-13620

GPU

NVIDIA RTX4060

RAM

64GB

List of applied mods

No response

Additional context?

No response

### Description of the issue Input settings are disabled every time you launch the application with Ver 1.2.82 It's inconvenient because you can't use the controller unless you load the profile and reset the settings each time. ### Reproduction steps Check input settings when launching the application. ### Log file [Ryujinx_1.2.82_2025-02-18_23-39-39.log](https://github.com/user-attachments/files/18846968/Ryujinx_1.2.82_2025-02-18_23-39-39.log) ### OS Window11 ### Ryujinx version 1.2.82 ### Game version 1.0.1 ### CPU i7-13620 ### GPU NVIDIA RTX4060 ### RAM 64GB ### List of applied mods _No response_ ### Additional context? _No response_
jvrcruzGAMES commented 2025-02-18 15:31:12 +00:00 (Migrated from github.com)
Copy Link

You need to configure the controller everytime you launch Ryujinx, I find it repetitive, but since they changed how the controller connects to the emulator/game, they would need to revert something

You need to configure the controller everytime you launch Ryujinx, I find it repetitive, but since they changed how the controller connects to the emulator/game, they would need to revert something
williansti commented 2025-02-18 22:12:10 +00:00 (Migrated from github.com)
Copy Link

I'm facing this problem with Xbox controllers when used wirelessly (Bluetooth), but when used with a cable it doesn't present this problem, this has been reported and exhaustively discussed here #577

This continuity fork of ryujinx is great, but this problem of not saving the settings on some controllers and also on certain types of connection, comes from the original code of the emulator, certainly the SDL needs to be completely revised.

Unfortunately we will have to live with this inconvenience until a contributor with SDL experience helps this project.

I'm facing this problem with Xbox controllers when used wirelessly (Bluetooth), but when used with a cable it doesn't present this problem, this has been reported and exhaustively discussed here #577 This continuity fork of ryujinx is great, but this problem of not saving the settings on some controllers and also on certain types of connection, comes from the original code of the emulator, certainly the SDL needs to be completely revised. Unfortunately we will have to live with this inconvenience until a contributor with SDL experience helps this project.
aloon818 commented 2025-02-18 22:37:21 +00:00 (Migrated from github.com)
Copy Link

i have the same problem, is there any fix?

i have the same problem, is there any fix?
williansti commented 2025-02-18 22:42:49 +00:00 (Migrated from github.com)
Copy Link

i have the same problem, is there any fix?

There is an attempt to fix it here #686 , test the artifact and report the result there, it didn't work for me.

> i have the same problem, is there any fix? There is an attempt to fix it here #686 , test the artifact and report the result there, it didn't work for me.
kusanagi0 commented 2025-02-19 00:10:06 +00:00 (Migrated from github.com)
Copy Link

i have the same problem, is there any fix?

There is an attempt to fix it here #686 , test the artifact and report the result there, it didn't work for me.

Thank you for the various answers.
As you said, I'm using an xbox controller wirelessly.
In my environment, this problem did not occur until 1.2.81.
I thought the new update had something to do with it, but I'm surprised that it seems to have been happening for quite some time.

> > i have the same problem, is there any fix? > > There is an attempt to fix it here [#686](https://github.com/Ryubing/Ryujinx/pull/686) , test the artifact and report the result there, it didn't work for me. Thank you for the various answers. As you said, I'm using an xbox controller wirelessly. In my environment, this problem did not occur until 1.2.81. I thought the new update had something to do with it, but I'm surprised that it seems to have been happening for quite some time.
williansti commented 2025-02-19 00:16:45 +00:00 (Migrated from github.com)
Copy Link

@kusanagi0 Unfortunately this is a problem that has been around for a long time, the problem is that many people lived with this and did not report it, I tried to test it even on the old ryujinx 1.1.1402 that was discontinued, and guess what? the same problem happened.

The SDL in this emulator needs to be revised, it behaves strangely for some types of controls and connection types, I hope that one day some dev will implement xinput as an option.

@kusanagi0 Unfortunately this is a problem that has been around for a long time, the problem is that many people lived with this and did not report it, I tried to test it even on the old ryujinx 1.1.1402 that was discontinued, and guess what? the same problem happened. The SDL in this emulator needs to be revised, it behaves strangely for some types of controls and connection types, I hope that one day some dev will implement xinput as an option.
GreemDev commented 2025-02-19 00:17:27 +00:00 (Migrated from github.com)
Copy Link

We're not adding xinput.

**We're not adding xinput.**
👀 1
williansti commented 2025-02-19 00:18:57 +00:00 (Migrated from github.com)
Copy Link

@GreemDev You bad guy, don't let us dream lol (I'm joking)

@GreemDev You bad guy, don't let us dream lol (I'm joking)
Tartifless commented 2025-03-04 16:37:57 +00:00 (Migrated from github.com)
Copy Link

It's a true problem, i created a similar bug, this is related to the guid Ryujinx is using in the config.json file.

Everytime you run ryujinx, the guid changes, i guess ryujinx uses a wrong guid to store in config file.

Every other emulators have a fix guid, that persists upon application restart. Ryujinx does not, which is the issue.
This definitely needs to be fixed.

Many emulators do not consider the crc part of the controller when saving/using guid, they replace this part with 0000, which is an easy fix for that.

It's a true problem, i created a similar bug, this is related to the guid Ryujinx is using in the config.json file. Everytime you run ryujinx, the guid changes, i guess ryujinx uses a wrong guid to store in config file. Every other emulators have a fix guid, that persists upon application restart. Ryujinx does not, which is the issue. This definitely needs to be fixed. Many emulators do not consider the crc part of the controller when saving/using guid, they replace this part with 0000, which is an easy fix for that.
Tartifless commented 2025-03-04 21:10:28 +00:00 (Migrated from github.com)
Copy Link

I've submitted a very simple PR for that, similar to what is done on other emulators to ignore the crc16 part of the guid and replace with guid, this way the guid is stable for a given controller (VID/PID/version).

Built and tested with Xbox One S, Xbox Series, XBOX360 and Xbox One controller, as well as multiple controllers to ensure the logic of adding the index before the guid works.

I've submitted a very simple PR for that, similar to what is done on other emulators to ignore the crc16 part of the guid and replace with guid, this way the guid is stable for a given controller (VID/PID/version). Built and tested with Xbox One S, Xbox Series, XBOX360 and Xbox One controller, as well as multiple controllers to ensure the logic of adding the index before the guid works.
Tartifless commented 2025-03-05 14:52:43 +00:00 (Migrated from github.com)
Copy Link

@kusanagi0 @williansti @jvrcruzGAMES : can you test the build with my changes and come back ?
https://drive.google.com/open?id=1VjZ9mH9WHHqZ3AzNYGu37XnqmHlzbUoQ&usp=drive_fs

@kusanagi0 @williansti @jvrcruzGAMES : can you test the build with my changes and come back ? https://drive.google.com/open?id=1VjZ9mH9WHHqZ3AzNYGu37XnqmHlzbUoQ&usp=drive_fs
👍 1
kusanagi0 commented 2025-03-05 15:28:58 +00:00 (Migrated from github.com)
Copy Link

Thank you for your help.
I immediately ran a test build and tried it out.
As a result, when I started the test build with the xbox controller connected wirelessly, configured the controller, restarted the app, and started the game as it was, the controller settings did not disappear.
I repeated this twice and it was fine.
The fix is ​​working fine.

Ryujinx_1.0.0-dirty+d19324f687ead760e7059fb0637a5c721f19b5f3_2025-03-06_00-16-09.log

thanks so much.

Thank you for your help. I immediately ran a test build and tried it out. As a result, when I started the test build with the xbox controller connected wirelessly, configured the controller, restarted the app, and started the game as it was, the controller settings did not disappear. I repeated this twice and it was fine. The fix is ​​working fine. [Ryujinx_1.0.0-dirty+d19324f687ead760e7059fb0637a5c721f19b5f3_2025-03-06_00-16-09.log](https://github.com/user-attachments/files/19091823/Ryujinx_1.0.0-dirty%2Bd19324f687ead760e7059fb0637a5c721f19b5f3_2025-03-06_00-16-09.log) thanks so much.
👍 1
Tartifless commented 2025-03-05 15:50:28 +00:00 (Migrated from github.com)
Copy Link

Perfect, thanks for the testing, i have now tested with:

  • Switch pro controller (bluetooth)
  • 8BitDo Pro2 in both switch pro and xinput mode (bluetooth)
  • 8BitDo pro2 (usb)
  • 8bitdo sn30 pro in both switch pro and xinput mode (bluetooth)
  • 8bitdo sn30 pro (usb)
  • Wired version of 8BitDo pro2 (recognized as Xbox360)
  • Wired version of 8Bitdo SN30 (recognized as Xbox360)
  • XBox Series (bluetooth and usb)
  • Xbox One S (bluetooth and usb)
  • Xbox One (usb - i do not own the microsoft receiver)
  • Xbox 360 (usb)
  • Dualsense (bluetooth)
  • PS4 controller (bluetooth)
  • 8BitDo M30 (bluetooth and usb) ==> not ideal due to button layout)
  • 8BitDo Ultimate C (in 2.4 and bluetooth modes)

All are working fine and save configuration. I do not own additionnal controllers to test...

Perfect, thanks for the testing, i have now tested with: - Switch pro controller (bluetooth) - 8BitDo Pro2 in both switch pro and xinput mode (bluetooth) - 8BitDo pro2 (usb) - 8bitdo sn30 pro in both switch pro and xinput mode (bluetooth) - 8bitdo sn30 pro (usb) - Wired version of 8BitDo pro2 (recognized as Xbox360) - Wired version of 8Bitdo SN30 (recognized as Xbox360) - XBox Series (bluetooth and usb) - Xbox One S (bluetooth and usb) - Xbox One (usb - i do not own the microsoft receiver) - Xbox 360 (usb) - Dualsense (bluetooth) - PS4 controller (bluetooth) - 8BitDo M30 (bluetooth and usb) ==> not ideal due to button layout) - 8BitDo Ultimate C (in 2.4 and bluetooth modes) All are working fine and save configuration. I do not own additionnal controllers to test...
👍 2
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#687
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?