Change default custom refresh rate value from 200% to 100% #691

2025-02-19T23:04:09Z

KeatonTheBot commented

2025-02-19 23:04:09 +00:00

(Migrated from github.com)

This changes the default custom refresh rate value from 200% to 100%. Config will migrate from v67 to v68.

GreemDev commented

2025-02-19 23:05:04 +00:00

(Migrated from github.com)

Why? This is identical to just using normal VSync, it makes much more sense to swap to VSync on then to make the custom refresh rate pointless

KeatonTheBot commented

2025-02-19 23:10:39 +00:00

(Migrated from github.com)

Why? This is identical to just using normal VSync, it makes much more sense to swap to VSync on then to make the custom refresh rate pointless

I think 100% should be the base value for the custom refresh rate. You can always increase it from there. With many games, if you enable it and leave it at 200%, the game will run at 2x speed. Depends on the engine, of course, but setting it to the default VSync value will minimize potential issues.

> Why? This is identical to just using normal VSync, it makes much more sense to swap to VSync on then to make the custom refresh rate pointless I think 100% should be the base value for the custom refresh rate. You can always increase it from there. With many games, if you enable it and leave it at 200%, the game will run at 2x speed. Depends on the engine, of course, but setting it to the default VSync value will minimize potential issues.

GreemDev commented

2025-02-19 23:13:14 +00:00

(Migrated from github.com)

Why? This is identical to just using normal VSync, it makes much more sense to swap to VSync on then to make the custom refresh rate pointless

I think 100% should be the base value for the custom refresh rate. You can always increase it from there. With many games, if you enable it and leave it at 200%, the game will run at 2x speed. Depends on the engine, of course, but setting it to the default VSync value will minimize potential issues.

Well yes but this is the entire point. It's in the hack section after all. If people enable it and get issues that's kinda on them for enabling something in the "hacks" section that has a note that it can cause issues

> > Why? This is identical to just using normal VSync, it makes much more sense to swap to VSync on then to make the custom refresh rate pointless > > I think 100% should be the base value for the custom refresh rate. You can always increase it from there. With many games, if you enable it and leave it at 200%, the game will run at 2x speed. Depends on the engine, of course, but setting it to the default VSync value will minimize potential issues. Well yes but this is the entire point. It's in the hack section after all. If people enable it and get issues that's kinda on them for enabling something in the "hacks" section that has a note that it can cause issues

GreemDev commented

2025-02-19 23:14:41 +00:00

(Migrated from github.com)

I just feel like this change doesn't make much sense for 2 reasons:

you need custom refresh rate enabled to change it, and
if you do enable it, you need to go out of your way to then make it actually custom, instead of just VSync enabled with a different name

I just feel like this change doesn't make much sense for 2 reasons: - you need custom refresh rate enabled to change it, and - if you do enable it, you need to go out of your way to then make it actually custom, instead of just VSync enabled with a different name

github-actions[bot] commented

2025-02-19 23:18:47 +00:00

(Migrated from github.com)

Download the artifacts for this pull request:

Only for Developers

Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+ff4f34a-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2619952077.zip) * [ryujinx-Release-1.2.0+ff4f34a-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2619952196.zip) * [ryujinx-Release-1.2.0+ff4f34a-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2619958983.zip) * [ryujinx-Release-1.2.0+ff4f34a-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2619961728.zip) * [ryujinx-Release-1.2.0+ff4f34a-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2619961835.zip) * [ryujinx-Release-1.2.0+ff4f34a-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2619973704.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+ff4f34a-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2619952615.zip) * [ryujinx-Debug-1.2.0+ff4f34a-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2619952865.zip) * [ryujinx-Debug-1.2.0+ff4f34a-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2619961165.zip) * [ryujinx-Debug-1.2.0+ff4f34a-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2619961280.zip) * [ryujinx-Debug-1.2.0+ff4f34a-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2619975840.zip) * [ryujinx-Debug-1.2.0+ff4f34a-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2620003307.zip) </details>

KeatonTheBot commented

2025-02-19 23:21:19 +00:00

(Migrated from github.com)

I just feel like this change doesn't make much sense for 2 reasons:

you need custom refresh rate enabled to change it, and

if you do enable it, you need to go out of your way to then make it actually custom, instead of just VSync enabled with a different name

Understandable, just thought it would be cleaner. Do you think a value between 100% and 200% would make more sense?

> I just feel like this change doesn't make much sense for 2 reasons: > > * you need custom refresh rate enabled to change it, and > * if you do enable it, you need to go out of your way to then make it actually custom, instead of just VSync enabled with a different name Understandable, just thought it would be cleaner. Do you think a value between 100% and 200% would make more sense?

GreemDev commented

2025-02-19 23:26:31 +00:00

(Migrated from github.com)

I honestly think 200 makes perfect sense. Most of the games are 30 base and 60 is desirable.

This option is very niche as is; and only really grants a benefit in a specific case:
The game you are playing is not FPS-sensitive. Either it was made that way, or has a mod to make it that way.

When it comes to games like that, 200% base makes sense, since you can use VSync for 30, custom refresh rate for 60-120, and VSync off to just let it rip.
Leaving custom refresh rate at 100% default seems odd since the entire point of the setting is that it's custom and is a way to achieve a framerate target you couldn't previously without directly modding the game to request a specific refresh rate target.

I honestly think 200 makes perfect sense. Most of the games are 30 base and 60 is desirable. This option is very niche as is; and only really grants a benefit in a specific case: The game you are playing is not FPS-sensitive. Either it was made that way, or has a mod to make it that way. When it comes to games like that, 200% base makes sense, since you can use VSync for 30, custom refresh rate for 60-120, and VSync off to just let it rip. Leaving custom refresh rate at 100% default seems odd since the entire point of the setting is that it's *custom* and is a way to achieve a framerate target you couldn't previously without directly modding the game to request a specific refresh rate target.

KeatonTheBot commented

2025-02-19 23:32:35 +00:00

(Migrated from github.com)

I honestly think 200 makes perfect sense. Most of the games are 30 base and 60 is desirable.

This option is very niche as is; and only really grants a benefit in a specific case: The game you are playing is not FPS-sensitive. Either it was made that way, or has a mod to make it that way.

When it comes to games like that, 200% base makes sense, since you can use VSync for 30, custom refresh rate for 60-120, and VSync off to just let it rip. Leaving custom refresh rate at 100% default seems odd since the entire point of the setting is that it's custom and is a way to achieve a framerate target you couldn't previously without directly modding the game to request a specific refresh rate target.

I see what you mean. I also made this change in my fork, but you made some really good points. Closing the PR.

> I honestly think 200 makes perfect sense. Most of the games are 30 base and 60 is desirable. > > This option is very niche as is; and only really grants a benefit in a specific case: The game you are playing is not FPS-sensitive. Either it was made that way, or has a mod to make it that way. > > When it comes to games like that, 200% base makes sense, since you can use VSync for 30, custom refresh rate for 60-120, and VSync off to just let it rip. Leaving custom refresh rate at 100% default seems odd since the entire point of the setting is that it's _custom_ and is a way to achieve a framerate target you couldn't previously without directly modding the game to request a specific refresh rate target. I see what you mean. I also made this change in my fork, but you made some really good points. Closing the PR.

👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#691