MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

WIP: Improved interaction with "Input" settings. #705

Closed
Goodfeat wants to merge 7 commits from Master_PR into master
pull from: Master_PR
merge into: MeloNX:master
Conversation 1 Commits 7 Files Changed 8 +329 -39
Goodfeat commented 2025-02-22 12:38:56 +00:00 (Migrated from github.com)
Copy Link

I made some fixes to the settings input section.

Changes and fixes:

  • Paired devices have notifications that they are configured and require connection
  • Paired devices load the configuration when connected
  • A notification appears when changing control configuration settings.
  • Now control settings will be saved only when they are changed
  • Added a button to roll back changes to the previous saved state
  • Fixed a bug: when switching the "player", if the "input device" and "controller type" settings were changed, the save dialog box did not appear.
  • "Motion", "Rumble" and "Led" also have events notifying about changes

https://github.com/user-attachments/assets/e760b4bd-15a3-49da-a395-0beb64301548

Please note: the current pull request does not solve the problem with connecting the gamepad after rebooting the emulator! There is a separate topic for this

.

I made some fixes to the settings input section. Changes and fixes: - Paired devices have notifications that they are configured and require connection - Paired devices load the configuration when connected - A notification appears when changing control configuration settings. - Now control settings will be saved only when they are changed - Added a button to roll back changes to the previous saved state - Fixed a bug: when switching the "player", if the "input device" and "controller type" settings were changed, the save dialog box did not appear. - "Motion", "Rumble" and "Led" also have events notifying about changes https://github.com/user-attachments/assets/e760b4bd-15a3-49da-a395-0beb64301548 **Please note: the current pull request does not solve the problem with connecting the gamepad after rebooting the emulator! There is a separate topic for this** .
github-actions[bot] commented 2025-02-22 12:47:16 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+589f273-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635002863.zip) * [ryujinx-Release-1.2.0+589f273-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635002896.zip) * [ryujinx-Release-1.2.0+589f273-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635004812.zip) * [ryujinx-Release-1.2.0+589f273-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635004851.zip) * [ryujinx-Release-1.2.0+589f273-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635006041.zip) * [ryujinx-Release-1.2.0+589f273-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635009161.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+589f273-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635003163.zip) * [ryujinx-Debug-1.2.0+589f273-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635003227.zip) * [ryujinx-Debug-1.2.0+589f273-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635005709.zip) * [ryujinx-Debug-1.2.0+589f273-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635005749.zip) * [ryujinx-Debug-1.2.0+589f273-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635005999.zip) * [ryujinx-Debug-1.2.0+589f273-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2635011347.zip) </details>

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#705
No description provided.
Delete Branch "Master_PR"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?