MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Jit regions fix #709

Merged
LotP1 merged 2 commits from jit-regions-fix into master 2025-02-25 21:34:21 +00:00
Conversation 4 Commits 2 Files Changed 3 +56 -29
LotP1 commented 2025-02-23 00:56:25 +00:00 (Migrated from github.com)
Copy Link

Jit cache now fully resets when booting a game multiple times.
This should fix random jit cache crashes.
Also removed some redundant code related to region allocation and fixed PPTC Purge not fully purging all PPTC files in the backup folder.

Jit cache now fully resets when booting a game multiple times. This should fix random jit cache crashes. Also removed some redundant code related to region allocation and fixed PPTC Purge not fully purging all PPTC files in the backup folder.
👍 1
github-actions[bot] commented 2025-02-23 01:04:47 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+40296ac-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636044280.zip) * [ryujinx-Release-1.2.0+40296ac-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636044319.zip) * [ryujinx-Release-1.2.0+40296ac-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636045683.zip) * [ryujinx-Release-1.2.0+40296ac-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636045754.zip) * [ryujinx-Release-1.2.0+40296ac-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636046707.zip) * [ryujinx-Release-1.2.0+40296ac-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636050422.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+40296ac-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636044444.zip) * [ryujinx-Debug-1.2.0+40296ac-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636044524.zip) * [ryujinx-Debug-1.2.0+40296ac-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636046577.zip) * [ryujinx-Debug-1.2.0+40296ac-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636046631.zip) * [ryujinx-Debug-1.2.0+40296ac-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636047052.zip) * [ryujinx-Debug-1.2.0+40296ac-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2636051729.zip) </details>
FluffyOMC commented 2025-02-23 01:06:12 +00:00 (Migrated from github.com)
Copy Link

Works on my test. Gets to

00:00:27.379 |I| GPU.MainThread Gpu LoadShaders: Shader cache loaded.
00:00:28.074 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 0 exhausted, creating new Cache Region 1 (512 MB Total Allocation).
00:00:29.021 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 1 exhausted, creating new Cache Region 2 (768 MB Total Allocation).
00:00:30.312 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 2 exhausted, creating new Cache Region 3 (1 GB Total Allocation).
00:00:32.049 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 3 exhausted, creating new Cache Region 4 (1.25 GB Total Allocation).
00:00:32.101 |I| HLE.GuestThread.46 Ptc LoadTranslations: 165126 translated functions loaded

Both tries without crashing.

Works on my test. Gets to ``` 00:00:27.379 |I| GPU.MainThread Gpu LoadShaders: Shader cache loaded. 00:00:28.074 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 0 exhausted, creating new Cache Region 1 (512 MB Total Allocation). 00:00:29.021 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 1 exhausted, creating new Cache Region 2 (768 MB Total Allocation). 00:00:30.312 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 2 exhausted, creating new Cache Region 3 (1 GB Total Allocation). 00:00:32.049 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 3 exhausted, creating new Cache Region 4 (1.25 GB Total Allocation). 00:00:32.101 |I| HLE.GuestThread.46 Ptc LoadTranslations: 165126 translated functions loaded ``` Both tries without crashing.
Goodfeat commented 2025-02-23 07:58:55 +00:00 (Migrated from github.com)
Copy Link

I'm not sure if it's a coincidence. But now if I launch the Mario and Luigi Brothership game, after stopping and restarting the game, the emulator no longer crashes.

It's just a problematic game, I decided to test it on it.
I tested it a couple dozen times. I cleaned the ppts for all test emulators, and only this build doesn't crash

P.S. No, it's not a coincidence. After launching Mario and Luigi Brothership, on the previous version of the emulator after stopping the game and restarting it on any other game, the emulator crashed with an error. This build works well

I'm not sure if it's a coincidence. But now if I launch the Mario and Luigi Brothership game, after stopping and restarting the game, the emulator no longer crashes. It's just a problematic game, I decided to test it on it. I tested it a couple dozen times. I cleaned the ppts for all test emulators, and only this build doesn't crash P.S. No, it's not a coincidence. After launching Mario and Luigi Brothership, on the previous version of the emulator after stopping the game and restarting it on any other game, the emulator crashed with an error. This build works well
FluffyOMC commented 2025-02-23 08:45:31 +00:00 (Migrated from github.com)
Copy Link

I'm not sure if it's a coincidence. But now if I launch the Mario and Luigi Brothership game, after stopping and restarting the game, the emulator no longer crashes.

It's just a problematic game, I decided to test it on it.
I tested it a couple dozen times. I cleaned the ppts for all test emulators, and only this build doesn't crash

P.S. No, it's not a coincidence. After launching Mario and Luigi Brothership, on the previous version of the emulator after stopping the game and restarting it on any other game, the emulator crashed with an error. This build works well

Yeah, it's on purpose heh. This PR was entirely built because I noticed SSBU kept crashing with relaunches.

> I'm not sure if it's a coincidence. But now if I launch the Mario and Luigi Brothership game, after stopping and restarting the game, the emulator no longer crashes. > > It's just a problematic game, I decided to test it on it. > I tested it a couple dozen times. I cleaned the ppts for all test emulators, and only this build doesn't crash > > P.S. No, it's not a coincidence. After launching Mario and Luigi Brothership, on the previous version of the emulator after stopping the game and restarting it on any other game, the emulator crashed with an error. This build works well Yeah, it's on purpose heh. This PR was entirely built because I noticed SSBU kept crashing with relaunches.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
cpu
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#709
No description provided.
Delete Branch "jit-regions-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?