[Bug] Press and hold behavior regarding cheats #724

New Issue

2025-02-26T01:40:05Z

styper commented

2025-02-26 01:40:05 +00:00

(Migrated from github.com)

Description of the issue

Any cheats that require a press and hold behavior in a button do not work.

This is an example in Pokémon Sword:

[03# Instakill (Hold ZR)]
04000000 007E37F0 7900E808
80000200
04000000 007E37F0 7900E81F
20000000

The cheat starts with the default value, and if you press and hold 80000200, which is the code for ZR, then it should modify the behavior of the execution, in this case it the hit that lands during the press and hold will be a one hit kill.

If you set just this part in the cheat (always activated, no button hold needed):

[03# Instakill (Hold ZR)]
04000000 007E37F0 7900E81F

It works fine, but since the cheat also affects opponents hits it needs a button modifier.

Cheats that work with single press of a button instead of press and hold work fine in the same game, which leads me to believe that there is an issue with how press and hold works in Ryujinx.

For reference, I tested with both an XBox controller and with a keyboard.

Reproduction steps

Load up Pokémon Sword.
Load up the instant kill cheat.
Test the behavior with the button pressed.
Nothing happens.

Log file

n/a

OS

Windows 10

Ryujinx version

1.2.82

Game version

1.3.2

CPU

No response

GPU

No response

RAM

No response

List of applied mods

No response

Additional context?

No response

### Description of the issue Any cheats that require a press and hold behavior in a button do not work. This is an example in Pokémon Sword: ``` [03# Instakill (Hold ZR)] 04000000 007E37F0 7900E808 80000200 04000000 007E37F0 7900E81F 20000000 ``` The cheat starts with the default value, and if you press and hold 80000200, which is the code for ZR, then it should modify the behavior of the execution, in this case it the hit that lands during the press and hold will be a one hit kill. If you set just this part in the cheat (always activated, no button hold needed): ``` [03# Instakill (Hold ZR)] 04000000 007E37F0 7900E81F ``` It works fine, but since the cheat also affects opponents hits it needs a button modifier. Cheats that work with single press of a button instead of press and hold work fine in the same game, which leads me to believe that there is an issue with how press and hold works in Ryujinx. For reference, I tested with both an XBox controller and with a keyboard. ### Reproduction steps Load up Pokémon Sword. Load up the instant kill cheat. Test the behavior with the button pressed. Nothing happens. ### Log file n/a ### OS Windows 10 ### Ryujinx version 1.2.82 ### Game version 1.3.2 ### CPU _No response_ ### GPU _No response_ ### RAM _No response_ ### List of applied mods _No response_ ### Additional context? _No response_

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#724