MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

[Feature Request] Full HD Rumble Support #757

New Issue
Open
opened 2025-03-10 19:39:18 +00:00 by FIM43-Redeye · 2 comments
FIM43-Redeye commented 2025-03-10 19:39:18 +00:00 (Migrated from github.com)
Copy Link

Overview

The Switch Pro Controller and Joy-Cons both support HD Rumble, which can do some wonderful things. (Kirby Star Allies spoiler) I just tested and this absolutely does not work with my Pro Controller. Peeking at the code seems to confirm that there's only high and low, even for Nintendo controllers.

Smaller details

This library already seems to be doing the legwork for getting data to and from Nintendo controllers. I'm willing to do the programming legwork on my end, but I'm extremely incapable with Git and don't feel comfortable submitting a pull request yet.

Nature of request

Implement direct passthrough to send HD Rumble data directly to a supported controller instead of sublimating it into 'strong' and 'weak'.

Why would this feature be useful?

HD Rumble is used in a number of Switch games (including Luigi's Mansion 3, much more of Star Allies, Hollow Knight, Okami, Super Mario Party, and Super Mario Odyssey).

### Overview The Switch Pro Controller and Joy-Cons both support HD Rumble, which can do some [wonderful things.](https://www.youtube.com/watch?v=VDe0-8rO6hs) (Kirby Star Allies spoiler) I just tested and this absolutely does not work with my Pro Controller. Peeking at the code seems to confirm that there's only high and low, even for Nintendo controllers. ### Smaller details [This library](https://github.com/MIZUSHIKI/JoyShockLibrary-plus-HDRumble) already seems to be doing the legwork for getting data to and from Nintendo controllers. I'm willing to do the programming legwork on my end, but I'm extremely incapable with Git and don't feel comfortable submitting a pull request yet. ### Nature of request Implement direct passthrough to send HD Rumble data directly to a supported controller instead of sublimating it into 'strong' and 'weak'. ### Why would this feature be useful? HD Rumble is used in a number of Switch games (including Luigi's Mansion 3, much more of Star Allies, Hollow Knight, Okami, Super Mario Party, and Super Mario Odyssey).
👀 1 ❤️ 1
GreemDev commented 2025-03-10 19:46:23 +00:00 (Migrated from github.com)
Copy Link

I'm gonna be honest this entire time I thought the low and high rumble settings was HD Rumble lol

Feel free to PR it but this is gonna be a bit of a pain; what you linked is a C++ library which is gonna require library importing & providing native binaries for each OS (which we do not have the ability to do, only Windows and Linux).
And that's if the library even provides support for those platforms. I only see Windows code.

Probably would be better to wait until SDL3 for this, I think that has HD Rumble support.

I'm not going to work on this; I don't care about rumble, and frankly the last thing I want to do is sit for hours testing slight differences in how my controller can annoy the hell out of me.

I'm gonna be honest this entire time I thought the low and high rumble settings *was* HD Rumble lol Feel free to PR it but this is gonna be a bit of a pain; what you linked is a C++ library which is gonna require library importing & providing native binaries for each OS (which we do not have the ability to do, only Windows and Linux). And that's if the library even provides support for those platforms. I only see Windows code. Probably would be better to wait until SDL3 for this, I think that has HD Rumble support. I'm not going to work on this; I don't care about rumble, and frankly the last thing I want to do is sit for hours testing slight differences in how my controller can annoy the hell out of me.
FIM43-Redeye commented 2025-03-10 19:49:07 +00:00 (Migrated from github.com)
Copy Link

Gonna be honest, I was just gonna read what the library did and implement it myself in Ryujinx's code

I'll see what I can do, I don't blame you for not wanting to work on this. If SDL3's planned I'll wait, if not I'll start working on it

Gonna be honest, I was just gonna read what the library did and implement it myself in Ryujinx's code I'll see what I can do, I don't blame you for not wanting to work on this. If SDL3's planned I'll wait, if not I'll start working on it
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#757
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?