From 335012d91ca05e4b6e3b7080eb57dd596495b686 Mon Sep 17 00:00:00 2001
From: qurious-pixel <62252937+qurious-pixel@users.noreply.github.com>
Date: Mon, 21 Oct 2024 13:38:32 -0700
Subject: [PATCH 1/5] Remove white space checks for now

---
 .github/workflows/checks.yml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
index 2bef2d8e0..e39344483 100644
--- a/.github/workflows/checks.yml
+++ b/.github/workflows/checks.yml
@@ -39,9 +39,10 @@ jobs:
       - name: Print dotnet format version
         run: dotnet format --version
 
-      - name: Run dotnet format whitespace
-        run: |
-          dotnet format whitespace --verify-no-changes --report ./whitespace-report.json -v d
+      # Pause for now. Fix errors with style and analyzers first
+      #- name: Run dotnet format whitespace
+      #  run: |
+      #    dotnet format whitespace --verify-no-changes --report ./whitespace-report.json -v d
 
       # For some unknown reason this step sometimes fails with exit code 139 (segfault?),
       # so in that case we'll try again (3 tries max).
-- 
2.47.1


From d3282a47b250ba8c061569d43564eaaccc1aec82 Mon Sep 17 00:00:00 2001
From: qurious-pixel <62252937+qurious-pixel@users.noreply.github.com>
Date: Mon, 21 Oct 2024 13:40:17 -0700
Subject: [PATCH 2/5] info IDE0059

Unnecessary assignment of a value to 'error'
---
 src/Ryujinx.UI.Common/Helper/SetupValidator.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Ryujinx.UI.Common/Helper/SetupValidator.cs b/src/Ryujinx.UI.Common/Helper/SetupValidator.cs
index 5e2d3a584..0fdebed00 100644
--- a/src/Ryujinx.UI.Common/Helper/SetupValidator.cs
+++ b/src/Ryujinx.UI.Common/Helper/SetupValidator.cs
@@ -98,7 +98,7 @@ namespace Ryujinx.UI.Common.Helper
                 if (baseApplicationExtension is not (".nro" or ".nso"))
                     return IsFirmwareValid(contentManager, out error);
 
-                error = UserError.Success;
+                // error = UserError.Success;
             }
 
             error = UserError.ApplicationNotFound;
-- 
2.47.1


From 8a76468f2495ad989f7a782dcb4674eb0b66ac45 Mon Sep 17 00:00:00 2001
From: qurious-pixel <62252937+qurious-pixel@users.noreply.github.com>
Date: Mon, 21 Oct 2024 13:41:33 -0700
Subject: [PATCH 3/5] info IDE0044

Make field readonly
---
 src/Ryujinx/UI/ViewModels/Input/InputViewModel.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Ryujinx/UI/ViewModels/Input/InputViewModel.cs b/src/Ryujinx/UI/ViewModels/Input/InputViewModel.cs
index 2cad8aeca..3fb991531 100644
--- a/src/Ryujinx/UI/ViewModels/Input/InputViewModel.cs
+++ b/src/Ryujinx/UI/ViewModels/Input/InputViewModel.cs
@@ -45,7 +45,7 @@ namespace Ryujinx.Ava.UI.ViewModels.Input
 
         private PlayerIndex _playerId;
         private int _controller;
-        private int _controllerNumber;
+        private readonly int _controllerNumber;
         private string _controllerImage;
         private int _device;
         private object _configViewModel;
-- 
2.47.1


From c1ace5c5e1fbb59ce181371e1b3f024384c93aed Mon Sep 17 00:00:00 2001
From: qurious-pixel <62252937+qurious-pixel@users.noreply.github.com>
Date: Mon, 21 Oct 2024 13:45:46 -0700
Subject: [PATCH 4/5] Fix import ordering

---
 src/Ryujinx.Common/Hash128.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Ryujinx.Common/Hash128.cs b/src/Ryujinx.Common/Hash128.cs
index 69ab9f76e..d147c9b37 100644
--- a/src/Ryujinx.Common/Hash128.cs
+++ b/src/Ryujinx.Common/Hash128.cs
@@ -4,8 +4,8 @@ using System.Diagnostics;
 using System.Numerics;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using System.Runtime.Intrinsics.X86;
 using System.Runtime.Intrinsics;
+using System.Runtime.Intrinsics.X86;
 // ReSharper disable InconsistentNaming
 
 namespace Ryujinx.Common
-- 
2.47.1


From 116fe1d57783f27cea70d6e40c32d02f0a35282a Mon Sep 17 00:00:00 2001
From: qurious-pixel <62252937+qurious-pixel@users.noreply.github.com>
Date: Tue, 22 Oct 2024 02:51:26 -0700
Subject: [PATCH 5/5] info IDE0059

---
 src/Ryujinx.UI.Common/Helper/SetupValidator.cs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/Ryujinx.UI.Common/Helper/SetupValidator.cs b/src/Ryujinx.UI.Common/Helper/SetupValidator.cs
index 0fdebed00..8fac2600e 100644
--- a/src/Ryujinx.UI.Common/Helper/SetupValidator.cs
+++ b/src/Ryujinx.UI.Common/Helper/SetupValidator.cs
@@ -98,12 +98,14 @@ namespace Ryujinx.UI.Common.Helper
                 if (baseApplicationExtension is not (".nro" or ".nso"))
                     return IsFirmwareValid(contentManager, out error);
 
-                // error = UserError.Success;
+                error = UserError.Success;
+
+                return true;
             }
 
             error = UserError.ApplicationNotFound;
 
-            return error is UserError.Success;
+            return false;
         }
     }
 }
-- 
2.47.1