Unified locales #391

Merged
LotP1 merged 25 commits from unified-locales into master 2024-12-20 19:27:11 +00:00
2 changed files with 11 additions and 5 deletions
Showing only changes of commit 9588123f53 - Show all commits

View File

@ -14,10 +14,16 @@ namespace Ryujinx.BuildValidationTasks
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
{ {
string path = System.Reflection.Assembly.GetExecutingAssembly().Location; string path = System.Reflection.Assembly.GetExecutingAssembly().Location;
path = path.Split(new string[] { "src" }, StringSplitOptions.None)[0]; if (path.Split(new string[] { "src" }, StringSplitOptions.None).Length == 1 )
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
{
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
//i assume that we are in a build directory in the solution dir
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
path = new FileInfo(path).Directory.GetDirectories("src")[0].GetDirectories("Ryujinx")[0].GetDirectories("Assets")[0].GetFiles("locales.json")[0].FullName; path = new FileInfo(path).Directory.Parent.GetDirectories("src")[0].GetDirectories("Ryujinx")[0].GetDirectories("Assets")[0].GetFiles("locales.json")[0].FullName;
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
}
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
else
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
{
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
path = path.Split(new string[] { "src" }, StringSplitOptions.None)[0];
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
path = new FileInfo(path).Directory.GetDirectories("src")[0].GetDirectories("Ryujinx")[0].GetDirectories("Assets")[0].GetFiles("locales.json")[0].FullName;
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
}
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
string data; string data;

WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`

View File

@ -11,7 +11,7 @@
<PackageReference Include="Newtonsoft.Json" /> <PackageReference Include="Newtonsoft.Json" />
</ItemGroup> </ItemGroup>
<UsingTask TaskName="Ryujinx.BuildValidationTasks.LocaleValidationTask" TaskFactory="TaskHostFactory" AssemblyFile="$(ProjectDir)bin\$(Configuration)\netstandard2.0\Ryujinx.BuildValidationTasks.dll" /> <UsingTask TaskName="Ryujinx.BuildValidationTasks.LocaleValidationTask" TaskFactory="TaskHostFactory" AssemblyFile="$(TargetDir)Ryujinx.BuildValidationTasks.dll" />
<Target Name="LocalesJsonValidation" AfterTargets="AfterBuild"> <Target Name="LocalesJsonValidation" AfterTargets="AfterBuild">
<LocaleValidationTask /> <LocaleValidationTask />