MeloNX/Ryujinx-ryubing
11
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Unified locales #391

Merged
LotP1 merged 25 commits from unified-locales into master 2024-12-20 19:27:11 +00:00
Conversation 6 Commits 25 Files Changed 28 +5 -2
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit efa1a26dbd - Show all commits

5
src/Ryujinx.BuildValidationTasks/LocaleValidationTask.cs
View File

@ -14,7 +14,10 @@ namespace Ryujinx.BuildValidationTasks
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review
Copy Link

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review
Copy Link

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
{
string path = System.Reflection.Assembly.GetExecutingAssembly().Location;
path = new FileInfo(path).Directory.Parent.Parent.Parent.Parent.GetDirectories("Ryujinx")[0].GetDirectories("Assets")[0].GetFiles("locales.json")[0].FullName;
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review
Copy Link

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
path = path.Split(new string[] { "src" }, StringSplitOptions.None)[0];
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review
Copy Link

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review
Copy Link

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review
Copy Link

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
path = new FileInfo(path).Directory.GetDirectories("src")[0].GetDirectories("Ryujinx")[0].GetDirectories("Assets")[0].GetFiles("locales.json")[0].FullName;
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review
Copy Link

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
string data;

WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review
Copy Link

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`
WilliamWsyHK commented 2024-12-18 13:51:48 +00:00 (Migrated from github.com)
Review
Copy Link

A minor comment: LocalesJSON -> LocalesJson

A minor comment: `LocalesJSON` -> `LocalesJson`

2
src/Ryujinx/Ryujinx.csproj
View File

@ -13,7 +13,7 @@
<DefaultItemExcludes>$(DefaultItemExcludes);._*</DefaultItemExcludes>
</PropertyGroup>
<UsingTask TaskName="Ryujinx.BuildValidationTasks.LocaleValidationTask" AssemblyFile="$(ProjectDir)..\Ryujinx.BuildValidationTasks\bin\debug\netstandard2.0\Ryujinx.BuildValidationTasks.dll" />
<UsingTask TaskName="Ryujinx.BuildValidationTasks.LocaleValidationTask" AssemblyFile="..\Ryujinx.BuildValidationTasks\bin\debug\netstandard2.0\Ryujinx.BuildValidationTasks.dll" />
<Target Name="LocalesJsonValidation" BeforeTargets="BeforeBuild">
<LocaleValidationTask />