MeloNX/Ryujinx-ryubing
11
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Add ability to trim XCI files from the application context menu #52

Closed
amurgshere wants to merge 2 commits from add-ability-to-trim-XCI-files-from-the-application-context-menu into master
pull from: add-ability-to-trim-XCI-files-from-the-application-context-menu
merge into: MeloNX:master
Conversation 4 Commits 2 Files Changed 9 +7 -27
1 changed files with 7 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6230cf368d - Show all commits

34
src/Ryujinx.Common/Utilities/XCIFileTrimmer.cs
View File

@ -1,4 +1,4 @@
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
using Ryujinx.Common.Logging;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
using Gommon;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
using System;
using System.Collections.Generic;
using System.Diagnostics;
@ -7,26 +7,6 @@ using System.Linq;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
namespace Ryujinx.Common.Utilities
{
internal static class Performance
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
internal static TimeSpan Measure(Action action)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
var sw = new Stopwatch();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
sw.Start();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
action();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
finally
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
sw.Stop();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return sw.Elapsed;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public sealed class XCIFileTrimmer
{
private const long BytesInAMegabyte = 1024 * 1024;
@ -178,14 +158,14 @@ namespace Ryujinx.Common.Utilities
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
bool freeSpaceValid = true;
long readSizeB = FileSizeB - TrimmedFileSizeB;
TimeSpan time = Performance.Measure(() =>
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Stopwatch timedSw = Lambda.Timed(() =>
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
freeSpaceValid = CheckPadding(readSizeB);
});
if (time.TotalSeconds > 0)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (timedSw.Elapsed.TotalSeconds > 0)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
Log?.Write(LogType.Info, $"Checked at {readSizeB / (double)XCIFileTrimmer.BytesInAMegabyte / time.TotalSeconds:N} Mb/sec");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Info, $"Checked at {readSizeB / (double)XCIFileTrimmer.BytesInAMegabyte / timedSw.Elapsed.TotalSeconds:N} Mb/sec");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
if (freeSpaceValid)
@ -352,14 +332,14 @@ namespace Ryujinx.Common.Utilities
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
{
TimeSpan time = Performance.Measure(() =>
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Stopwatch timedSw = Lambda.Timed(() =>
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
WritePadding(outfileStream, bytesToWriteB);
});
if (time.TotalSeconds > 0)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (timedSw.Elapsed.TotalSeconds > 0)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
Log?.Write(LogType.Info, $"Wrote at {bytesToWriteB / (double)XCIFileTrimmer.BytesInAMegabyte / time.TotalSeconds:N} Mb/sec");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Info, $"Wrote at {bytesToWriteB / (double)XCIFileTrimmer.BytesInAMegabyte / timedSw.Elapsed.TotalSeconds:N} Mb/sec");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
return OperationOutcome.Successful;

GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.