Add the player select applet. #537

Merged
Jacobwasbeast merged 10 commits from feature-playerSelect into master 2025-01-19 02:40:33 +00:00
Showing only changes of commit f01cfca9c7 - Show all commits

View File

@ -19,19 +19,31 @@ namespace Ryujinx.Ava.UI.Applet
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{ {
public partial class UserSelectorDialog : UserControl, INotifyPropertyChanged public partial class UserSelectorDialog : UserControl, INotifyPropertyChanged
{ {
public event PropertyChangedEventHandler PropertyChanged; public new event PropertyChangedEventHandler PropertyChanged;
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
private UserId _selectedUserId; private UserId _selectedUserId;
private ObservableCollection<BaseModel> _profiles;
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
public ObservableCollection<BaseModel> Profiles { get; set; } public ObservableCollection<BaseModel> Profiles
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
get => _profiles;
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
set
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
if (_profiles != value)
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
_profiles = value;
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
OnPropertyChanged();
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
}
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
}
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
}
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
public UserSelectorDialog(ObservableCollection<BaseModel> Profiles) public UserSelectorDialog(ObservableCollection<BaseModel> profiles)
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{ {
InitializeComponent(); InitializeComponent();
this.Profiles = Profiles; Profiles = profiles;
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
DataContext = this; DataContext = this;
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
} }
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = "") protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = "")
{ {
PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName)); PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
@ -39,7 +51,7 @@ namespace Ryujinx.Ava.UI.Applet
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
private void Grid_PointerEntered(object sender, PointerEventArgs e) private void Grid_PointerEntered(object sender, PointerEventArgs e)
{ {
if (sender is Grid grid && grid.DataContext is UserProfile profile) if (sender is Grid { DataContext: UserProfile profile })
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{ {
profile.IsPointerOver = true; profile.IsPointerOver = true;
} }
@ -47,7 +59,7 @@ namespace Ryujinx.Ava.UI.Applet
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
private void Grid_OnPointerExited(object sender, PointerEventArgs e) private void Grid_OnPointerExited(object sender, PointerEventArgs e)
{ {
if (sender is Grid grid && grid.DataContext is UserProfile profile) if (sender is Grid { DataContext: UserProfile profile })
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{ {
profile.IsPointerOver = false; profile.IsPointerOver = false;
} }
@ -65,31 +77,35 @@ namespace Ryujinx.Ava.UI.Applet
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{ {
_selectedUserId = userProfile.UserId; _selectedUserId = userProfile.UserId;
Logger.Info?.Print(LogClass.UI, $"Selected user: {userProfile.UserId}"); Logger.Info?.Print(LogClass.UI, $"Selected user: {userProfile.UserId}");
ObservableCollection<BaseModel> newProfiles = [];
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
var newProfiles = new ObservableCollection<BaseModel>();
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
foreach (var item in Profiles) foreach (var item in Profiles)
{ {
UserProfile originalItem = (UserProfile)item; if (item is UserProfile originalItem)
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
UserProfileSft profile = new (originalItem.UserId, originalItem.Name,
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
originalItem.Image);
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
if (profile.UserId == _selectedUserId)
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{ {
profile.AccountState = AccountState.Open; var profile = new UserProfileSft(originalItem.UserId, originalItem.Name, originalItem.Image);
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
if (profile.UserId == _selectedUserId)
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
profile.AccountState = AccountState.Open;
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
}
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
newProfiles.Add(new UserProfile(profile, new NavigationDialogHost()));
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
} }
newProfiles.Add(new UserProfile(profile, new NavigationDialogHost()));
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
} }
Profiles = newProfiles; Profiles = newProfiles;
OnPropertyChanged(nameof(Profiles));
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
} }
} }
} }
} }
public static async Task<(UserId id, bool result)> ShowInputDialog(UserSelectorDialog content, UserProfileSft accountManagerLastOpenedUser) public static async Task<(UserId Id, bool Result)> ShowInputDialog(UserSelectorDialog content, UserProfileSft accountManagerLastOpenedUser)
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{ {
content._selectedUserId = accountManagerLastOpenedUser.UserId; content._selectedUserId = accountManagerLastOpenedUser.UserId;
ContentDialog contentDialog = new()
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
var contentDialog = new ContentDialog
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{ {
Title = LocaleManager.Instance[LocaleKeys.UserProfileWindowTitle], Title = LocaleManager.Instance[LocaleKeys.UserProfileWindowTitle],
PrimaryButtonText = LocaleManager.Instance[LocaleKeys.Continue], PrimaryButtonText = LocaleManager.Instance[LocaleKeys.Continue],
@ -106,9 +122,11 @@ namespace Ryujinx.Ava.UI.Applet
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
{ {
if (eventArgs.Result == ContentDialogResult.Primary) if (eventArgs.Result == ContentDialogResult.Primary)
{ {
UserSelectorDialog view = (UserSelectorDialog)contentDialog.Content; if (contentDialog.Content is UserSelectorDialog view)
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
result = view?._selectedUserId ?? UserId.Null; {
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
input = true; result = view._selectedUserId;
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
input = true;
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
}
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
} }
else else
{ {

GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:21:52 +00:00 (Migrated from github.com)
Review

sender is Grid { DataContext: UserProfile profile }

`sender is Grid { DataContext: UserProfile profile }`
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:22:00 +00:00 (Migrated from github.com)
Review

Identical to above

Identical to above
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`
GreemDev commented 2025-01-19 00:23:14 +00:00 (Migrated from github.com)
Review

The value names in tuples should be PascalCase; Task<(UserId Id, bool Result)>

The value names in tuples should be PascalCase; `Task<(UserId Id, bool Result)>`