MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Added Tool for installing keys #233

Merged
nicola02nb merged 16 commits from master into master 2024-11-28 23:32:07 +00:00
Conversation 14 Commits 16 Files Changed 22 +479 -5
nicola02nb commented 2024-11-13 14:55:16 +00:00 (Migrated from github.com)
Copy Link

#232
image

#232 ![image](https://github.com/user-attachments/assets/5ae6118d-3857-4005-8392-5398c8fa91d5)
👍 2
github-actions[bot] commented 2024-11-14 01:49:13 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+7da8d9d-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234349194.zip) * [ryujinx-Release-1.2.0+7da8d9d-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234349337.zip) * [ryujinx-Release-1.2.0+7da8d9d-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234358327.zip) * [ryujinx-Release-1.2.0+7da8d9d-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234358483.zip) * [ryujinx-Release-1.2.0+7da8d9d-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234365775.zip) * [ryujinx-Release-1.2.0+7da8d9d-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234374992.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+7da8d9d-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234349513.zip) * [nogui-ryujinx-Release-1.2.0+7da8d9d-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234358709.zip) * [nogui-ryujinx-Release-1.2.0+7da8d9d-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234366061.zip) * [nogui-ryujinx-Release-1.2.0+7da8d9d-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234375366.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+7da8d9d-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234349367.zip) * [ryujinx-Debug-1.2.0+7da8d9d-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234349508.zip) * [nogui-ryujinx-Debug-1.2.0+7da8d9d-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234349696.zip) * [ryujinx-Debug-1.2.0+7da8d9d-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234361854.zip) * [ryujinx-Debug-1.2.0+7da8d9d-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234362002.zip) * [nogui-ryujinx-Debug-1.2.0+7da8d9d-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234362265.zip) * [ryujinx-Debug-1.2.0+7da8d9d-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234367459.zip) * [nogui-ryujinx-Debug-1.2.0+7da8d9d-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234367670.zip) * [ryujinx-Debug-1.2.0+7da8d9d-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234381145.zip) * [nogui-ryujinx-Debug-1.2.0+7da8d9d-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2234381482.zip) </details>
nicola02nb commented 2024-11-14 08:50:49 +00:00 (Migrated from github.com)
Copy Link

If you give a look to the code, I added two commented sections that may need to be implemented...

To set the correct directory where to save the keys:
4f5af0ecf3/src/Ryujinx.HLE/FileSystem/ContentManager.cs (L478-L486)

To check if the file content is correct:
4f5af0ecf3/src/Ryujinx/UI/ViewModels/MainWindowViewModel.cs (L1183-L1195)

If you give a look to the code, I added two commented sections that may need to be implemented... To set the correct directory where to save the keys: https://github.com/GreemDev/Ryujinx/blob/4f5af0ecf3f02b954682d02062c7765947e0a024/src/Ryujinx.HLE/FileSystem/ContentManager.cs#L478-L486 To check if the file content is correct: https://github.com/GreemDev/Ryujinx/blob/4f5af0ecf3f02b954682d02062c7765947e0a024/src/Ryujinx/UI/ViewModels/MainWindowViewModel.cs#L1183-L1195
GreemDev commented 2024-11-14 08:52:18 +00:00 (Migrated from github.com)
Copy Link

This PR will not be merged until everything that needs to be implemented is.

This PR will not be merged until everything that needs to be implemented is.
👍 1
nicola02nb commented 2024-11-14 10:56:58 +00:00 (Migrated from github.com)
Copy Link

Now it's all implemented, if you want to continue with the PR merge

Now it's all implemented, if you want to continue with the PR merge
GabCoolDude commented 2024-11-20 09:32:06 +00:00 (Migrated from github.com)
Copy Link

Please add the locales lines to all the other locale files and not only to en_US.json

Please add the locales lines to all the other locale files and not only to `en_US.json`
👍 1
nicola02nb commented 2024-11-20 10:37:32 +00:00 (Migrated from github.com)
Copy Link

Can I keep them in english?

Can I keep them in english?
GabCoolDude commented 2024-11-20 11:23:28 +00:00 (Migrated from github.com)
Copy Link

Yes, you're not expected to translate them into each language, just add them in the same place as you put them in en_US.json

Yes, you're not expected to translate them into each language, just add them in the same place as you put them in `en_US.json`
nicola02nb commented 2024-11-20 11:29:59 +00:00 (Migrated from github.com)
Copy Link

Okok, I think it would be better if I do it after this PR and also #245 are megrd... I'm planning to fix also all other missing translations that are missing form translation files

Okok, I think it would be better if I do it after this PR and also #245 are megrd... I'm planning to fix also all other missing translations that are missing form translation files
GabCoolDude commented 2024-11-20 11:33:02 +00:00 (Migrated from github.com)
Copy Link

I already have a PR for to add all the missing locales, it's #281. As for #245, I don't think it's getting merged anytime soon so you probably don't have to worry about that

I already have a PR for to add all the missing locales, it's #281. As for #245, I don't think it's getting merged anytime soon so you probably don't have to worry about that
nicola02nb commented 2024-11-20 11:39:44 +00:00 (Migrated from github.com)
Copy Link

Oh, I hadn't seen them...

I'll commit soon missing translations

Oh, I hadn't seen them... I'll commit soon missing translations
nicola02nb commented 2024-11-20 11:52:14 +00:00 (Migrated from github.com)
Copy Link

Done

Done
👍 2
ryzendew commented 2024-11-25 16:30:42 +00:00 (Migrated from github.com)
Copy Link

Tested this PR on 3 distros: Fedora 41 Pikaos 4 aka Debian and Cachyos

No issues at all with installing keys!

Good work!

Tested this PR on 3 distros: Fedora 41 Pikaos 4 aka Debian and Cachyos No issues at all with installing keys! Good work!
❤️ 2
mattzink commented 2024-11-25 17:02:31 +00:00 (Migrated from github.com)
Copy Link

Should the "Install Keys" menu item be moved above the "Install Firmware" item, since that is the required order of operations? Might help newbies.

Should the "Install Keys" menu item be moved above the "Install Firmware" item, since that is the required order of operations? Might help newbies.
👍 3
jzumaran commented 2024-11-25 17:03:10 +00:00 (Migrated from github.com)
Copy Link

Tested this on Mac OS 13.6.9 and had no issues installing keys. Tried all 3 methods and in all cases keys were installed into ~ /Library/Application Suppor/Ryujinx/system.

Tested this on Mac OS 13.6.9 and had no issues installing keys. Tried all 3 methods and in all cases keys were installed into ~ /Library/Application Suppor/Ryujinx/system.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
horizon
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#233
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?