MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

WIP: Added a new window for shortcut configuration #607

Closed
Goodfeat wants to merge 22 commits from master into master
pull from: master
merge into: MeloNX:master
Conversation 7 Commits 22 Files Changed 10 +716 -21
Goodfeat commented 2025-02-01 06:50:20 +00:00 (Migrated from github.com)
Copy Link

Added a window with settings for shortcuts. When creating a shortcut, arguments of those settings that were changed in this window will be added.
Added new arguments for shortcuts that the shortcut creation window uses.
When starting a game with arguments, a separate configuration is used (based on the global configuration), but does not affect it in any way

image

https://github.com/user-attachments/assets/e9e52ee4-f2ef-4be7-8641-623627a14de0

Added a window with settings for shortcuts. When creating a shortcut, arguments of those settings that were changed in this window will be added. Added new arguments for shortcuts that the shortcut creation window uses. When starting a game with arguments, a separate configuration is used (based on the global configuration), but does not affect it in any way ![image](https://github.com/user-attachments/assets/f25143b7-7476-481b-afd9-057da990279c) https://github.com/user-attachments/assets/e9e52ee4-f2ef-4be7-8641-623627a14de0
GreemDev (Migrated from github.com) reviewed 2025-02-01 06:50:20 +00:00
GreemDev commented 2025-02-01 06:58:29 +00:00 (Migrated from github.com)
Copy Link

I feel like this functionality would be rendered kinda redundant once we have per-game configurations.

I feel like this functionality would be rendered kinda redundant once we have per-game configurations.
GreemDev (Migrated from github.com) requested changes 2025-02-01 06:58:38 +00:00
src/Ryujinx/UI/Windows/ArgumentsConfigWindows.axaml.cs
GreemDev (Migrated from github.com) commented 2025-02-01 06:56:19 +00:00
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev (Migrated from github.com) commented 2025-02-01 06:57:12 +00:00
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
github-actions[bot] commented 2025-02-01 06:59:31 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+7b36544-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538706108.zip) * [ryujinx-Release-1.2.0+7b36544-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538706231.zip) * [ryujinx-Release-1.2.0+7b36544-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538709941.zip) * [ryujinx-Release-1.2.0+7b36544-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538709945.zip) * [ryujinx-Release-1.2.0+7b36544-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538710055.zip) * [ryujinx-Release-1.2.0+7b36544-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538716952.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+7b36544-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538708965.zip) * [ryujinx-Debug-1.2.0+7b36544-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538709058.zip) * [ryujinx-Debug-1.2.0+7b36544-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538710202.zip) * [ryujinx-Debug-1.2.0+7b36544-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538711388.zip) * [ryujinx-Debug-1.2.0+7b36544-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538711470.zip) * [ryujinx-Debug-1.2.0+7b36544-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2538719842.zip) </details>
Goodfeat commented 2025-02-01 07:10:28 +00:00 (Migrated from github.com)
Copy Link

I feel like this functionality would be rendered kinda redundant once we have per-game configurations.

There is currently no separate configuration for games, but this method at least allows you to configure shortcuts separately, so it might not be superfluous now.

> I feel like this functionality would be rendered kinda redundant once we have per-game configurations. There is currently no separate configuration for games, but this method at least allows you to configure shortcuts separately, so it might not be superfluous now.
Goodfeat commented 2025-02-01 10:57:11 +00:00 (Migrated from github.com)
Copy Link

image
this pull request seems to require changes to the workflow as the workflow does not have the required path and simply replicates the original path

![image](https://github.com/user-attachments/assets/f3ebeff3-8439-43df-bad0-e2ae27a97411) this pull request seems to require changes to the workflow as the workflow does not have the required path and simply replicates the original path
Goodfeat commented 2025-02-01 12:10:48 +00:00 (Migrated from github.com)
Copy Link

I couldn't figure out why the local version worked without problems, but the one compiled on github didn't work properly. I figured it out, this is a test release version

https://github.com/Goodfeat/Ryujinx_alt/releases/download/1.2.59/ryujinx-1.2.59-win_x64.zip

I couldn't figure out why the local version worked without problems, but the one compiled on github didn't work properly. I figured it out, this is a test release version https://github.com/Goodfeat/Ryujinx_alt/releases/download/1.2.59/ryujinx-1.2.59-win_x64.zip

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
GreemDev
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#607
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?