WIP: Added a new window for shortcut configuration #607

Closed
Goodfeat wants to merge 22 commits from master into master
10 changed files with 716 additions and 21 deletions

View File

@ -13,12 +13,14 @@ namespace Ryujinx.Common
public const string BuildGitHash = "%%RYUJINX_BUILD_GIT_HASH%%";
private const string ReleaseChannelName = "%%RYUJINX_TARGET_RELEASE_CHANNEL_NAME%%";
private const string ConfigFileName = "%%RYUJINX_CONFIG_FILE_NAME%%";
private const string ConfigFileNameOverride = "%%RYUJINX_CONFIG_FILE_NAME_OVERRIDE%%";
public const string ReleaseChannelOwner = "%%RYUJINX_TARGET_RELEASE_CHANNEL_OWNER%%";
public const string ReleaseChannelSourceRepo = "%%RYUJINX_TARGET_RELEASE_CHANNEL_SOURCE_REPO%%";
public const string ReleaseChannelRepo = "%%RYUJINX_TARGET_RELEASE_CHANNEL_REPO%%";
public static string ConfigName => !ConfigFileName.StartsWith("%%") ? ConfigFileName : "Config.json";
public static string CustomConfigNameOverride => !ConfigFileNameOverride.StartsWith("%%") ? ConfigFileNameOverride : "CustomConfigOverride.json";
public static bool IsValid =>
!BuildGitHash.StartsWith("%%") &&
@ -26,7 +28,8 @@ namespace Ryujinx.Common
!ReleaseChannelOwner.StartsWith("%%") &&
!ReleaseChannelSourceRepo.StartsWith("%%") &&
!ReleaseChannelRepo.StartsWith("%%") &&
!ConfigFileName.StartsWith("%%");
!ConfigFileName.StartsWith("%%") &&
!ConfigFileNameOverride.StartsWith("%%");
public static bool IsCanaryBuild => IsValid && ReleaseChannelName.Equals(CanaryChannel);

View File

@ -160,6 +160,28 @@ namespace Ryujinx.Ava
string localConfigurationPath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ReleaseInformation.ConfigName);
string appDataConfigurationPath = Path.Combine(AppDataManager.BaseDirPath, ReleaseInformation.ConfigName);
string overrideLocalConfigurationPath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ReleaseInformation.CustomConfigNameOverride);
string overrideAppDataConfigurationPath = Path.Combine(AppDataManager.BaseDirPath, ReleaseInformation.CustomConfigNameOverride);
// Copies and reloads the configuration file if the game was loaded with arguments
// based on global configuration
if (CommandLineState.CountArguments > 0)
{
if (File.Exists(localConfigurationPath))
{
File.Copy(localConfigurationPath, overrideLocalConfigurationPath, overwrite: true);
}
localConfigurationPath = overrideLocalConfigurationPath;
if (File.Exists(appDataConfigurationPath))
{
File.Copy(appDataConfigurationPath, overrideAppDataConfigurationPath, overwrite: true);
}
appDataConfigurationPath = overrideAppDataConfigurationPath;
}
// Now load the configuration as the other subsystems are now registered
if (File.Exists(localConfigurationPath))
{
@ -232,8 +254,35 @@ namespace Ryujinx.Ava
_ => ConfigurationState.Instance.HideCursor,
};
// Check if memoryManagerMode was overridden.
if (CommandLineState.OverrideMemoryManagerMode is not null)
if (Enum.TryParse(CommandLineState.OverrideMemoryManagerMode, true, out MemoryManagerMode result))
{
ConfigurationState.Instance.System.MemoryManagerMode.Value = result;
}
// Check if hardware-acceleration was overridden.
// Check if PPTC was overridden.
if (CommandLineState.OverridePPTC is not null)
if (Enum.TryParse(CommandLineState.OverridePPTC, true, out bool result))
{
ConfigurationState.Instance.System.EnablePtc.Value = result;
}
// Check if region was overridden.
if (CommandLineState.OverrideSystemRegion is not null)
if (Enum.TryParse(CommandLineState.OverrideSystemRegion, true, out Ryujinx.HLE.HOS.SystemState.RegionCode result))
{
ConfigurationState.Instance.System.Region.Value = (Utilities.Configuration.System.Region)result;
}
//Check if language was overridden.
if (CommandLineState.OverrideSystemLanguage is not null)
if (Enum.TryParse(CommandLineState.OverrideSystemLanguage, true, out Ryujinx.HLE.HOS.SystemState.SystemLanguage result))
{
ConfigurationState.Instance.System.Language.Value = (Utilities.Configuration.System.Language)result;
}
// Check if hardware-acceleration was overridden. MemoryManagerMode ( outdated! )
if (CommandLineState.OverrideHardwareAcceleration != null)
UseHardwareAcceleration = CommandLineState.OverrideHardwareAcceleration.Value;
}

View File

@ -376,15 +376,11 @@ namespace Ryujinx.Ava.UI.Controls
png.SaveTo(fileStream);
}
public void CreateApplicationShortcut_Click(object sender, RoutedEventArgs args)
public async void CreateApplicationShortcut_Click(object sender, RoutedEventArgs args)
{
if (sender is MenuItem { DataContext: MainWindowViewModel { SelectedApplication: not null } viewModel })
ShortcutHelper.CreateAppShortcut(
viewModel.SelectedApplication.Path,
viewModel.SelectedApplication.Name,
viewModel.SelectedApplication.IdString,
viewModel.SelectedApplication.Icon
);
await new ArgumentsConfigWindows(viewModel).ShowDialog((Window)viewModel.TopLevel);
}
public async void OpenApplicationCompatibility_Click(object sender, RoutedEventArgs args)

View File

@ -1,8 +1,10 @@
using Avalonia.Collections;
using Avalonia.Controls;
using Avalonia.Media.Imaging;
using Avalonia.Threading;
using CommunityToolkit.Mvvm.ComponentModel;
using Gommon;
using LibHac.Tools.Fs;
using LibHac.Tools.FsSystem;
using Ryujinx.Audio.Backends.OpenAL;
using Ryujinx.Audio.Backends.SDL2;
@ -26,6 +28,7 @@ using Ryujinx.HLE.HOS.Services.Time.TimeZone;
using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.IO;
using System.Linq;
using System.Net.NetworkInformation;
using System.Runtime.InteropServices;
@ -63,12 +66,56 @@ namespace Ryujinx.Ava.UI.ViewModels
public event Action CloseWindow;
public event Action SaveSettingsEvent;
public event Action CompareSettingsEvent;
private int _networkInterfaceIndex;
private int _multiplayerModeIndex;
private string _ldnPassphrase;
[ObservableProperty] private string _ldnServer;
public SettingsHacksViewModel DirtyHacks { get; }
public string GamePath { get; }
public string GameName { get; }
private Bitmap _gameIcon;
private string _gameTitle;
private string _gameId;
public Bitmap GameIcon
{
get => _gameIcon;
set
{
if (_gameIcon != value)
{
_gameIcon = value;
}
}
}
public string GameTitle
{
get => _gameTitle;
set
{
if (_gameTitle != value)
{
_gameTitle = value;
}
}
}
public string GameId
{
get => _gameId;
set
{
if (_gameId != value)
{
_gameId = value;
}
}
}
public int ResolutionScale
{
@ -344,6 +391,30 @@ namespace Ryujinx.Ava.UI.ViewModels
}
}
public SettingsViewModel(VirtualFileSystem virtualFileSystem, ContentManager contentManager, string gamePath, string gameName, string gameId, byte[] gameIconData) : this()
{
_virtualFileSystem = virtualFileSystem;
_contentManager = contentManager;
if (gameIconData != null && gameIconData.Length > 0)
{
using (var ms = new MemoryStream(gameIconData))
{
GameIcon = new Bitmap(ms);
}
}
GameTitle = gameName;
GameId = gameId;
if (Program.PreviewerDetached)
{
Task.Run(LoadTimeZones);
DirtyHacks = new SettingsHacksViewModel(this);
}
}
public SettingsViewModel()
{
GameDirectories = [];
@ -716,6 +787,11 @@ namespace Ryujinx.Ava.UI.ViewModels
SaveSettings();
}
public void CreateShortcut()
{
CompareSettingsEvent?.Invoke(); //raises an event to create a shortcut with arguments
}
public void OkButton()
{
SaveSettings();

View File

@ -0,0 +1,237 @@
<UserControl
x:Class="Ryujinx.Ava.UI.Views.Settings.SettingsApplyOverride"
xmlns="https://github.com/avaloniaui"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:ext="clr-namespace:Ryujinx.Ava.Common.Markup"
xmlns:viewModels="clr-namespace:Ryujinx.Ava.UI.ViewModels"
xmlns:helper="clr-namespace:Ryujinx.Common.Helper;assembly=Ryujinx.Common"
mc:Ignorable="d"
x:DataType="viewModels:SettingsViewModel">
<Design.DataContext>
<viewModels:SettingsViewModel />
</Design.DataContext>
<ScrollViewer
Name="AllSettings"
HorizontalAlignment="Stretch"
VerticalAlignment="Stretch"
HorizontalScrollBarVisibility="Disabled"
VerticalScrollBarVisibility="Auto">
<Border Classes="settings">
<StackPanel
Margin="10"
HorizontalAlignment="Stretch"
Orientation="Vertical"
Spacing="10">
<TextBlock Classes="h1" Text="{ext:Locale SettingsTabSystemCore}" />
<StackPanel
Margin="10,0,0,0"
Orientation="Horizontal">
<TextBlock VerticalAlignment="Center" Text="{ext:Locale SettingsTabSystemSystemRegion}" Width="250" />
<ComboBox
SelectedIndex="{Binding Region}"
ToolTip.Tip="{ext:Locale RegionTooltip}"
HorizontalContentAlignment="Left"
Width="350">
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemRegionJapan}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemRegionUSA}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemRegionEurope}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemRegionAustralia}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemRegionChina}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemRegionKorea}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemRegionTaiwan}" />
</ComboBoxItem>
</ComboBox>
</StackPanel>
<StackPanel
Margin="10,0,0,0"
Orientation="Horizontal">
<TextBlock
VerticalAlignment="Center"
Text="{ext:Locale SettingsTabSystemSystemLanguage}"
ToolTip.Tip="{ext:Locale LanguageTooltip}"
Width="250" />
<ComboBox
SelectedIndex="{Binding Language}"
ToolTip.Tip="{ext:Locale LanguageTooltip}"
HorizontalContentAlignment="Left"
Width="350">
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageJapanese}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageAmericanEnglish}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageFrench}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageGerman}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageItalian}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageSpanish}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageChinese}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageKorean}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageDutch}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguagePortuguese}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageRussian}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageTaiwanese}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageBritishEnglish}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageCanadianFrench}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageLatinAmericanSpanish}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageSimplifiedChinese}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageTraditionalChinese}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageBrazilianPortuguese}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageSwedish}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale SettingsTabSystemSystemLanguageNorwegian}" />
</ComboBoxItem>
</ComboBox>
</StackPanel>
<Separator Height="1" />
<TextBlock Classes="h1" Text="{ext:Locale SettingsTabCpu}" />
<StackPanel
Margin="10,0,0,0"
HorizontalAlignment="Stretch"
Orientation="Vertical">
<CheckBox IsChecked="{Binding EnablePptc}">
<TextBlock Text="{ext:Locale SettingsTabSystemEnablePptc}"
ToolTip.Tip="{ext:Locale PptcToggleTooltip}" />
</CheckBox>
</StackPanel>
<StackPanel
Margin="10,0,0,0"
HorizontalAlignment="Stretch"
Orientation="Vertical">
<StackPanel Orientation="Horizontal">
<TextBlock VerticalAlignment="Center"
Text="{ext:Locale SettingsTabSystemMemoryManagerMode}"
ToolTip.Tip="{ext:Locale MemoryManagerTooltip}"
Width="250" />
<ComboBox SelectedIndex="{Binding MemoryMode}"
ToolTip.Tip="{ext:Locale MemoryManagerTooltip}"
HorizontalContentAlignment="Left"
Width="350">
<ComboBoxItem
ToolTip.Tip="{ext:Locale MemoryManagerSoftwareTooltip}">
<TextBlock
Text="{ext:Locale SettingsTabSystemMemoryManagerModeSoftware}" />
</ComboBoxItem>
<ComboBoxItem
ToolTip.Tip="{ext:Locale MemoryManagerHostTooltip}">
<TextBlock Text="{ext:Locale SettingsTabSystemMemoryManagerModeHost}" />
</ComboBoxItem>
<ComboBoxItem
ToolTip.Tip="{ext:Locale MemoryManagerUnsafeTooltip}">
<TextBlock
Text="{ext:Locale SettingsTabSystemMemoryManagerModeHostUnchecked}" />
</ComboBoxItem>
</ComboBox>
</StackPanel>
<CheckBox IsChecked="{Binding UseHypervisor}"
IsVisible="{x:Static helper:RunningPlatform.IsArmMac}"
ToolTip.Tip="{ext:Locale UseHypervisorTooltip}">
<TextBlock Text="{ext:Locale SettingsTabSystemUseHypervisor}"
ToolTip.Tip="{ext:Locale UseHypervisorTooltip}" />
</CheckBox>
</StackPanel>
<Separator Height="1" />
<TextBlock Classes="h1" Text="{ext:Locale SettingsTabGraphics}" />
<StackPanel Margin="10,0,0,0" Orientation="Vertical" Spacing="10">
<StackPanel Orientation="Horizontal">
<TextBlock VerticalAlignment="Center"
ToolTip.Tip="{ext:Locale SettingsTabGraphicsBackendTooltip}"
Text="{ext:Locale SettingsTabGraphicsBackend}"
Width="250" />
<ComboBox
Name="GraphicsBackendSelector"
Width="350"
HorizontalContentAlignment="Left"
ToolTip.Tip="{ext:Locale SettingsTabGraphicsBackendTooltip}"
SelectedIndex="{Binding GraphicsBackendIndex}">
<ComboBoxItem IsVisible="{Binding IsVulkanAvailable}" ToolTip.Tip="{ext:Locale SettingsTabGraphicsBackendAutoTooltip}" >
<TextBlock Text="{ext:Locale SettingsTabGraphicsBackendAuto}" />
</ComboBoxItem>
<ComboBoxItem IsVisible="{Binding IsVulkanAvailable}">
<TextBlock Text="Vulkan" />
</ComboBoxItem>
<ComboBoxItem IsEnabled="{Binding IsOpenGLAvailable}">
<TextBlock Text="OpenGL" />
</ComboBoxItem>
<ComboBoxItem IsEnabled="{x:Static helper:RunningPlatform.IsArmMac}">
<TextBlock Text="Metal (ARM Mac only, Experimental)" />
</ComboBoxItem>
</ComboBox>
</StackPanel>
<StackPanel Orientation="Horizontal">
<TextBlock VerticalAlignment="Center"
ToolTip.Tip="{ext:Locale GraphicsBackendThreadingTooltip}"
Text="{ext:Locale SettingsTabGraphicsBackendMultithreading}"
Width="250" />
<ComboBox Width="350"
HorizontalContentAlignment="Left"
ToolTip.Tip="{ext:Locale GalThreadingTooltip}"
SelectedIndex="{Binding GraphicsBackendMultithreadingIndex}">
<ComboBoxItem>
<TextBlock Text="{ext:Locale CommonAuto}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale CommonOff}" />
</ComboBoxItem>
<ComboBoxItem>
<TextBlock Text="{ext:Locale CommonOn}" />
</ComboBoxItem>
</ComboBox>
</StackPanel>
</StackPanel>
</StackPanel>
</Border>
</ScrollViewer>
</UserControl>

View File

@ -0,0 +1,12 @@
using Avalonia.Controls;
namespace Ryujinx.Ava.UI.Views.Settings
{
public partial class SettingsApplyOverride : UserControl
{
public SettingsApplyOverride()
{
InitializeComponent();
}
}
}

View File

@ -0,0 +1,105 @@
<window:StyleableAppWindow
x:Class="Ryujinx.Ava.UI.Windows.ArgumentsConfigWindows"
xmlns="https://github.com/avaloniaui"
xmlns:ui="clr-namespace:FluentAvalonia.UI.Controls;assembly=FluentAvalonia"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:ext="clr-namespace:Ryujinx.Ava.Common.Markup"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:window="clr-namespace:Ryujinx.Ava.UI.Windows"
xmlns:viewModels="clr-namespace:Ryujinx.Ava.UI.ViewModels"
xmlns:settings="clr-namespace:Ryujinx.Ava.UI.Views.Settings"
xmlns:helpers="clr-namespace:Ryujinx.Ava.UI.Helpers"
xmlns:helper="clr-namespace:Ryujinx.Common.Helper;assembly=Ryujinx.Common"
Width="1100"
Height="768"
MinWidth="800"
MinHeight="480"
WindowStartupLocation="CenterOwner"
x:DataType="viewModels:SettingsViewModel"
mc:Ignorable="d"
Focusable="True">
<Design.DataContext>
<viewModels:SettingsViewModel />
</Design.DataContext>
<Grid HorizontalAlignment="Stretch" VerticalAlignment="Stretch" MinWidth="600" RowDefinitions="Auto,*,Auto">
<ContentPresenter
x:Name="ContentPresenter"
Grid.Row="1"
IsVisible="False"
KeyboardNavigation.IsTabStop="False"/>
<Grid Name="Pages" IsVisible="False" Grid.Row="2">
<settings:SettingsApplyOverride Name="AllSettings" />
</Grid>
<ui:NavigationView
Grid.Row="1"
IsSettingsVisible="False"
Name="NavPanel"
IsBackEnabled="False"
PaneDisplayMode="Left"
Margin="2,10,10,0"
VerticalAlignment="Stretch"
HorizontalAlignment="Stretch"
OpenPaneLength="200"
IsPaneToggleButtonVisible="False">
<!-- For image -->
<ui:NavigationView.PaneHeader>
<Grid HorizontalAlignment="Center" VerticalAlignment="Center">
<Grid.RowDefinitions>
<RowDefinition Height="Auto"/>
<RowDefinition Height="Auto"/>
<RowDefinition Height="Auto"/>
<RowDefinition Height="5"/>
</Grid.RowDefinitions>
<TextBlock Text="{Binding GameId}"
HorizontalAlignment="Center"
VerticalAlignment="Center"
Margin="0,0,0,10"
TextAlignment="Center" Grid.Row="0" />
<Image Source="{Binding GameIcon}"
Width="160"
Height="160"
Grid.Row="1"
Margin="0,0,0,10"
HorizontalAlignment="Center" />
<TextBlock Text="{Binding GameTitle}"
HorizontalAlignment="Center"
VerticalAlignment="Center"
Margin="0,0,0,10"
TextAlignment="Center" Grid.Row="2" />
<Separator Height="1" Grid.Row="3" Margin="0,0,0,10" HorizontalAlignment="Stretch"/>
</Grid>
</ui:NavigationView.PaneHeader>
<ui:NavigationView.MenuItems>
<ui:NavigationViewItem
Margin="2,10,10,0"
Content="{ext:Locale Settings}"
Tag="AllSettings">
<ui:NavigationViewItem.IconSource>
<ui:FontIconSource
FontFamily="avares://Ryujinx/Assets/Fonts#Segoe Fluent Icons"
Glyph="{helpers:GlyphValueConverter Chip}" />
</ui:NavigationViewItem.IconSource>
</ui:NavigationViewItem>
</ui:NavigationView.MenuItems>
</ui:NavigationView>
<ReversibleStackPanel
Grid.Row="2"
Margin="10"
Spacing="10"
Orientation="Horizontal"
HorizontalAlignment="Right"
ReverseOrder="{x:Static helper:RunningPlatform.IsMacOS}">
<Button
Content="{ext:Locale GameListContextMenuCreateShortcut}"
Command="{Binding CreateShortcut}" />
<Button
HotKey="Escape"
Content="{ext:Locale ControllerSettingsClose}"
Command="{Binding CancelButton}" />
</ReversibleStackPanel>
</Grid>
</window:StyleableAppWindow>

View File

@ -0,0 +1,162 @@
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Avalonia;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Avalonia.Controls;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Avalonia.Controls.Shapes;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Avalonia.Input;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Avalonia.Media.Imaging;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using FluentAvalonia.Core;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using FluentAvalonia.UI.Controls;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Projektanker.Icons.Avalonia;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Ryujinx.Ava.Common.Locale;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Ryujinx.Ava.UI.Models;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Ryujinx.Ava.UI.ViewModels;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Ryujinx.Ava.UI.ViewModels.Input;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Ryujinx.Ava.Utilities;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Ryujinx.Ava.Utilities.Configuration;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Ryujinx.Common.Configuration;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Ryujinx.HLE.FileSystem;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Ryujinx.HLE.HOS.SystemState;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Ryujinx.Input;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using System;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using System.IO;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using System.Linq;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
using Key = Avalonia.Input.Key;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
namespace Ryujinx.Ava.UI.Windows
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public partial class ArgumentsConfigWindows : StyleableAppWindow
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
internal readonly SettingsViewModel ViewModel;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public string GamePath { get; }
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public string GameName { get; }
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public string GameId { get; }
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public byte[] GameIconData { get; }
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public static int OverrideBackendThreading { get; private set; }
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public static int OverrideGraphicsBackend { get; private set; }
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public static int OverrideSystemLanguage { get; private set; }
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public static int OverrideSystemRegion { get; private set; }
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public static bool OverridePPTC { get; private set; }
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public static int OverrideMemoryManagerMode { get; private set; }
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public ArgumentsConfigWindows(MainWindowViewModel viewModel)
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
Title = RyujinxApp.FormatTitle(LocaleKeys.Settings);
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
DataContext = ViewModel = new SettingsViewModel(
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
viewModel.VirtualFileSystem,
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
viewModel.ContentManager,
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
viewModel.SelectedApplication.Path,
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
viewModel.SelectedApplication.Name,
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
viewModel.SelectedApplication.IdString,
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
viewModel.SelectedApplication.Icon);
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GamePath = viewModel.SelectedApplication.Path;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GameName = viewModel.SelectedApplication.Name;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GameId = viewModel.SelectedApplication.IdString;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GameIconData = viewModel.SelectedApplication.Icon;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
OverrideBackendThreading = ViewModel.GraphicsBackendMultithreadingIndex;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
OverrideGraphicsBackend = ViewModel.GraphicsBackendIndex;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
OverrideSystemLanguage = ViewModel.Language;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
OverrideSystemRegion = ViewModel.Region;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
OverridePPTC = ViewModel.EnablePptc;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
OverrideMemoryManagerMode = ViewModel.MemoryMode;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
ViewModel.CloseWindow += Close;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
ViewModel.CompareSettingsEvent += CompareConfiguration;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
InitializeComponent();
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
Load();
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
#if DEBUG
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
this.AttachDevTools(new KeyGesture(Key.F12, KeyModifiers.Alt));
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
#endif
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
public void CompareConfiguration()
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
ShortcutHelper.CreateAppShortcut(
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GamePath,
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GameName,
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GameId,
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GameIconData,
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GetArguments()
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
);
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
private string GetArguments()
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
string line = "";
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
if (OverrideBackendThreading != ViewModel.GraphicsBackendMultithreadingIndex)
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
string _result = Enum.GetName(typeof(BackendThreading), ViewModel.GraphicsBackendMultithreadingIndex);
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
line += " --backend-threading " + _result;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
if (OverrideGraphicsBackend != ViewModel.GraphicsBackendIndex)
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
string _result = Enum.GetName(typeof(GraphicsBackend), ViewModel.GraphicsBackendIndex);
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
line += " -g " + _result;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
if (OverridePPTC != ViewModel.EnablePptc)
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
string _result = ViewModel.EnablePptc.ToString();
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
line += " --pptc " + _result;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
if (OverrideMemoryManagerMode != ViewModel.MemoryMode)
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
string _result = Enum.GetName(typeof(MemoryManagerMode), ViewModel.MemoryMode);
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
line += " -m " + _result;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
if (OverrideSystemRegion != ViewModel.Region)
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
string _result = Enum.GetName(typeof(RegionCode), ViewModel.Region);
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
line += " --system-region " + _result;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
if (OverrideSystemLanguage != ViewModel.Language)
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
string _result = Enum.GetName(typeof(SystemLanguage), ViewModel.Language);
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
line += " --system-language " + _result;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
return line;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
private void Load()
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
Pages.Children.Clear();
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
NavPanel.SelectionChanged += NavPanelOnSelectionChanged;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
NavPanel.SelectedItem = NavPanel.MenuItems.ElementAt(0);
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
private void NavPanelOnSelectionChanged(object sender, NavigationViewSelectionChangedEventArgs e)
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
if (e.SelectedItem is NavigationViewItem navItem && navItem.Tag is not null)
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
switch (navItem.Tag.ToString())
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
case nameof(AllSettings):
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
NavPanel.Content = AllSettings;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
break;
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
default:
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
throw new NotImplementedException();
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
protected override void OnClosing(WindowClosingEventArgs e)
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
base.OnClosing(e);
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything

View File

@ -6,11 +6,15 @@ namespace Ryujinx.Ava.Utilities
public static class CommandLineState
{
public static string[] Arguments { get; private set; }
public static int CountArguments { get; private set; }
public static bool? OverrideDockedMode { get; private set; }
public static bool? OverrideHardwareAcceleration { get; private set; }
public static string OverrideGraphicsBackend { get; private set; }
public static string OverrideBackendThreading { get; private set; }
public static string OverridePPTC { get; private set; }
public static string OverrideMemoryManagerMode { get; private set; }
public static string OverrideSystemRegion { get; private set; }
public static string OverrideSystemLanguage { get; private set; }
public static string OverrideHideCursor { get; private set; }
public static string BaseDirPathArg { get; private set; }
public static string Profile { get; private set; }
@ -28,6 +32,11 @@ namespace Ryujinx.Ava.Utilities
{
string arg = args[i];
if (arg.Contains("-") || arg.Contains("--"))
{
CountArguments++;
}
switch (arg)
{
case "-r":
@ -85,6 +94,47 @@ namespace Ryujinx.Ava.Utilities
OverrideBackendThreading = args[++i];
break;
case "--pptc":
if (i + 1 >= args.Length)
{
Logger.Error?.Print(LogClass.Application, $"Invalid option '{arg}'");
continue;
}
OverridePPTC = args[++i];
break;
case "-m":
case "--memory-manager-mode":
if (i + 1 >= args.Length)
{
Logger.Error?.Print(LogClass.Application, $"Invalid option '{arg}'");
continue;
}
OverrideMemoryManagerMode = args[++i];
break;
case "--system-region":
if (i + 1 >= args.Length)
{
Logger.Error?.Print(LogClass.Application, $"Invalid option '{arg}'");
continue;
}
OverrideSystemRegion = args[++i];
break;
case "--system-language":
if (i + 1 >= args.Length)
{
Logger.Error?.Print(LogClass.Application, $"Invalid option '{arg}'");
continue;
}
OverrideSystemLanguage = args[++i];
break;
case "-i":
case "--application-id":
LaunchApplicationId = args[++i];

View File

@ -12,7 +12,7 @@ namespace Ryujinx.Ava.Utilities
public static class ShortcutHelper
{
[SupportedOSPlatform("windows")]
private static void CreateShortcutWindows(string applicationFilePath, string applicationId, byte[] iconData, string iconPath, string cleanedAppName, string desktopPath)
private static void CreateShortcutWindows(string applicationFilePath, string applicationId, byte[] iconData, string iconPath, string cleanedAppName, string desktopPath, string args = "")
{
string basePath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, AppDomain.CurrentDomain.FriendlyName + ".exe");
iconPath += ".ico";
@ -22,13 +22,13 @@ namespace Ryujinx.Ava.Utilities
image.Resize(new SKImageInfo(128, 128), SKFilterQuality.High);
SaveBitmapAsIcon(image, iconPath);
Shortcut shortcut = Shortcut.CreateShortcut(basePath, GetArgsString(applicationFilePath, applicationId), iconPath, 0);
Shortcut shortcut = Shortcut.CreateShortcut(basePath, GetArgsString(applicationFilePath, applicationId, args), iconPath, 0);
shortcut.StringData.NameString = cleanedAppName;
shortcut.WriteToFile(Path.Combine(desktopPath, cleanedAppName + ".lnk"));
}
[SupportedOSPlatform("linux")]
private static void CreateShortcutLinux(string applicationFilePath, string applicationId, byte[] iconData, string iconPath, string desktopPath, string cleanedAppName)
private static void CreateShortcutLinux(string applicationFilePath, string applicationId, byte[] iconData, string iconPath, string desktopPath, string cleanedAppName, string args = "")
{
string basePath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Ryujinx.sh");
string desktopFile = EmbeddedResources.ReadAllText("Ryujinx/Assets/ShortcutFiles/shortcut-template.desktop");
@ -40,11 +40,11 @@ namespace Ryujinx.Ava.Utilities
data.SaveTo(file);
using StreamWriter outputFile = new(Path.Combine(desktopPath, cleanedAppName + ".desktop"));
outputFile.Write(desktopFile, cleanedAppName, iconPath, $"{basePath} {GetArgsString(applicationFilePath, applicationId)}");
outputFile.Write(desktopFile, cleanedAppName, iconPath, $"{basePath} {GetArgsString(applicationFilePath, applicationId, args)}");
}
[SupportedOSPlatform("macos")]
private static void CreateShortcutMacos(string appFilePath, string applicationId, byte[] iconData, string desktopPath, string cleanedAppName)
private static void CreateShortcutMacos(string appFilePath, string applicationId, byte[] iconData, string desktopPath, string cleanedAppName, string args = "")
{
string basePath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Ryujinx");
string plistFile = EmbeddedResources.ReadAllText("Ryujinx/Assets/ShortcutFiles/shortcut-template.plist");
@ -63,7 +63,7 @@ namespace Ryujinx.Ava.Utilities
string scriptPath = Path.Combine(scriptFolderPath, ScriptName);
using StreamWriter scriptFile = new(scriptPath);
scriptFile.Write(shortcutScript, basePath, GetArgsString(appFilePath, applicationId));
scriptFile.Write(shortcutScript, basePath, GetArgsString(appFilePath, applicationId, args));
// Set execute permission
FileInfo fileInfo = new(scriptPath);
@ -87,7 +87,7 @@ namespace Ryujinx.Ava.Utilities
outputFile.Write(plistFile, ScriptName, cleanedAppName, IconName);
}
public static void CreateAppShortcut(string applicationFilePath, string applicationName, string applicationId, byte[] iconData)
public static void CreateAppShortcut(string applicationFilePath, string applicationName, string applicationId, byte[] iconData, string args = "")
{
string desktopPath = Environment.GetFolderPath(Environment.SpecialFolder.DesktopDirectory);
string cleanedAppName = string.Join("_", applicationName.Split(Path.GetInvalidFileNameChars()));
@ -96,7 +96,7 @@ namespace Ryujinx.Ava.Utilities
{
string iconPath = Path.Combine(AppDataManager.BaseDirPath, "games", applicationId, "app");
CreateShortcutWindows(applicationFilePath, applicationId, iconData, iconPath, cleanedAppName, desktopPath);
CreateShortcutWindows(applicationFilePath, applicationId, iconData, iconPath, cleanedAppName, desktopPath, args);
return;
}
@ -106,14 +106,14 @@ namespace Ryujinx.Ava.Utilities
string iconPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".local", "share", "icons", "Ryujinx");
Directory.CreateDirectory(iconPath);
CreateShortcutLinux(applicationFilePath, applicationId, iconData, Path.Combine(iconPath, applicationId), desktopPath, cleanedAppName);
CreateShortcutLinux(applicationFilePath, applicationId, iconData, Path.Combine(iconPath, applicationId), desktopPath, cleanedAppName, args);
return;
}
if (OperatingSystem.IsMacOS())
{
CreateShortcutMacos(applicationFilePath, applicationId, iconData, desktopPath, cleanedAppName);
CreateShortcutMacos(applicationFilePath, applicationId, iconData, desktopPath, cleanedAppName, args);
return;
}
@ -121,7 +121,7 @@ namespace Ryujinx.Ava.Utilities
throw new NotImplementedException("Shortcut support has not been implemented yet for this OS.");
}
private static string GetArgsString(string appFilePath, string applicationId)
private static string GetArgsString(string appFilePath, string applicationId, string config = "")
{
// args are first defined as a list, for easier adjustments in the future
List<string> argsList = [];
@ -132,6 +132,11 @@ namespace Ryujinx.Ava.Utilities
argsList.Add($"\"{CommandLineState.BaseDirPathArg}\"");
}
if (!string.IsNullOrEmpty(config))
{
argsList.Add(config);
}
if (appFilePath.ToLower().EndsWith(".xci"))
{
argsList.Add("--application-id");