MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Add language localisation for all missing items #113

Closed
amurgshere wants to merge 2 commits from global-localisation-update into master
pull from: global-localisation-update
merge into: MeloNX:master
Conversation 7 Commits 2 Files Changed 16 +308 -2
amurgshere commented 2024-10-30 15:04:19 +00:00 (Migrated from github.com)
Copy Link

Add language localisation for all missing items
Remove unused AutoloadDlcAndUpdateAddedMessage

Created a utilty which uses the publicly accessible Google Translate to find all missing locale items and translate them, the utility preserves all original encoding and translations and only adds the missing ones, please help me to confirm the language conversions are good. I did consider sorting all of them so that the locales are all in alphabetical order of name, but that would have caused us to lose our ability to diff these accurately, so left them in the order they are in as much as possible.

For some reason it is complaining about bidirectional unicode characters, but these were already in there, I can regenerate them and not use the JavaScriptEncoder.UnsafeRelaxedJsonEscaping encoder, but this will then end up modifying a lot of these items using /uxxxx syntax instead which I feel is not ideal.

Will upload the tool I created to GitHub when I get the code cleaned up.

Add language localisation for all missing items Remove unused AutoloadDlcAndUpdateAddedMessage Created a utilty which uses the publicly accessible Google Translate to find all missing locale items and translate them, the utility preserves all original encoding and translations and only adds the missing ones, please help me to confirm the language conversions are good. I did consider sorting all of them so that the locales are all in alphabetical order of name, but that would have caused us to lose our ability to diff these accurately, so left them in the order they are in as much as possible. For some reason it is complaining about bidirectional unicode characters, but these were already in there, I can regenerate them and not use the JavaScriptEncoder.UnsafeRelaxedJsonEscaping encoder, but this will then end up modifying a lot of these items using /uxxxx syntax instead which I feel is not ideal. Will upload the tool I created to GitHub when I get the code cleaned up.
github-actions[bot] commented 2024-10-30 15:16:14 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less (SDL2)
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+9b4fbae-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123679954.zip) * [ryujinx-Release-1.2.0+9b4fbae-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123690346.zip) * [ryujinx-Release-1.2.0+9b4fbae-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123701561.zip) * [ryujinx-Release-1.2.0+9b4fbae-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123711838.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+9b4fbae-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123680308.zip) * [sdl2-ryujinx-headless-Release-1.2.0+9b4fbae-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123690716.zip) * [sdl2-ryujinx-headless-Release-1.2.0+9b4fbae-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123701901.zip) * [sdl2-ryujinx-headless-Release-1.2.0+9b4fbae-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123712206.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+9b4fbae-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123680930.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+9b4fbae-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123681188.zip) * [ryujinx-Debug-1.2.0+9b4fbae-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123695352.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+9b4fbae-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123695570.zip) * [ryujinx-Debug-1.2.0+9b4fbae-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123701515.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+9b4fbae-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123701824.zip) * [ryujinx-Debug-1.2.0+9b4fbae-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123712275.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+9b4fbae-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2123712665.zip) </details>
WilliamWsyHK commented 2024-11-02 14:46:13 +00:00 (Migrated from github.com)
Copy Link

Please, the Google-translated zh_TW.json is in bad shape, and it is not TChinese but SChinese.
I have made #158 for that.

Please, the Google-translated `zh_TW.json` is in bad shape, and it is not TChinese but SChinese. I have made #158 for that.
amurgshere commented 2024-11-02 15:51:32 +00:00 (Migrated from github.com)
Copy Link

Please, the Google-translated zh_TW.json is in bad shape, and it is not TChinese but SChinese. I have made #158 for that.

Thanks @WilliamWsyHK , I will review and see if I can get Google to use traditional Chinese instead for these.

> Please, the Google-translated `zh_TW.json` is in bad shape, and it is not TChinese but SChinese. I have made #158 for that. Thanks @WilliamWsyHK , I will review and see if I can get Google to use traditional Chinese instead for these.
GreemDev commented 2024-11-02 15:52:43 +00:00 (Migrated from github.com)
Copy Link

Honestly I kinda don't want to merge this at all now. How many other translations are just wrong or bad because of Google Translate? This is why we don't already run everything through online translators, it's never correct.

Honestly I kinda don't want to merge this at all now. How many other translations are just wrong or bad because of Google Translate? This is why we don't already run everything through online translators, it's never correct.
amurgshere commented 2024-11-03 02:23:44 +00:00 (Migrated from github.com)
Copy Link

Hey @GreemDev ,

I understand but the main point is that the tool I wrote can easily redo them from scratch, this is just a case of it using Simplified Chinese instead of Traditional, so it’s just a matter of changing the tooling to use traditional instead and I can easily update it. So not a big deal, also it’s only adding missing ones. Not replacing existing. I will update it soon with the correct language, we just need one person from each language to confirm it’s good before we merge.

Cheers.

Hey @GreemDev , I understand but the main point is that the tool I wrote can easily redo them from scratch, this is just a case of it using Simplified Chinese instead of Traditional, so it’s just a matter of changing the tooling to use traditional instead and I can easily update it. So not a big deal, also it’s only adding missing ones. Not replacing existing. I will update it soon with the correct language, we just need one person from each language to confirm it’s good before we merge. Cheers.
amurgshere commented 2024-11-03 09:21:11 +00:00 (Migrated from github.com)
Copy Link

Hey @WilliamWsyHK & @GreemDev ,

I have updated the tool to use the correct language translation and regenerated the missing language conversions.

You can find the recent changes in a new Pull Request https://github.com/GreemDev/Ryujinx/pull/171 , @WilliamWsyHK can you please confirm these look good now?

I have also uploaded the tool itself which you can find here:

https://github.com/amurgshere/LanguageLocaliser

Thank You.

Hey @WilliamWsyHK & @GreemDev , I have updated the tool to use the correct language translation and regenerated the missing language conversions. You can find the recent changes in a new Pull Request https://github.com/GreemDev/Ryujinx/pull/171 , @WilliamWsyHK can you please confirm these look good now? I have also uploaded the tool itself which you can find here: https://github.com/amurgshere/LanguageLocaliser Thank You.
Juoelenis (Migrated from github.com) approved these changes 2024-11-03 10:04:11 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Juoelenis
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#113
No description provided.
Delete Branch "global-localisation-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?