MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

ARMeilleure: replace else-ifs with switch statements #124

Closed
LukeWarnut wants to merge 1 commits from switch-st into master
pull from: switch-st
merge into: MeloNX:master
Conversation 8 Commits 1 Files Changed 20 +675 -651
LukeWarnut commented 2024-10-31 13:48:49 +00:00 (Migrated from github.com)
Copy Link

This PR replaces several if/else if/else statements with switch statements across ARMeilleure. This should result in a very minor performance increase in some CPU/PPTC-related tasks.

I've tested several games with no issues, but further testing is welcome.

This PR replaces several if/else if/else statements with switch statements across ARMeilleure. This should result in a very minor performance increase in some CPU/PPTC-related tasks. I've tested several games with no issues, but further testing is welcome.
👍 2 ❤️ 2
github-actions[bot] commented 2024-10-31 13:57:21 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less (SDL2)
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+ac75746-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128458986.zip) * [ryujinx-Release-1.2.0+ac75746-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128467491.zip) * [ryujinx-Release-1.2.0+ac75746-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128479601.zip) * [ryujinx-Release-1.2.0+ac75746-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128490073.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+ac75746-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128459165.zip) * [sdl2-ryujinx-headless-Release-1.2.0+ac75746-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128467765.zip) * [sdl2-ryujinx-headless-Release-1.2.0+ac75746-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128479786.zip) * [sdl2-ryujinx-headless-Release-1.2.0+ac75746-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128490334.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+ac75746-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128459909.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+ac75746-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128460084.zip) * [ryujinx-Debug-1.2.0+ac75746-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128471328.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+ac75746-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128471549.zip) * [ryujinx-Debug-1.2.0+ac75746-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128478416.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+ac75746-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128478608.zip) * [ryujinx-Debug-1.2.0+ac75746-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128489787.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+ac75746-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2128490206.zip) </details>
Digote commented 2024-11-06 20:35:09 +00:00 (Migrated from github.com)
Copy Link

Great job! I’ll add some tests to check if there’s been any regression.

Setup

Ryzen 5 5600
32GB - 3200Mhz
RTX 4060ti - Driver 566.03

Pokémon Legends: Arceus(1.1.1.)

MAIN(1.2.72)

https://github.com/user-attachments/assets/bf00bd1e-a1f4-4b41-9bc7-7e9ab7f20f52

PR-124

https://github.com/user-attachments/assets/044f7264-5c03-4030-b825-523e3542dd28

I will add more games later.

MAINTAINER EDIT: These videos are h.265 encoded and seemingly only viewable in Chromium-based browsers, or via downloading & watching with a program that can handle h.265.

EDIT 2: I uploaded it again with h.264

Great job! I’ll add some tests to check if there’s been any regression. Setup Ryzen 5 5600 32GB - 3200Mhz RTX 4060ti - Driver 566.03 --------------------------------------------------------------------------------------- **Pokémon Legends: Arceus(1.1.1.)** **MAIN(1.2.72)** https://github.com/user-attachments/assets/bf00bd1e-a1f4-4b41-9bc7-7e9ab7f20f52 **PR-124** https://github.com/user-attachments/assets/044f7264-5c03-4030-b825-523e3542dd28 _________________________________________________________________________________ I will add more games later. MAINTAINER EDIT: These videos are h.265 encoded and seemingly only viewable in Chromium-based browsers, or via downloading & watching with a program that can handle h.265. EDIT 2: I uploaded it again with h.264
🚀 1
Julienraptor01 commented 2024-11-06 21:15:43 +00:00 (Migrated from github.com)
Copy Link

MAINTAINER EDIT: These videos are h.265 encoded and seemingly only viewable in Chromium-based browsers, or via downloading & watching with a program that can handle h.265.

Note

The problem is actually not the H.265, but the Microsoft Media Foundation (MF) CDM (Content Decryption Module) DRM
The video was likely recorded with a Microsoft tool instead of smth clean like OBS

> MAINTAINER EDIT: These videos are h.265 encoded and seemingly only viewable in Chromium-based browsers, or via downloading & watching with a program that can handle h.265. > [!NOTE] > The problem is actually not the H.265, but the Microsoft Media Foundation (MF) CDM (Content Decryption Module) DRM > The video was likely recorded with a Microsoft tool instead of smth clean like OBS
extherian commented 2024-11-06 21:18:38 +00:00 (Migrated from github.com)
Copy Link

It would be great to see this merged, but we're still waiting on the sparse jit pr, which hasn't yet been tested to Greem's satisfaction, I imagine this will have to be tested just as thoroughly. I will do another reddit testing thread once the sparse jit has been merged.

It would be great to see this merged, but we're still waiting on the sparse jit pr, which hasn't yet been tested to Greem's satisfaction, I imagine this will have to be tested just as thoroughly. I will do another reddit testing thread once the sparse jit has been merged.
Digote commented 2024-11-06 21:39:20 +00:00 (Migrated from github.com)
Copy Link

MAINTAINER EDIT: These videos are h.265 encoded and seemingly only viewable in Chromium-based browsers, or via downloading & watching with a program that can handle h.265.

Note

The problem is actually not the H.265, but the Microsoft Media Foundation (MF) CDM (Content Decryption Module) DRM The video was likely recorded with a Microsoft tool instead of smth clean like OBS

Very strange, I used OBS Studio to record and Handbrake to convert it to h.265 and reduce the file size.

> > MAINTAINER EDIT: These videos are h.265 encoded and seemingly only viewable in Chromium-based browsers, or via downloading & watching with a program that can handle h.265. > > Note > > The problem is actually not the H.265, but the Microsoft Media Foundation (MF) CDM (Content Decryption Module) DRM The video was likely recorded with a Microsoft tool instead of smth clean like OBS Very strange, I used OBS Studio to record and Handbrake to convert it to h.265 and reduce the file size.
sokennethwasall commented 2024-11-10 11:50:20 +00:00 (Migrated from github.com)
Copy Link

Tested Super Smash Bro's & Echos of Wisdom on M4 Max Macbook Pro. Both seemed to run well

Tested Super Smash Bro's & Echos of Wisdom on M4 Max Macbook Pro. Both seemed to run well
bangfire commented 2024-11-10 14:10:15 +00:00 (Migrated from github.com)
Copy Link

Have you profiled this to check that the JIT is not already performing any relevant optimizations or is this just something that is suggested by IDE? As most of these contain very few potential branches, I'm unsure if the runtime would not simply lower this into identical IL.

Have you profiled this to check that the JIT is not already performing any relevant optimizations or is this just something that is suggested by IDE? As most of these contain very few potential branches, I'm unsure if the runtime would not simply lower this into identical IL.
GreemDev commented 2024-11-28 22:54:56 +00:00 (Migrated from github.com)
Copy Link

I'm pretty sure these changes are mostly redundant. the .NET compiler is very smart about converting ifs that would be more performant as switches into switches, and also the other way around; needless switches that would be faster as ifs.

as a result I'm going to reject this.

I'm pretty sure these changes are mostly redundant. the .NET compiler is very smart about converting `if`s that would be more performant as `switch`es into `switch`es, and also the other way around; needless switches that would be faster as i`f`s. as a result I'm going to reject this.
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
cpu
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#124
No description provided.
Delete Branch "switch-st"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?