MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Adds the functionality to load the Mii from Bin Amiibos. #438

Open
Jacobwasbeast wants to merge 4 commits from Jacobwasbeast/feature/mii-amiibo into master
pull from: Jacobwasbeast/feature/mii-amiibo
merge into: MeloNX:master
Conversation 1 Commits 4 Files Changed 8 +467 -120
Jacobwasbeast commented 2024-12-24 01:52:23 +00:00 (Migrated from github.com)
Copy Link

This adds missing Mii functionality for Bin Amiibos. It achieves this by parsing the Mii byte section from the Bin file and converting it into CharInfo, the format used by Ryujinx to supply Mii data. I also changed how VirtualBinAmiibos worked so the functionality is contained inside its own class so it can be improved upon in the future if necessary.

This adds missing Mii functionality for Bin Amiibos. It achieves this by parsing the Mii byte section from the Bin file and converting it into CharInfo, the format used by Ryujinx to supply Mii data. I also changed how VirtualBinAmiibos worked so the functionality is contained inside its own class so it can be improved upon in the future if necessary.
github-actions[bot] commented 2024-12-24 02:01:27 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+4676268-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357898531.zip) * [ryujinx-Release-1.2.0+4676268-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357898574.zip) * [ryujinx-Release-1.2.0+4676268-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357900756.zip) * [ryujinx-Release-1.2.0+4676268-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357900810.zip) * [ryujinx-Release-1.2.0+4676268-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357904000.zip) * [ryujinx-Release-1.2.0+4676268-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357906505.zip) <details><summary>GUI-less</summary> * [nogui-ryujinx-Release-1.2.0+4676268-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357898653.zip) * [nogui-ryujinx-Release-1.2.0+4676268-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357900872.zip) * [nogui-ryujinx-Release-1.2.0+4676268-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357904055.zip) * [nogui-ryujinx-Release-1.2.0+4676268-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357906584.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+4676268-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357898747.zip) * [ryujinx-Debug-1.2.0+4676268-linux_arm64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357898788.zip) * [nogui-ryujinx-Debug-1.2.0+4676268-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357898956.zip) * [ryujinx-Debug-1.2.0+4676268-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357902217.zip) * [ryujinx-Debug-1.2.0+4676268-linux_x64-AppImage](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357902270.zip) * [nogui-ryujinx-Debug-1.2.0+4676268-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357902348.zip) * [ryujinx-Debug-1.2.0+4676268-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357903867.zip) * [nogui-ryujinx-Debug-1.2.0+4676268-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357903946.zip) * [ryujinx-Debug-1.2.0+4676268-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357908255.zip) * [nogui-ryujinx-Debug-1.2.0+4676268-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2357908360.zip) </details>
This pull request has changes conflicting with the target branch.
  • src/Ryujinx.HLE/HOS/Horizon.cs
  • src/Ryujinx.HLE/HOS/Services/Nfc/AmiiboDecryption/AmiiboBinReader.cs
  • src/Ryujinx.HLE/HOS/Services/Nfc/Nfp/VirtualAmiibo.cs
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Jacobwasbeast/feature/mii-amiibo:Jacobwasbeast/feature/mii-amiibo
git checkout Jacobwasbeast/feature/mii-amiibo
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
horizon
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#438
No description provided.
Delete Branch "Jacobwasbeast/feature/mii-amiibo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?